Re: [PATCH] mtd: spi-nor: spansion: Add support for S28HS256T

From: "Michael Walle" <mwalle@kernel.org>
To: <tkuw584924@gmail.com>, <linux-mtd@lists.infradead.org>
Cc: <tudor.ambarus@linaro.org>, <pratyush@kernel.org>,
	<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<Bacem.Daassi@infineon.com>,
	"Takahiro Kuwano" <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH] mtd: spi-nor: spansion: Add support for S28HS256T
Date: Fri, 30 Aug 2024 08:59:59 +0200	[thread overview]
Message-ID: <D3T1W2VQFGNG.14DUML0OSKRH@kernel.org> (raw)
In-Reply-To: <20240830030841.24500-1-Takahiro.Kuwano@infineon.com>

[-- Attachment #1.1: Type: text/plain, Size: 1329 bytes --]

Hi,

> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>
> Infineon S28HS256T is 256Mb Octal SPI device which has same
> functionalities with 512Mb and 1Gb parts.
>
> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
> ---
> Datasheet can be found:
> https://www.infineon.com/dgdl/Infineon-S28HS256T_S28HL256T_256Mb_SEMPER_Flash_Octal_interface_1_8V_3-DataSheet-v02_00-EN.pdf?fileId=8ac78c8c8fc2dd9c018fc66787aa0657

As Link: tag above your SoB please.

..

> ---
>  drivers/mtd/spi-nor/spansion.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 6cc237c24e07..1390fe6f811d 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -966,6 +966,11 @@ static const struct flash_info spansion_nor_parts[] = {
>  		.name = "s28hl01gt",
>  		.mfr_flags = USE_CLPEF,
>  		.fixups = &s28hx_t_fixups,
> +	}, {
> +		.id = SNOR_ID(0x34, 0x5b, 0x19),
> +		.name = "s28hs256t",

Skip the name, we don't use names for new flashes anymore.

With that fixed you can add
Reviewed-by: Michael Walle <mwalle@kernel.org>

-michael

> +		.mfr_flags = USE_CLPEF,
> +		.fixups = &s28hx_t_fixups,
>  	}, {
>  		.id = SNOR_ID(0x34, 0x5b, 0x1a),
>  		.name = "s28hs512t",

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/