All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gaël PORTAY" <gael.portay@gmail.com>
To: "Niklas Cassel" <Niklas.Cassel@wdc.com>,
	"Gaël PORTAY" <gael.portay@rtone.fr>
Cc: Julien Grossholtz <julien.grossholtz@openest.io>,
	Michael Walle <michael@walle.cc>,
	Damien Le Moal <dlemoal@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>,
	Martin Bark <martin@barkynet.com>
Subject: Re: [Buildroot] [RFC PATCH 1/2] linux: install in-tree device-tree blob overlays
Date: Mon, 02 Sep 2024 21:57:18 +0200	[thread overview]
Message-ID: <D3W2AVQ9O5VG.7X7M72F0PVHA@gmail.com> (raw)
In-Reply-To: <ZtG5EnLkVJ1EMCTl@ryzen.lan>

Hello Niklas,

On Fri Aug 30, 2024 at 2:20 PM CEST, Niklas Cassel via buildroot wrote:
> > +config BR2_LINUX_KERNEL_INTREE_DTS_OVERLAY_NAMES
> > +	string "In-tree Device Tree Source Overlay file names"
> > +	depends on BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT
> > +	help
> > +	  Name of in-tree device tree source file, without
> > +	  the trailing -overlay.dts. You can provide a list of
> > +	  dts files to build, separated by spaces.
>
> I do not like that you assume that the DT overlay has a -overlay.dts suffix,
> that seems to be something specific for the raspberry pi downstream kernel.
>
> Most device tree overlays in the upstream kernel simply have a .dtso suffix:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=40658534756f8369e93b84fa75c20bde6528cb82
>
> So it would be nice if your patch supported that as well.
>

Thank you very much to let me know about that! I have missed it
entirely.

I based my work on linux 5.15 (raspberrypi), that may explain.

However, I figured out the out-of-tree built is broken, facepalm.

I will post a v1 with the fix.

> Also see this other proposal from Michael Walle:
> https://lore.kernel.org/buildroot/20240213154847.914068-1-michael@walle.cc/
>

I will have a look at it later, thanks.

> Kind regards,
> Niklas

Kind Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-09-02 19:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 14:09 [Buildroot] [RFC PATCH 0/2] linux: install in-tree device-tree blob overlays Gaël PORTAY
2024-04-12 14:09 ` [Buildroot] [RFC PATCH 1/2] " Gaël PORTAY
2024-08-30 12:20   ` Niklas Cassel via buildroot
2024-09-02 19:57     ` Gaël PORTAY [this message]
2024-04-12 14:09 ` [Buildroot] [RFC PATCH 2/2] board/raspberrypi: " Gaël PORTAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D3W2AVQ9O5VG.7X7M72F0PVHA@gmail.com \
    --to=gael.portay@gmail.com \
    --cc=Niklas.Cassel@wdc.com \
    --cc=buildroot@buildroot.org \
    --cc=dlemoal@kernel.org \
    --cc=gael.portay@rtone.fr \
    --cc=julien.grossholtz@openest.io \
    --cc=martin@barkynet.com \
    --cc=michael@walle.cc \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.