From: Lawrence Brakmo <brakmo@fb.com>
To: Neal Cardwell <ncardwell@google.com>, Yuchung Cheng <ycheng@google.com>
Cc: netdev <netdev@vger.kernel.org>, Kernel Team <Kernel-team@fb.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>
Subject: Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit
Date: Wed, 28 Sep 2016 05:07:16 +0000 [thread overview]
Message-ID: <D4109D86.1F361%brakmo@fb.com> (raw)
In-Reply-To: <CADVnQykozyJ3nnHz956aXnT9c+cEqUmf0HMqSHjbKQXWiMoSTA@mail.gmail.com>
Neal and Yuchung, thank you for the feedback. I¹ve submitted v4 with your
recommended changes.
Thanks,
Larry
On 9/27/16, 6:28 PM, "Neal Cardwell" <ncardwell@google.com> wrote:
>On Tue, Sep 27, 2016 at 8:18 PM, Yuchung Cheng <ycheng@google.com> wrote:
>> On Tue, Sep 27, 2016 at 4:31 PM, Lawrence Brakmo <brakmo@fb.com> wrote:
>>> @@ -213,6 +215,8 @@ static int tcp_write_timeout(struct sock *sk)
>>> tcp_mtu_probing(icsk, sk);
>>>
>>> dst_negative_advice(sk);
>>> + } else if (prandom_u32_max(100) <
>>>sysctl_tcp_rto_txhash_prob) {
>> The sysctl is not really needed but that's just my opinion.
>
>I agree that it sounds nice to simplify by not having a sysctl for
>this and always calling sk_rethink_txhash() here.
>
>neal
prev parent reply other threads:[~2016-09-28 5:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 23:31 [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit Lawrence Brakmo
2016-09-28 0:18 ` Yuchung Cheng
2016-09-28 1:28 ` Neal Cardwell
2016-09-28 5:07 ` Lawrence Brakmo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4109D86.1F361%brakmo@fb.com \
--to=brakmo@fb.com \
--cc=Kernel-team@fb.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.