Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

[Rakesh Ranjan <Rakesh.Ranjan@veritas.com>]

Hi Jeff etc al,

Thanks a lot for your due diligence to review the code changes throughly
and providing comments, suggestions to improve. We are completely on top
of this and have already started to expedite the overall development.

We would like to get you help regarding the applicability of qemu-iotests
test harness against a QEMU block driver which doesn¹t support create
operation. Where we can find the detailed document regarding qemu-iotests
test harness and and it¹s dependency on a particular block driver?

We have enhanced the test server utility (qnio_server) a bit and conducted
manual tests, which mainly includes qemu-img convert and qemu-io read and
write operations.

# libqnio/src/test/

@ Create vDisk file of size 10G
 
	# ./create_vdisk.sh
	Usage: create_vdisk <filename> <size in MB>


	# ./create_vdisk.sh /qemublk_test/vDisk1 10240


	# ls -lhs /qemublk_test/vDisk1
	1.1M -rw-r--r-- 1 root root 10G Oct 27 17:02 /qemublk_test/vDisk1



@ Start qnio_server

	# ./qnio_server -h
	Usage: qnio_server [-d <directory>] [-p] [-v] [-h]
	d -> Vdisk directory
	p -> Run commands in separate thread
	h -> Help
	v -> Verbose


	# ./qnio_server -d /qemublk_test/



@ Convert qcow2 image to vxhs raw format

# ./qemu-img convert -f qcow2 -O raw -n /qemublk_test/centos-64.qcow2
vxhs://127.0.0.1:9999/vDisk1




-Rakesh

On 10/27/16, 2:38 AM, "ashish mittal" <ashmit602@gmail.com> wrote:

>Hi Daniel,
>
>>> >I think this version still does not address Daniel's concerns
>>>regarding a
>>> >QAPI schema for vxhs.
>>>
>>> We are working on QAPI schema changes and will submit them in separate
>>> patch.
>>
>> They should be part of the main patch, not a separate patch as they are
>> a pre-requisite for any new block driver.
>>
>
>I guess what Madhav meant was that this patch (v2) is missing the QAPI
>changes, and we will provide those in the next version ASAP.
>
>Regards,
>Ashish
>
>On Thu, Oct 27, 2016 at 12:29 AM, Daniel P. Berrange
><berrange@redhat.com> wrote:
>> On Wed, Oct 26, 2016 at 03:23:05PM -0700, Ashish Mittal wrote:
>>> This patch adds support for a new block device type called "vxhs".
>>> Source code for the library that this code loads can be downloaded
>>>from:
>>> https://github.com/MittalAshish/libqnio.git
>>>
>>> Sample command line using JSON syntax:
>>> ./qemu-system-x86_64 -name instance-00000008 -S -vnc 0.0.0.0:0 -k
>>>en-us -vga cirrus -device
>>>virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg timestamp=on
>>>'json:{"driver":"vxhs","vdisk_id":"{c3e9095a-a5ee-4dce-afeb-2a59fb387410
>>>}","server":[{"host":"172.172.17.4","port":"9999"}]}'
>>>
>>> Sample command line using URI syntax:
>>> qemu-img convert -f raw -O raw -n
>>>/var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad
>>>vxhs://192.168.0.1:9999/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D
>>>
>>> Signed-off-by: Ashish Mittal <ashish.mittal@veritas.com>
>>> ---
>>> v2 changelog:
>>> (1) Changes done in response to v1 comments.
>>
>> Yet again you've ignored the request to include the QAPI schema changes
>>
>>>  block/Makefile.objs |   2 +
>>>  block/trace-events  |  22 ++
>>>  block/vxhs.c        | 682
>>>++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  configure           |  41 ++++
>>>  4 files changed, 747 insertions(+)
>>>  create mode 100644 block/vxhs.c
>>
>> Regards,
>> Daniel
>> --
>> |: http://berrange.com      -o-
>>http://www.flickr.com/photos/dberrange/ :|
>> |: http://libvirt.org              -o-
>>http://virt-manager.org :|
>> |: http://entangle-photo.org       -o-
>>http://search.cpan.org/~danberr/ :|