From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E14B51AD9C0; Tue, 24 Sep 2024 16:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727193914; cv=none; b=PLQ5STJDdDp5n4HQsPNL8YbsjR2snfJygDpGl41P3Ic3T39b2zYHRRQn5KZBScA0GdScw44e9PCLEeslytLqp7ZLKwoNGtOZPGt+BvTeHyIiAkxBQLLzs8YwtzLYUIy2p9JoiqubsO4ny65x/c+TaJLJ/4mJ3lOXKHipe6DEbhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727193914; c=relaxed/simple; bh=mZ42CM4kCLM+8EKFdf2GzoGmoR2FGfpOWwtq0wy6W8c=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=WaBmFcI9zKyyMtVrB4ufDgSNUZAGAGwprvItdO6s4rkBZ4hHccNQw7i4BryyKbPXNAN82xCd7LPoP54jNALUIebGvfMXs/L+FJn7SegZhXG5xyh8omZZVpaOmbEaUJ1O7GCYdVU2LDo4XbJF5PJy0K8OFlrXaF03berdBZGdKsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gp3Puujc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gp3Puujc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50423C4CEC7; Tue, 24 Sep 2024 16:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727193913; bh=mZ42CM4kCLM+8EKFdf2GzoGmoR2FGfpOWwtq0wy6W8c=; h=Date:To:Cc:Subject:From:References:In-Reply-To:From; b=gp3PuujcSy8Mg1vuUsMXXyhEud0Oj/ZzFkw9tnzymjELjGIJPVJ7QCtMPWCklGpTo m7eCb5C4byxIB2QislN26WrjiNkVKDpfZzIl57UqtmKE7aVR7kjD7Gf5YX15NPPc9o 0EeL7tA0Kx/VKBjT1dHg0KTZ8iU6u0GM33F2RbZchbSjnnP3pMrlhKQOzBK+IYgH9l hPoqX6R8PxPzk47/MTWR1fg49wvHWg36GuZIV2zWs6OaHinjZCGjcJiIbWW30wc6bs 8epb8UDIk5KGsQdD4xIPSBNJAraq9p3Hde1Cx1MSewCGhvknC4igakNAvnZYFgQqWp pMrpAn2BZk4YQ== Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 24 Sep 2024 19:05:09 +0300 Message-Id: To: "Herbert Xu" , "Greg KH" Cc: "Linux Crypto Mailing List" , "Guangwu Zhang" , "Peter Huewe" , "Jason Gunthorpe" , , "James Bottomley" Subject: Re: [PATCH] hwrng: core - Add WARN_ON for buggy read return values From: "Jarkko Sakkinen" X-Mailer: aerc 0.18.2 References: <2024092340-renovate-cornflake-4b5e@gregkh> In-Reply-To: On Tue Sep 24, 2024 at 1:32 AM EEST, Herbert Xu wrote: > On Mon, Sep 23, 2024 at 04:48:27PM +0200, Greg KH wrote: > > > > Please see: > > https://www.kernel.org/doc/html/latest/process/deprecated.html#bug-and= -bug-on > > which describes that. We should make it more explicit that any WARN() > > or WARN_ON() calls that can be hit by user interactions somehow, will > > end up getting a CVE id when we fix it up to not do so. > > If the aformentioned WARN_ON hits, then the driver has probabaly > already done a buffer overrun so it's a CVE anyway. We'll see I finally got into testing this. Sorry for latencies, I'm switching jobs and unfortunately German Post Office lost my priority mail containing contracts (sent them from Finland to Berlin) so have been signing, scanning etc. the whole day :-) My last week in the current job, and next week is the first in the new job, so this week is a bit bumpy. BR, Jarkko