Re: [PATCH v2 00/11] wifi: ath12k: some fixes and clean up for monitor mode

["Nicolas Escande" <nico.escande@gmail.com>]

On Wed Oct 9, 2024 at 10:35 AM CEST, Kang Yang wrote:
>
>
> On 10/9/2024 4:25 PM, Nicolas Escande wrote:
> > On Tue Oct 8, 2024 at 9:35 AM CEST, Kang Yang wrote:
> >> This patch set does some fixes and clean up for monitor mode.
> >>
> >> v2: rebase on tag: ath-202410072115.
> >>
> >> Kang Yang (11):
> >>    wifi: ath12k: remove unused variable monitor_present
> >>    wifi: ath12k: optimize storage size for struct ath12k
> >>    wifi: ath12k: fix struct hal_rx_ppdu_end_user_stats
> >>    wifi: ath12k: fix struct hal_rx_ppdu_start
> >>    wifi: ath12k: fix struct hal_rx_phyrx_rssi_legacy_info
> >>    wifi: ath12k: fix struct hal_rx_mpdu_start
> >>    wifi: ath12k: properly handling the state variables of monitor mode
> >>    wifi: ath12k: delete NSS and TX power setting for monitor vdev
> >>    wifi: ath12k: use tail MSDU to get MSDU information
> >>    wifi: ath12k: fix A-MSDU indication in monitor mode
> >>    wifi: ath12k: delete mon reap timer
> >>
> >>   drivers/net/wireless/ath/ath12k/core.c   |   5 ++
> >>   drivers/net/wireless/ath/ath12k/core.h   |  23 +++--
> >>   drivers/net/wireless/ath/ath12k/dp.c     |  25 ------
> >>   drivers/net/wireless/ath/ath12k/dp_mon.c | 108 ++++++++++++-----------
> >>   drivers/net/wireless/ath/ath12k/hal_rx.h |  53 ++++++-----
> >>   drivers/net/wireless/ath/ath12k/mac.c    |  24 +++--
> >>   6 files changed, 114 insertions(+), 124 deletions(-)
> >>
> >>
> >> base-commit: b9545f4570fcfebe982439de7c9106e55b4bf756
> > 
> > Hello,
> > 
> > Two quick questions there:
> >   - If monitor works for wcn7850 shouldn't you set supports_monitor=true in hw.c
> >     Or does it still require more work for it work ?
>
> Yes, still have many monitor mode patches. Will set this hw parameter in 
> those patches.
Got it.
>
>
> >   - This whole series seems to have been tested only with wcn7850 and not qcn9274
> >     Is it still not supported on qcn9274 ?
>
> Actually, this is classic monitor mode for wcn7850, not sure whether 
> qcn9274 supports it(I think theoretically it is supported).
> As far as I know, they are using full monitor mode.
Ha ok, yes full monitor is what we really care about.
>
> > 
> > Thanks

Thanks