From: "Alejandro Vallejo" <alejandro.vallejo@cloud.com>
To: "Jan Beulich" <jbeulich@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86emul/test: correct loop body indentation in evex-disp8.c:test_one()
Date: Wed, 16 Oct 2024 13:22:14 +0100 [thread overview]
Message-ID: <D4X86F05Q1PD.FNSXTCN2F8KC@cloud.com> (raw)
In-Reply-To: <86229731-c999-4c02-a561-e8fc0bb82fc5@suse.com>
On Wed Oct 16, 2024 at 11:15 AM BST, Jan Beulich wrote:
> On 16.10.2024 12:06, Alejandro Vallejo wrote:
> > On Wed Oct 16, 2024 at 8:45 AM BST, Jan Beulich wrote:
> >> For some reason I entirely consistently screwed these up.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
> > Reviewed-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
>
> Thanks.
>
> > We should really give another push to the clang-format effort. This whole class
> > of mistakes would be a thing of the past.
>
> For issues like the one here it would depend on whether that would also be
> applied to (parts of) tool stack code. The plans, iirc, were mainly to cover
> the xen/ subtree.
>
> Jan
True, but AIUI that was merely an act of scope reduction for the sake of
getting something merged in a finite time frame. In an ideal world the whole
codebase would be covered, and I think this was a shared sentiment among those
in favour.
Cheers,
Alejandro
prev parent reply other threads:[~2024-10-16 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 7:45 [PATCH] x86emul/test: correct loop body indentation in evex-disp8.c:test_one() Jan Beulich
2024-10-16 10:06 ` Alejandro Vallejo
2024-10-16 10:15 ` Jan Beulich
2024-10-16 12:22 ` Alejandro Vallejo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4X86F05Q1PD.FNSXTCN2F8KC@cloud.com \
--to=alejandro.vallejo@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.