From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>,
<linux-integrity@vger.kernel.org>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"James Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: "David Howells" <dhowells@redhat.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Roberto Sassu" <roberto.sassu@huawei.com>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v7 1/5] tpm: Return on tpm2_create_null_primary() failure
Date: Thu, 24 Oct 2024 14:22:17 +0300 [thread overview]
Message-ID: <D53ZWVR69ZG1.3CT6HRHCJI68W@kernel.org> (raw)
In-Reply-To: <bb9ef4af-4a35-40e2-85cc-bcacae4f2dbc@linux.ibm.com>
On Wed Oct 23, 2024 at 8:46 PM EEST, Stefan Berger wrote:
>
>
> On 10/21/24 1:39 AM, Jarkko Sakkinen wrote:
> > tpm2_sessions_init() does not ignore the result of
> > tpm2_create_null_primary(). Address this by returning -ENODEV to the
> > caller. Given that upper layers cannot help healing the situation
>
> It looks like returning -ENODEV applied to a previous version of the patch.
>
> > further, deal with the TPM error here by
>
> This sounds like an incomplete sentence...
It looks like totally corrupted, thanks for the remark.
"tpm2_sessions_init() ignores the return value of tpm2_create_null_primary().
Fail early and return back to the caller if it fails. Fine-tune the error
message while at it."
Is this sufficient?
BR, Jarkko
next prev parent reply other threads:[~2024-10-24 11:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 5:39 [PATCH v7 0/5] Lazy flush for the auth session Jarkko Sakkinen
2024-10-21 5:39 ` [PATCH v7 1/5] tpm: Return on tpm2_create_null_primary() failure Jarkko Sakkinen
2024-10-23 17:46 ` Stefan Berger
2024-10-24 11:22 ` Jarkko Sakkinen [this message]
2024-10-21 5:39 ` [PATCH v7 2/5] tpm: Implement tpm2_load_null() rollback Jarkko Sakkinen
2024-10-23 17:38 ` Stefan Berger
2024-10-21 5:39 ` [PATCH v7 3/5] tpm: flush the null key only when /dev/tpm0 is accessed Jarkko Sakkinen
2024-10-23 18:18 ` Stefan Berger
2024-10-24 11:25 ` Jarkko Sakkinen
2024-10-21 5:39 ` [PATCH v7 4/5] tpm: Allocate chip->auth in tpm2_start_auth_session() Jarkko Sakkinen
2024-10-23 19:15 ` Stefan Berger
2024-10-24 11:28 ` Jarkko Sakkinen
2024-10-24 12:59 ` Stefan Berger
2024-10-25 14:45 ` Jarkko Sakkinen
2024-10-21 5:39 ` [PATCH v7 5/5] tpm: flush the auth session only when /dev/tpm0 is open Jarkko Sakkinen
2024-10-23 19:28 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D53ZWVR69ZG1.3CT6HRHCJI68W@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.