Re: [PATCH] usertools/devbind: support all possible values sysfs flag

["Robin Jarry" <rjarry@redhat.com>]

Hi,

Rogelio Domínguez Hernández, Nov 12, 2024 at 14:15:
> This patch adds support for 'y' and 'Y' values when reading
> vfio-pci unsafe_noiommu_mode flag.
>
> Possible values were taken from linux kernel
> (sysfs__read_bool() in tools/lib/api/fs/fs.c)
>
> Signed-off-by: Rogelio Domínguez Hernández <rogelio.dominguez@gmail.com>
> ---
>  usertools/dpdk-devbind.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 80c35f9ab6..548898d59e 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -490,7 +490,8 @@ def check_noiommu_mode():
>  
>      try:
>          with open(filename, "r") as f:
> -            if f.read(1) == "1":
> +            value = f.read(1)
> +            if value == "1" or value == "y" or value == "Y":

Minor detail, could you rewrite it as:

            if value in ("1", "y", "Y"):

>                  return
>      except OSError as err:
>          sys.exit(f"Error: failed to check unsafe noiommu mode - Cannot open {filename}: {err}")
> -- 
> 2.45.2

Thanks!