All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <quentin.schulz@cherry.de>, <docs@lists.yoctoproject.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [docs] [yocto-docs PATCH v2 2/6] poky.yaml.in: replace inkscape dependency by librsvg2-bin
Date: Mon, 09 Dec 2024 18:02:11 +0100	[thread overview]
Message-ID: <D67BY6MY256H.2XQGZF5AGJM19@bootlin.com> (raw)
In-Reply-To: <0fc67e83-4c38-4274-bb38-905f0db1a4d1@cherry.de>

Hi Quentin,

On Fri Dec 6, 2024 at 2:56 PM CET, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Antonin,
>
> On 12/4/24 1:23 PM, Antonin Godard wrote:
>> inkscape used to be a requirement to convert SVG images to PNGs/PDFs,
>> but we replaced it recently by rsvg-convert.
>> 
>> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
>
> I would recommend to order the commits differently.
>
> I believe patch 1/6 and 6/6 can be backported to earlier releases. But 
> by having 2/6 modify the same part of the code, it is possible that 6/6 
> won't cleanly apply when backporting. If we were to reorder the patches 
> and have 6/6 before 2/6, this should not happen.
>
> It's anyway you that would experience the pain of backporting and 
> resolving conflicts, if there's any, so up to you :)

True, true! Thanks for thinking about this, I'll re-order. :)


Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2024-12-09 17:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 12:23 [yocto-docs PATCH v2 0/6] Update the dependencies in poky.yaml.in Antonin Godard
2024-12-04 12:23 ` [yocto-docs PATCH v2 1/6] Gather " Antonin Godard
2024-12-06 13:51   ` Quentin Schulz
2024-12-09 17:02     ` Antonin Godard
2024-12-09 17:30       ` Quentin Schulz
2024-12-10  9:58     ` Antonin Godard
2024-12-10 10:29       ` Quentin Schulz
2024-12-04 12:23 ` [yocto-docs PATCH v2 2/6] poky.yaml.in: replace inkscape dependency by librsvg2-bin Antonin Godard
2024-12-06 13:56   ` Quentin Schulz
2024-12-09 17:02     ` Antonin Godard [this message]
2024-12-04 12:23 ` [yocto-docs PATCH v2 3/6] system-requirements: add fedora 39 to supported distros Antonin Godard
2024-12-04 12:23 ` [yocto-docs PATCH v2 4/6] system-requirements: update list of " Antonin Godard
2024-12-04 12:23 ` [yocto-docs PATCH v2 5/6] system-requirements.rst: add dependencies for pdf builds Antonin Godard
2024-12-06 14:00   ` Quentin Schulz
2024-12-09 17:02     ` Antonin Godard
2024-12-09 17:28       ` [docs] " Quentin Schulz
2024-12-10  9:33         ` Antonin Godard
2024-12-10 10:34           ` Quentin Schulz
2024-12-04 12:23 ` [yocto-docs PATCH v2 6/6] poky.yaml.in: add missing locales dependency Antonin Godard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D67BY6MY256H.2XQGZF5AGJM19@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=quentin.schulz@cherry.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.