From: Kees Cook <kees@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>, linux-hardening@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Subject: Re: [PATCH 2/2] pstore: Replace crypto API compression with zlib_deflate library calls
Date: Tue, 04 Jul 2023 09:48:30 -0700 [thread overview]
Message-ID: <D690FB7B-BE46-4A56-9BDE-AB84652997D3@kernel.org> (raw)
In-Reply-To: <20230704135211.2471371-3-ardb@kernel.org>
On July 4, 2023 6:52:11 AM PDT, Ard Biesheuvel <ardb@kernel.org> wrote:
>@@ -217,10 +220,6 @@ static void allocate_buf_for_compression(void)
>
> static void free_buf_for_compression(void)
> {
>- if (IS_ENABLED(CONFIG_PSTORE_COMPRESS) && tfm) {
>- crypto_free_comp(tfm);
>- tfm = NULL;
>- }
> kfree(big_oops_buf);
> big_oops_buf = NULL;
> big_oops_buf_sz = 0;
I think this is missing a free of compress_workspace? Everything else looks great! What kind of testing did you do for this series?
--
Kees Cook
next prev parent reply other threads:[~2023-07-04 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 13:52 [PATCH 0/2] pstore: Replace crypto API compression with zlib calls Ard Biesheuvel
2023-07-04 13:52 ` [PATCH 1/2] pstore: Remove worst-case compression size logic Ard Biesheuvel
2023-07-04 18:07 ` Eric Biggers
2023-07-04 13:52 ` [PATCH 2/2] pstore: Replace crypto API compression with zlib_deflate library calls Ard Biesheuvel
2023-07-04 16:48 ` Kees Cook [this message]
2023-07-04 16:56 ` Ard Biesheuvel
2023-07-04 18:31 ` Eric Biggers
2023-07-04 16:08 ` [PATCH 0/2] pstore: Replace crypto API compression with zlib calls Kees Cook
2023-07-04 18:30 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D690FB7B-BE46-4A56-9BDE-AB84652997D3@kernel.org \
--to=kees@kernel.org \
--cc=ardb@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.