From: Bradley Morgan <bradley.morgan@linux.dev>
To: pmenzel@molgen.mpg.de
Cc: atomlin@atomlin.com, da.gomez@kernel.org,
dmitry.torokhov@gmail.com, dsterba@suse.com,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
lucjan.lucjanov@gmail.com, mcgrof@kernel.org,
petr.pavlu@suse.com, samitolvanen@google.com,
swboyd@chromium.org, terrelln@fb.com
Subject: Re: [PATCH] module/decompress: Use ssize_t for the zstd decompressed size
Date: Sun, 15 Nov 2026 17:44:58 +0000 [thread overview]
Message-ID: <D6BEFB3F-B86C-4483-9CD4-D45C85ADE338@linux.dev> (raw)
In-Reply-To: <20261115145559.262878-1-pmenzel@molgen.mpg.de>
On 15 November 2026 14:55:56 GMT, Paul Menzel <pmenzel@molgen.mpg.de>
wrote:
>module_zstd_decompress() returns ssize_t, but keeps the decompressed
>size in the int retval. Output of 2 GiB or more becomes a negative
>value that is not an errno, and output of 4 GiB or more can also be
>truncated to a positive size smaller than the pages mapped to
>info->hdr. Declare retval as ssize_t like module_gzip_decompress() and
>module_xz_decompress() do, and print it with %zd.
>
>The Sashiko AI review found the same bug in the proposed LZ4 decoder,
>which is modelled on the zstd decoder [1].
>
>The x86_64 build boots in QEMU/KVM, and finit_module() with
>MODULE_INIT_COMPRESSED_FILE and module.sig_enforce=1 decompresses the
>237 .ko.zst modules without error.
>
>Fixes: 169a58ad824d ("module/decompress: Support zstd in-kernel decompression")
>Link: https://sashiko.dev/#/patchset/20261113144233.193782-1-pmenzel@molgen.mpg.de?part=1 [1]
Closes: and Reported-by: sashiko ?
Reviewed-by: Bradley Morgan <bradley.morgan@linux.dev>
>Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>---
>
>Notes:
> Claude Opus 5.5 (Claude Code) noticed that the zstd decoder has the
> bug Sashiko reported for the LZ4 patch, and wrote this patch and
> message. Tests: W=1 compile with GCC 16.2 for x86_64 (Debian config)
> and i386 (tinyconfig), both with MODULE_COMPRESS_ZSTD. Run time: the
> x86_64 build boots in QEMU/KVM, and finit_module() with
> MODULE_INIT_COMPRESSED_FILE and module.sig_enforce=1 decompresses the
> 237 .ko.zst modules of a laptop's boot set without error; 223 load,
> 14 fail in their init for lack of hardware, as with xz. The bug itself
> is not exercised; it needs a module that decompresses to 2 GiB or more.
>
> kernel/module/decompress.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/kernel/module/decompress.c b/kernel/module/decompress.c
>index cce098671be97..ac4ff0e04f716 100644
>--- a/kernel/module/decompress.c
>+++ b/kernel/module/decompress.c
>@@ -216,7 +216,7 @@ static ssize_t module_zstd_decompress(struct load_info *info,
> ZSTD_DStream *dstream;
> size_t ret;
> size_t new_size = 0;
>- int retval;
>+ ssize_t retval;
Why signed? Ok then.
>
> if (size < sizeof(signature) ||
> memcmp(buf, signature, sizeof(signature))) {
>@@ -276,7 +276,7 @@ static ssize_t module_zstd_decompress(struct load_info *info,
> } while (zstd_dec.pos == PAGE_SIZE && ret != 0);
>
> if (retval) {
>- pr_err("ZSTD-decompression failed with status %d\n", retval);
>+ pr_err("ZSTD-decompression failed with status %zd\n", retval);
> retval = -EINVAL;
> goto out;
> }
>
--- Thanks!
prev parent reply other threads:[~2026-11-15 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 14:55 [PATCH] module/decompress: Use ssize_t for the zstd decompressed size Paul Menzel
2026-11-15 17:44 ` Bradley Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6BEFB3F-B86C-4483-9CD4-D45C85ADE338@linux.dev \
--to=bradley.morgan@linux.dev \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dsterba@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucjan.lucjanov@gmail.com \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=pmenzel@molgen.mpg.de \
--cc=samitolvanen@google.com \
--cc=swboyd@chromium.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.