From: "Thomas Bonnefille" <thomas.bonnefille@bootlin.com>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: "Thomas Bonnefille via buildroot" <buildroot@buildroot.org>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Mahyar Koshkouei" <mahyar.koshkouei@gmail.com>,
"Eric Le Bihan" <eric.le.bihan.dev@free.fr>
Subject: Re: [Buildroot] [PATCH] package/mpv: use meson instead of waf
Date: Thu, 26 Dec 2024 21:36:08 +0100 [thread overview]
Message-ID: <D6LX599XS2MF.1JC5T1ZV0NEWQ@bootlin.com> (raw)
In-Reply-To: <20241226160146.3a93f3c8@windsurf>
Hello Thomas,
>
> ...
>
> > Can you develop ? I'm not sure what kind of regression can be introduced
> > ?
> > I don't know if it answers the question but the meson build system has
> > been added to mpv with "waf-compatibility" in mind and so all the
> > options were translated from waf to meson. [1]
>
> When you switch to one build system (waf) to another (meson), there is
> a fairly high chance that the way dependencies are detected is going to
> be slightly different, causing some subtle differences in behavior.
> After all, all the dependency detection logic and all the build logic
> is completely changed. We have regularly seen regressions when switch
> from build system A to build system B. Of course, it doesn't mean it
> shouldn't be done, but it means that considering such a switch as a fix
> for our LTS branch is clearly not good.
Thank you for this explanation.
> In addition to this migration to meson, what about bumping to a newer
> version of mpv? Of course, in a separate commit.
Yes, it's totally possible but many things moved forward in mpv and a
bump is a little bit more complicated.
I've already worked on this issue in my Buildroot's fork [1] and it
requires two more packages and therefore a significantly bigger patch
serie.
Thank you,
Thomas
[1] : https://github.com/Taumille/buildroot/tree/b4/bump_mpv
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-12-26 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 17:19 [Buildroot] [PATCH] package/mpv: use meson instead of waf Thomas Bonnefille via buildroot
2024-12-22 15:18 ` Thomas Petazzoni via buildroot
2024-12-22 18:25 ` Thomas Bonnefille
2024-12-26 15:01 ` Thomas Petazzoni via buildroot
2024-12-26 20:36 ` Thomas Bonnefille [this message]
2024-12-26 20:46 ` Thomas Petazzoni via buildroot
2024-12-26 15:39 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6LX599XS2MF.1JC5T1ZV0NEWQ@bootlin.com \
--to=thomas.bonnefille@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=mahyar.koshkouei@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.