From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Ard Biesheuvel" <ardb@kernel.org>
Cc: <linux-integrity@vger.kernel.org>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Joe Hattori" <joe@pf.is.s.u-tokyo.ac.jp>,
"James Bottomley" <James.Bottomley@hansenpartnership.com>,
"Stefan Berger" <stefanb@linux.ibm.com>,
"Roberto Sassu" <roberto.sassu@huawei.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Andy Liang" <andy.liang@hpe.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] tpm: Map the ACPI provided event log
Date: Fri, 27 Dec 2024 12:49:46 +0200 [thread overview]
Message-ID: <D6MFAUNRJ8GX.22HLDPXR7EZ5W@kernel.org> (raw)
In-Reply-To: <CAMj1kXFB6NL4EASV9_XeRM=iYaoVHQks0pXyVt2tGSQbD-St6g@mail.gmail.com>
On Fri Dec 27, 2024 at 10:43 AM EET, Ard Biesheuvel wrote:
> On Fri, 27 Dec 2024 at 07:01, Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > The following failure was reported:
> >
> > [ 10.693310][ T1] tpm_tis STM0925:00: 2.0 TPM (device-id 0x3, rev-id 0)
> > [ 10.848132][ T1] ------------[ cut here ]------------
> > [ 10.853559][ T1] WARNING: CPU: 59 PID: 1 at mm/page_alloc.c:4727 __alloc_pages_noprof+0x2ca/0x330
> > [ 10.862827][ T1] Modules linked in:
> > [ 10.866671][ T1] CPU: 59 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-lp155.2.g52785e2-default #1 openSUSE Tumbleweed (unreleased) 588cd98293a7c9eba9013378d807364c088c9375
> > [ 10.882741][ T1] Hardware name: HPE ProLiant DL320 Gen12/ProLiant DL320 Gen12, BIOS 1.20 10/28/2024
> > [ 10.892170][ T1] RIP: 0010:__alloc_pages_noprof+0x2ca/0x330
> > [ 10.898103][ T1] Code: 24 08 e9 4a fe ff ff e8 34 36 fa ff e9 88 fe ff ff 83 fe 0a 0f 86 b3 fd ff ff 80 3d 01 e7 ce 01 00 75 09 c6 05 f8 e6 ce 01 01 <0f> 0b 45 31 ff e9 e5 fe ff ff f7 c2 00 00 08 00 75 42 89 d9 80 e1
> > [ 10.917750][ T1] RSP: 0000:ffffb7cf40077980 EFLAGS: 00010246
> > [ 10.923777][ T1] RAX: 0000000000000000 RBX: 0000000000040cc0 RCX: 0000000000000000
> > [ 10.931727][ T1] RDX: 0000000000000000 RSI: 000000000000000c RDI: 0000000000040cc0
> >
> > Above shows that ACPI pointed a 16 MiB buffer for the log events because
> > RSI maps to the 'order' parameter of __alloc_pages_noprof(). Address the
> > bug by mapping the region when needed instead of copying.
> >
> > Earlier fix does address the warning but wastes 16 MiB of memory. This
> > finalizes the fix.
> >
> > Suggested-by: Matthew Garrett <mjg59@srcf.ucam.org>
> > Tested-by: Andy Liang <andy.liang@hpe.com>
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> Where are patch 1/2 and the cover letter?
https://lore.kernel.org/linux-integrity/20241227060053.174314-1-jarkko@kernel.org/T/#mc34835f6d6f946c50a580f895f24b7b1dab85204
You did not request a cover letter, and I did not think it was
really necessary. I can do it for next version on request.
BR, Jarkko
next prev parent reply other threads:[~2024-12-27 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 6:00 [PATCH v7 1/2] tpm: Map the ACPI provided event log Jarkko Sakkinen
2024-12-27 6:00 ` [PATCH v7 2/2] " Jarkko Sakkinen
2024-12-27 8:43 ` Ard Biesheuvel
2024-12-27 10:49 ` Jarkko Sakkinen [this message]
2024-12-27 10:52 ` Jarkko Sakkinen
2024-12-27 15:15 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6MFAUNRJ8GX.22HLDPXR7EZ5W@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andy.liang@hpe.com \
--cc=ardb@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=jgg@ziepe.ca \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
--cc=stefanb@linux.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.