All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Khaled Elnaggar" <khaledelnaggarlinux@gmail.com>,
	<peterhuewe@gmx.de>, <jgg@ziepe.ca>, <shuah@kernel.org>
Cc: <linux-kernel-mentees@vger.kernel.org>,
	<linux-integrity@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] selftests: tpm2: create a dedicated .gitignore
Date: Fri, 24 Jan 2025 18:37:47 +0200	[thread overview]
Message-ID: <D7AG8K6T8KRI.LZFD4J6OFGGZ@kernel.org> (raw)
In-Reply-To: <d7c0995d-5159-47a8-9193-d9d29fdfeea0@gmail.com>

On Fri Jan 24, 2025 at 4:35 PM EET, Khaled Elnaggar wrote:
> On 1/23/25 11:47 AM, Jarkko Sakkinen wrote: 
> > Why?
>
> Sorry I should have included v1 in the thread but I am still
> new to the LKML process.

No worries, relax, it was just  a one wonder question :-)

>
> Basically tpm2 selftests have 2 leftover log files after running
> (namely AsyncTest.log and SpaceTest.log). Only SpaceTest.log
> is in selftests/.gitignore while AsyncTest.log appears untracked
> with git status.
>
> To solve this, one could either append AsyncTest.log to 
> selftests/.gitignore or create a dedicated .gitignore for 
> the tpm2 subsystem tests. The 2nd approach is better in order
> to not clutter selftests/.gitignore and keep tpm2 isolated.
>
> Shuah actually suggested the 2nd approach in reply to v1.
>
> Would you like me to resubmit this patch with a clearer message?
> Or include v1 in the thread?

Yep, please do, your rationale makes sense, just write it down
to the commit message, and that's all I'm asking for.

>
> Thanks
> Khaled

BR, Jarkko

  reply	other threads:[~2025-01-24 16:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22  6:50 [PATCH v2] selftests: tpm2: create a dedicated .gitignore Khaled Elnaggar
2025-01-23  9:47 ` Jarkko Sakkinen
2025-01-24 14:35   ` Khaled Elnaggar
2025-01-24 16:37     ` Jarkko Sakkinen [this message]
2025-01-24 16:42       ` Jarkko Sakkinen
2025-01-25  8:58         ` Khaled Elnaggar
2025-01-25 19:20           ` Jarkko Sakkinen
2025-01-26 10:50             ` Khaled Elnaggar
2025-01-26 14:22 ` [PATCH v3] " Khaled Elnaggar
2025-01-26 16:30   ` Jarkko Sakkinen
2025-01-26 19:51   ` [PATCH v4] " Khaled Elnaggar
2025-01-27 17:18     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D7AG8K6T8KRI.LZFD4J6OFGGZ@kernel.org \
    --to=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=khaledelnaggarlinux@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel-mentees@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.