From: "Alejandro Vallejo" <alejandro.vallejo@cloud.com>
To: "Jan Beulich" <jbeulich@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 11/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor()
Date: Mon, 27 Jan 2025 15:48:01 +0000 [thread overview]
Message-ID: <D7CZ23KACJ16.A4EFWQ1X682K@cloud.com> (raw)
In-Reply-To: <1f1ab2d4-73ad-4562-b3c5-0b423b56aed2@suse.com>
Hi,
On Mon Jan 27, 2025 at 11:05 AM GMT, Jan Beulich wrote:
> On 10.01.2025 14:28, Alejandro Vallejo wrote:
> > No functional change.
> >
> > Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> > ---
> > v2->v3:
> > * const-ified v in fpu_xrstor()
> > * Removed v in fpu_fxrstor()
>
> On this basis the parameter could also be removed from fpu_fxsave(), by
> passing in fip_width instead.
>
> Jan
Could be, but there's not a whole lot of gain to be had? The access must be
done either way before or after the fpu_fxsave() call, and a parameter must be
passed (be it fip_width or v). Passing the vCPU encapsulates the access of
fip_width where its actually used, which seems more desirable, I'd say.
Cheers,
Alejandro
next prev parent reply other threads:[~2025-01-27 15:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 13:28 [PATCH v3 00/12] x86: Address Space Isolation FPU preparations Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 01/12] x86/xstate: Create map/unmap primitives for xsave areas Alejandro Vallejo
2025-01-27 10:44 ` Jan Beulich
2025-01-27 15:33 ` Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 02/12] x86/hvm: Map/unmap xsave area in hvm_save_cpu_ctxt() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 03/12] x86/fpu: Map/umap xsave area in vcpu_{reset,setup}_fpu() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 04/12] x86/xstate: Map/unmap xsave area in xstate_set_init() and handle_setbv() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 05/12] x86/hvm: Map/unmap xsave area in hvmemul_{get,put}_fpu() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 06/12] x86/domctl: Map/unmap xsave area in arch_get_info_guest() Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 07/12] x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states() Alejandro Vallejo
2025-01-27 10:46 ` Jan Beulich
2025-01-10 13:28 ` [PATCH v3 08/12] x86/emulator: Refactor FXSAVE_AREA to use wrappers Alejandro Vallejo
2025-01-27 10:52 ` Jan Beulich
2025-01-27 15:42 ` Alejandro Vallejo
2025-01-27 16:59 ` Jan Beulich
2025-03-05 15:29 ` Jan Beulich
2025-03-05 16:16 ` Alejandro Vallejo
2025-03-05 16:17 ` Jan Beulich
2025-01-10 13:28 ` [PATCH v3 09/12] x86/mpx: Map/unmap xsave area in in read_bndcfgu() Alejandro Vallejo
2025-01-27 10:57 ` Jan Beulich
2025-01-27 14:14 ` Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 10/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xsave() Alejandro Vallejo
2025-01-27 11:01 ` Jan Beulich
2025-01-27 15:43 ` Alejandro Vallejo
2025-01-10 13:28 ` [PATCH v3 11/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor() Alejandro Vallejo
2025-01-27 11:05 ` Jan Beulich
2025-01-27 15:48 ` Alejandro Vallejo [this message]
2025-01-27 17:01 ` Jan Beulich
2025-01-10 13:28 ` [PATCH v3 12/12] x86/xstate: Make xstate_all() and vcpu_xsave_mask() take explicit xstate Alejandro Vallejo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7CZ23KACJ16.A4EFWQ1X682K@cloud.com \
--to=alejandro.vallejo@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.