From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Aditya Kumar Singh" <aditya.kumar.singh@oss.qualcomm.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Jeff Johnson" <jjohnson@kernel.org>
Cc: <linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"Vasanthakumar Thiagarajan"
<vasanthakumar.thiagarajan@oss.qualcomm.com>
Subject: Re: [PATCH v2 0/8] wifi: ath12k: handle change_vif_links() callback
Date: Wed, 05 Feb 2025 11:09:55 +0100 [thread overview]
Message-ID: <D7KFI4INC6NC.3JY96TZGRJCX7@gmail.com> (raw)
In-Reply-To: <20250204-unlink_link_arvif_from_chanctx-v2-0-764fb5973c1a@oss.qualcomm.com>
On Tue Feb 4, 2025 at 6:05 PM CET, Aditya Kumar Singh wrote:
> Currently, links in an interface are allocated during channel assignment
> via assign_vif_chanctx(). Conversely, links are deleted during channel
> unassignment via unassign_vif_chanctx(). However, deleting links during
> channel unassignment does not comply with mac80211 link handling.
> Therefore, this process should be managed within change_vif_links().
>
> This series aims to add support to handle links in change_vif_links()
> callback.
>
> Patches 1-2 are making debug infra to work without device info.
>
> Patches 3-8 are the ones changing the code to handle as mentioned above.
>
> NOTE:
> * A new ath12k-check warning comes which probably needs to be added to
> ignore list
>
> drivers/net/wireless/ath/ath12k/debug.c:69: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
>
> This is because, since device info is not known can not use netdev_ or dev_
> dbg family. pr_debug() is an option but that will require DYNAMIC_DEBUG
> and then ath12k needs to be probed with dyndbg=+p which we don't want in
> ath. Hence, only option left is to use printk() directly.
>
The issue seems to be resolved. Thanks a lot !
Tested-by: Nicolas Escande <nico.escande@gmail.com>
Tested-on: WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1.97421.5
next prev parent reply other threads:[~2025-02-05 10:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 17:05 [PATCH v2 0/8] wifi: ath12k: handle change_vif_links() callback Aditya Kumar Singh
2025-02-04 17:05 ` [PATCH v2 1/8] wifi: ath12k: eliminate redundant debug mask check in ath12k_dbg() Aditya Kumar Singh
2025-02-04 17:05 ` [PATCH v2 2/8] wifi: ath12k: introduce ath12k_generic_dbg() Aditya Kumar Singh
2025-02-04 17:05 ` [PATCH v2 3/8] wifi: ath12k: remove redundant vif settings during link interface creation Aditya Kumar Singh
2025-02-04 17:05 ` [PATCH v2 4/8] wifi: ath12k: remove redundant logic for initializing arvif Aditya Kumar Singh
2025-02-04 17:05 ` [PATCH v2 5/8] wifi: ath12k: use arvif instead of link_conf in ath12k_mac_set_key() Aditya Kumar Singh
2025-02-04 17:05 ` [PATCH v2 6/8] wifi: ath12k: relocate a few functions in mac.c Aditya Kumar Singh
2025-02-05 14:09 ` Vasanthakumar Thiagarajan
2025-02-04 17:05 ` [PATCH v2 7/8] wifi: ath12k: allocate new links in change_vif_links() Aditya Kumar Singh
2025-02-04 17:05 ` [PATCH v2 8/8] wifi: ath12k: handle link removal " Aditya Kumar Singh
2025-02-05 14:10 ` Vasanthakumar Thiagarajan
2025-02-05 10:09 ` Nicolas Escande [this message]
2025-02-07 17:16 ` [PATCH v2 0/8] wifi: ath12k: handle change_vif_links() callback Jeff Johnson
2025-02-11 15:44 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7KFI4INC6NC.3JY96TZGRJCX7@gmail.com \
--to=nico.escande@gmail.com \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.