Re: [Buildroot] [PATCH v4 1/2] package/rpi-utils: new package

["Gaël PORTAY" <gael.portay+rtone@gmail.com>]

Hello Romain,

On Wed Feb 5, 2025 at 9:44 AM CET, Romain Naour wrote:
> Hello Gaël, All,
>
> Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
>> The package rpi-userland has been marked as ancient and deprecated[1].
>> 
>> The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
>> the repository rpi-utils since then.
>> 
>> This adds the new package rpi-utils at latest commit as there is no
>> tagged commit.
>
> BR2_PACKAGE_RPI_USERLAND is used in several packages. Since rpi-utils should
> replace rpi-userland maybe it's time to also update theses packages?
>

Indeed, I should consider this; and I haven't yes look into them (i.e.
why the packages need rpi-userland).

> Did you consider not only deprecating rpi-userland but a complete replacement?
>

I have to check if I can replace it entirely.

The deprecated package still contain sources from various libraries,
including the GL backend used by raspberrypi3_qt5we_defconfig.

Normally, it should be replaced by mesa3d and its vc4 driver (that
requires NEON support in buildroot).

But the Raspberry Pi 1/Zero/Zero W to not have NEON support and thus,
rpi-userland is still required if one want to compile Qt5WebEngine for
Raspberry Pi 1/Zero/Zero W.

I guess the vc4 driver does not require support for NEON (v3d does);
IIRC, I can compile vc4 driver if I revert[1] (i.e. no build issue).

I will test to run qt5 opengl samples using mesa3d. And if I am able to
run them correctly, I will consider the full replacement (in the package
requiring it).

The work is still in progress on that part.

[1]: https://gitlab.com/buildroot.org/buildroot/-/commit/a5cdb54ed78b136c83dd44aebfa27f715cda5ea3

>> 
>> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
>> 
>> Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
>> Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
>> ---
>
> What happened since v3?
>

Changes since v3:
 - Update my e-mail
 - Rebase on master
 - Add Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

I have added these lines to the coverletter[2].

[2]: https://lore.kernel.org/buildroot/20250204173456.201056-1-gael.portay+rtone@gmail.com/

>> diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
>> new file mode 100644
>> index 0000000000..a2729167aa
>> --- /dev/null
>> +++ b/package/rpi-utils/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_RPI_UTILS
>> +	bool "rpi-utils"
>
> Since it's only usefull for rpi targets, you should keep the architecture
> dependencies (at least):
>
> 	depends on BR2_arm || BR2_aarch64
>
> Otherwise, it looks ok.
>

Make sense, I will added in v5.

> Best regards,
> Romain
>

Best Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot