Re: [PATCH v4] spl: remove usage of CMD_BOOT[IZ] from image parsing

[Anshul Dalal <anshuld@ti.com>]

On Thu Mar 13, 2025 at 8:21 PM IST, Tom Rini wrote:
> On Thu, Mar 13, 2025 at 08:58:42AM +0530, Anshul Dalal wrote:
>
> > Using CMD_* configs from spl doesn't make logical sense. Therefore this
> > patch replaces the checks for CMD_BOOT[IZ] with newly added configs
> > SPL_HAS_BOOT[IZ].
> > 
> > An imply clause has been added for CMD_BOOTZ to avoid breaking configs
> > that rely on CMD_BOOTZ in falcon boot. There is no such need for
> > CMD_BOOTI since it's already enabled by default for the platforms that
> > support the image format.
> > 
> > More info:
> > https://lore.kernel.org/u-boot/20250310135544.GV2640854@bill-the-cat/
> [snip]
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index a04fcaa0e08..9f2ba4d02f8 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -352,6 +352,7 @@ config BOOTM_ELF
> >  
> >  config CMD_BOOTZ
> >  	bool "bootz"
> > +	imply SPL_HAS_BOOTZ
> >  	help
> >  	  Boot the Linux zImage
> >  
> > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > index 21a5cefee7a..49eb513f923 100644
> > --- a/common/spl/Kconfig
> > +++ b/common/spl/Kconfig
> > @@ -1153,6 +1153,19 @@ config SPL_OS_BOOT
> >  	  Enable booting directly to an OS from SPL.
> >  	  for more info read doc/README.falcon
> >  
> > +config SPL_HAS_BOOTZ
> > +	bool "Allow booting a zImage style Linux kernel from SPL"
> > +	depends on SPL_OS_BOOT
> > +	help
> > +	  Boot a linux zimage from memory in falcon boot.
>
> I was going to say this to v3 but you posted v4 already. The solution to
> existing platforms is "default y if ARM && !ARM64" here.

That makes sense, this keeps the defaults consistent between both
SPL_HAS_BOOTI and BOOTZ. I have addressed the changes in v5.

Thanks for the input :)

Anshul