From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85DBB257AF2; Tue, 25 Mar 2025 17:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742923551; cv=none; b=q7U2IeiopDa6/dC6ooXOLw3irpoBupcn2hfeBlzQK4GL75OJMtSw+UNZ6JTX95VU2seqtvUj2/9284UXX5clNy6aZ/fWC2QZinPwSldFalDpKbTS9887qSKB98MM32rqKJy4cMMwsyxwDJWOaQUudYVNVFijZzV6HgDIfR4uouE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742923551; c=relaxed/simple; bh=S6T4TmlUdE7gvOPo3bQyO4uG51sRLu56OEoAsFNC4ek=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=rIzGdSk6a2wN13ym1YSnz593dNTtZEQ6K7dOKZ7v8znytSx6c78Do2k5Mr6rFWBPjHg73BrJYdl0FuSUv5MV9UNyJM6Vv8pueXEOfS5bfRRNjXqmKOK9OzrLoV7yigXMz2NRlTlx2XKuyXQdiqIWACIOvNAlP9BDAWahDGLYGKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=djRgAH9Y; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="djRgAH9Y" Received: by mail.gandi.net (Postfix) with ESMTPSA id 49E3A4433E; Tue, 25 Mar 2025 17:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1742923540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LPvEeQoVwOan9vRz2MGLJjUipurACCpBk5gQyvnta10=; b=djRgAH9YaswUdPWsaCe87EAlbswo5U9GhK3K6k5EYX2bvj6cj9H9AR++Q4xTrMjSQ5oaeG rcgZDAWu9heu7gNHnzttKf1INMvKr+9LZuo1gvCZAUY1oDoIRAVMCJ/WLARxMlHSLL4LcR uR4n0biXynNB5c/tk1wx15MFRJG8J1WrjS72JV1JIVc9wCjBi/7ysxM2w4T8zo1cH8CWaf qJDgx/MHlD8/MDD2UNoAyImdQnzenXWLo9pfgfF1S/ruhg5GNfwtM4XkqyykzaobOQR38a fZSaHTaOlra0UWasXGnvQYGeOOxYV9B89I4/ap9vV1559suWOMT3MzmRzHpevQ== Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 25 Mar 2025 18:25:35 +0100 Message-Id: Cc: , , , , , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Claudiu Beznea" , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Nicolas Ferre" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Samuel Holland" , "Richard Cochran" , "Russell King" , "Thomas Bogendoerfer" , "Vladimir Kondratiev" , "Gregory CLEMENT" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH net-next 10/13] net: macb: Add "mobileye,eyeq5-gem" compatible X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250321-macb-v1-0-537b7e37971d@bootlin.com> <20250321-macb-v1-10-537b7e37971d@bootlin.com> In-Reply-To: X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduieefvdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegggfgtfffkvefvhffuofhfjgesthhqredtredtjeenucfhrhhomhepvfhhrohoucfnvggsrhhunhcuoehthhgvohdrlhgvsghruhhnsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeeigfelffeuffetteetuddufffghefhudeuteeigeekteevgeeileejgfdvffelheenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepjeejrddufeehrdekuddrieehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepjeejrddufeehrdekuddrieehpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehthhgvohdrlhgvsghruhhnsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedvjedprhgtphhtthhopegtlhgruhguihhurdgsvgiinhgvrgesthhugihonhdruggvvhdprhgtphhtthhopegrnhgurhgvfidonhgvthguvghvsehluhhnnhdrtghhpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrg hdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtoheprhhosghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehkrhiikhdoughtsehkvghrnhgvlhdrohhrgh X-GND-Sasl: theo.lebrun@bootlin.com On Mon Mar 24, 2025 at 9:18 AM CET, Claudiu Beznea wrote: > On 21.03.2025 21:09, Th=C3=A9o Lebrun wrote: >> Add support for the two GEM instances inside Mobileye EyeQ5 SoCs, using >> compatible "mobileye,eyeq5-gem". With it, add a custom init sequence >> that accesses two system-controller registers. >>=20 >> Noteworthy: NET_IP_ALIGN=3D2 on MIPS but the hardware does not align and >> low bits aren't configurable, so we cannot respect the requested IP >> header alignment. >>=20 >> Signed-off-by: Th=C3=A9o Lebrun >> --- >> drivers/net/ethernet/cadence/macb_main.c | 95 +++++++++++++++++++++++++= +++++++ >> 1 file changed, 95 insertions(+) >>=20 >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethe= rnet/cadence/macb_main.c >> index 79161d559166478f85a6f8294d488ed961d9be7f..9f2a5bf9a5ebca5941229bd9= 6091a0fb96f0607d 100644 >> --- a/drivers/net/ethernet/cadence/macb_main.c >> +++ b/drivers/net/ethernet/cadence/macb_main.c [...] >> +static int eyeq5_init(struct platform_device *pdev) >> +{ >> + struct device *dev =3D &pdev->dev; >> + struct net_device *netdev =3D platform_get_drvdata(pdev); >> + struct macb *bp =3D netdev_priv(netdev); >> + struct device_node *np =3D dev->of_node; >> + unsigned int gp, sgmii; >> + struct regmap *regmap; >> + unsigned int args[2]; >> + unsigned int reg; >> + int ret; >> + >> + regmap =3D syscon_regmap_lookup_by_phandle_args(np, "mobileye,olb", 2,= args); >> + if (IS_ERR(regmap)) >> + return PTR_ERR(regmap); >> + >> + gp =3D args[0]; >> + sgmii =3D args[1]; >> + >> + /* Forced reset */ >> + regmap_write(regmap, gp, 0); >> + regmap_write(regmap, sgmii, 0); >> + usleep_range(5, 20); >> + >> + if (bp->phy_interface =3D=3D PHY_INTERFACE_MODE_SGMII) { >> + regmap_write(regmap, gp, EYEQ5_OLB_GP_SGMII_MODE); >> + >> + reg =3D EYEQ5_OLB_SGMII_PWR_EN | EYEQ5_OLB_SGMII_RST_DIS | >> + EYEQ5_OLB_SGMII_PLL_EN; >> + regmap_write(regmap, sgmii, reg); >> + >> + ret =3D regmap_read_poll_timeout(regmap, sgmii, reg, >> + reg & EYEQ5_OLB_SGMII_PLL_ACK, >> + 1, 100); >> + if (ret) >> + return dev_err_probe(dev, ret, "PLL timeout"); >> + >> + regmap_read(regmap, sgmii, ®); >> + reg |=3D EYEQ5_OLB_SGMII_PWR_STATE | EYEQ5_OLB_SGMII_SIG_DET_SW; >> + regmap_write(regmap, sgmii, reg); > > You can use regmap_update_bits() here. > >> + } >> + >> + regmap_read(regmap, gp, ®); >> + reg &=3D ~EYEQ5_OLB_GP_RGMII_DRV; >> + if (phy_interface_mode_is_rgmii(bp->phy_interface)) >> + reg |=3D FIELD_PREP(EYEQ5_OLB_GP_RGMII_DRV, 0x9); >> + reg |=3D EYEQ5_OLB_GP_TX_SWRST_DIS | EYEQ5_OLB_GP_TX_M_CLKE; >> + reg |=3D EYEQ5_OLB_GP_SYS_SWRST_DIS | EYEQ5_OLB_GP_SYS_M_CLKE; >> + regmap_write(regmap, gp, reg); > > To me it looks like this code could be abstracted as a phy driver. E.g., > check the init_reset_optional() and its usage on "cdns,zynqmp-gem" (phy > driver here: drivers/phy/xilinx/phy-zynqmp.c). I thought about that question. Options to implement that sequence are: - (1) Implement a separate PHY driver, what you are proposing. I just made a prototype branch to see what it'd look like. Nothing too surprising; mostly the above sequence is copy-pasted inside phy_init|power_on(). I see two issues: - First, a practical one. This adds a lot of boilerplate for no obvious benefit compared to a raw registers read/write sequence inside macb_config->init(). The main reason for that boilerplate is to allow reuse of a PHY across MACs; here we already know that cannot be useful because the EyeQ5 has two GEMs and nothing else. Those registers are EyeQ5-specific. - Second, a semantic one. The registers we are touching are *not* the PHY's registers. They are configuring the PHY's integration: its input PLL, resets, etc. - (2) Second, taking into account that what we are configuring isn't the PHY itself but its resources, we could try modeling each individual register+field as a reset / clock / pin control (there is some drive strength in here, *I think*). Issue: this would get messy, fast. - A single register would expose many resources. - The sequence in macb_config->init() would need to be the exact same order. IE we can't abstract much. Something like this pseudocode (which is a bad idea, we'd all agree here): reset_deassert(bp->eq5_sgmii_reset); reset_deassert(bp->eq5_sgmii_reset_pwr); reset_deassert(bp->eq5_phy_reset_tx); reset_deassert(bp->eq5_phy_reset_sys); if (bp->phy_interface =3D=3D PHY_INTERFACE_MODE_SGMII) { pinctrl_select_state(bp->eq5_phy_input_pinctrl, bp->eq5_pins_sgmii= ); reset_deassert(bp->eq5_sgmii_reset); clk_prepare_enable(bp->eq5_sgmii_phy_input_pll); reset_deassert(bp->eq5_sgmii_reset_pwr); } else { pinctrl_select_state(bp->eq5_pinctrl, bp->eq5_pins_rgmii); } reset_deassert(bp->eq5_phy_reset_tx); reset_deassert(bp->eq5_phy_reset_sys); clk_prepare_enable(bp->eq5_phy_mclk_tx); clk_prepare_enable(bp->eq5_phy_mclk_sys); - (3) Keep the sequence in macb_config->init(). Plain and simple. - Issue: it is somewhat unrelated platform-specific code that's present inside macb_main.c. The two serious options are (1) and (3). (1) is what you proposed and (3) is what's in the series. >> static const struct of_device_id macb_dt_ids[] =3D { >> { .compatible =3D "cdns,at91sam9260-macb", .data =3D &at91sam9260_conf= ig }, >> { .compatible =3D "cdns,macb" }, >> @@ -5152,6 +5246,7 @@ static const struct of_device_id macb_dt_ids[] =3D= { >> { .compatible =3D "cdns,zynqmp-gem", .data =3D &zynqmp_config}, /* dep= recated */ >> { .compatible =3D "cdns,zynq-gem", .data =3D &zynq_config }, /* deprec= ated */ >> { .compatible =3D "sifive,fu540-c000-gem", .data =3D &fu540_c000_confi= g }, >> + { .compatible =3D "mobileye,eyeq5-gem", .data =3D &eyeq5_config }, > > Maybe move it after microchip to have it a bit sorted. Argh those semi sorted lists. I saw "cdns" then "atmel" then "cdns" so I ignored sorting. Thanks for the review! -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6548C36008 for ; Tue, 25 Mar 2025 17:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Subject:From:To: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kmZdPkyqcadBn+m8QPDyuNKhCc32oY7yh38lBZq4fYU=; b=Ga7OmD7vrjC8aZ /lHlYbjHd6ZUZ9XwMH+xqAaHgXesUoAv9K1wMSkYMwEfGW4okNkcnyvKODttQVLBEo9BTa5jCwWhh E1ogci9kuzjEcFpwbh0qNjGOH6mkOQKO/qrt2xnZZsbbF5ZbK5A+YCTqiE948Sn1hUgfqWlq4nREc uJwJ7+asZmnOJYSVn5b6SGmcPEFEF/WV2xP5eSm3bYq5xRvklPDdXxxNpbhPU/B8opFZ/rsFYjQln 7rFv0/CvZH/PQYdACGPmb9RqsuxGLVbv38fBrmgZ+m3A9zjjSchBw1yS+3GCFhqKM/9S44/eX0ooM nDlv+e3HNuvuACMu4+cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tx828-00000006cCd-1qIx; Tue, 25 Mar 2025 17:25:48 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tx825-00000006cBD-0QCf for linux-riscv@lists.infradead.org; Tue, 25 Mar 2025 17:25:47 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 49E3A4433E; Tue, 25 Mar 2025 17:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1742923540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LPvEeQoVwOan9vRz2MGLJjUipurACCpBk5gQyvnta10=; b=djRgAH9YaswUdPWsaCe87EAlbswo5U9GhK3K6k5EYX2bvj6cj9H9AR++Q4xTrMjSQ5oaeG rcgZDAWu9heu7gNHnzttKf1INMvKr+9LZuo1gvCZAUY1oDoIRAVMCJ/WLARxMlHSLL4LcR uR4n0biXynNB5c/tk1wx15MFRJG8J1WrjS72JV1JIVc9wCjBi/7ysxM2w4T8zo1cH8CWaf qJDgx/MHlD8/MDD2UNoAyImdQnzenXWLo9pfgfF1S/ruhg5GNfwtM4XkqyykzaobOQR38a fZSaHTaOlra0UWasXGnvQYGeOOxYV9B89I4/ap9vV1559suWOMT3MzmRzHpevQ== Mime-Version: 1.0 Date: Tue, 25 Mar 2025 18:25:35 +0100 Message-Id: Cc: , , , , , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Claudiu Beznea" , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Nicolas Ferre" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Samuel Holland" , "Richard Cochran" , "Russell King" , "Thomas Bogendoerfer" , "Vladimir Kondratiev" , "Gregory CLEMENT" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH net-next 10/13] net: macb: Add "mobileye,eyeq5-gem" compatible X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250321-macb-v1-0-537b7e37971d@bootlin.com> <20250321-macb-v1-10-537b7e37971d@bootlin.com> In-Reply-To: X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduieefvdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegggfgtfffkvefvhffuofhfjgesthhqredtredtjeenucfhrhhomhepvfhhrohoucfnvggsrhhunhcuoehthhgvohdrlhgvsghruhhnsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeeigfelffeuffetteetuddufffghefhudeuteeigeekteevgeeileejgfdvffelheenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepjeejrddufeehrdekuddrieehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepjeejrddufeehrdekuddrieehpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehthhgvohdrlhgvsghruhhnsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedvjedprhgtphhtthhopegtlhgruhguihhurdgsvgiinhgvrgesthhugihonhdruggvvhdprhgtphhtthhopegrnhgurhgvfidonhgvthguvghvsehluhhnnhdrtghhpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrg hdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtoheprhhosghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehkrhiikhdoughtsehkvghrnhgvlhdrohhrgh X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250325_102545_746712_18A4F9EB X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uIE1hciAyNCwgMjAyNSBhdCA5OjE4IEFNIENFVCwgQ2xhdWRpdSBCZXpuZWEgd3JvdGU6 Cj4gT24gMjEuMDMuMjAyNSAyMTowOSwgVGjDqW8gTGVicnVuIHdyb3RlOgo+PiBBZGQgc3VwcG9y dCBmb3IgdGhlIHR3byBHRU0gaW5zdGFuY2VzIGluc2lkZSBNb2JpbGV5ZSBFeWVRNSBTb0NzLCB1 c2luZwo+PiBjb21wYXRpYmxlICJtb2JpbGV5ZSxleWVxNS1nZW0iLiBXaXRoIGl0LCBhZGQgYSBj dXN0b20gaW5pdCBzZXF1ZW5jZQo+PiB0aGF0IGFjY2Vzc2VzIHR3byBzeXN0ZW0tY29udHJvbGxl ciByZWdpc3RlcnMuCj4+IAo+PiBOb3Rld29ydGh5OiBORVRfSVBfQUxJR049MiBvbiBNSVBTIGJ1 dCB0aGUgaGFyZHdhcmUgZG9lcyBub3QgYWxpZ24gYW5kCj4+IGxvdyBiaXRzIGFyZW4ndCBjb25m aWd1cmFibGUsIHNvIHdlIGNhbm5vdCByZXNwZWN0IHRoZSByZXF1ZXN0ZWQgSVAKPj4gaGVhZGVy IGFsaWdubWVudC4KPj4gCj4+IFNpZ25lZC1vZmYtYnk6IFRow6lvIExlYnJ1biA8dGhlby5sZWJy dW5AYm9vdGxpbi5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvY2FkZW5jZS9t YWNiX21haW4uYyB8IDk1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+ICAxIGZp bGUgY2hhbmdlZCwgOTUgaW5zZXJ0aW9ucygrKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv bmV0L2V0aGVybmV0L2NhZGVuY2UvbWFjYl9tYWluLmMgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9j YWRlbmNlL21hY2JfbWFpbi5jCj4+IGluZGV4IDc5MTYxZDU1OTE2NjQ3OGY4NWE2ZjgyOTRkNDg4 ZWQ5NjFkOWJlN2YuLjlmMmE1YmY5YTVlYmNhNTk0MTIyOWJkOTYwOTFhMGZiOTZmMDYwN2QgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L2NhZGVuY2UvbWFjYl9tYWluLmMKPj4g KysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvY2FkZW5jZS9tYWNiX21haW4uYwoKWy4uLl0KCj4+ ICtzdGF0aWMgaW50IGV5ZXE1X2luaXQoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4g K3sKPj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Owo+PiArCXN0cnVjdCBuZXRf ZGV2aWNlICpuZXRkZXYgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPj4gKwlzdHJ1Y3Qg bWFjYiAqYnAgPSBuZXRkZXZfcHJpdihuZXRkZXYpOwo+PiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAq bnAgPSBkZXYtPm9mX25vZGU7Cj4+ICsJdW5zaWduZWQgaW50IGdwLCBzZ21paTsKPj4gKwlzdHJ1 Y3QgcmVnbWFwICpyZWdtYXA7Cj4+ICsJdW5zaWduZWQgaW50IGFyZ3NbMl07Cj4+ICsJdW5zaWdu ZWQgaW50IHJlZzsKPj4gKwlpbnQgcmV0Owo+PiArCj4+ICsJcmVnbWFwID0gc3lzY29uX3JlZ21h cF9sb29rdXBfYnlfcGhhbmRsZV9hcmdzKG5wLCAibW9iaWxleWUsb2xiIiwgMiwgYXJncyk7Cj4+ ICsJaWYgKElTX0VSUihyZWdtYXApKQo+PiArCQlyZXR1cm4gUFRSX0VSUihyZWdtYXApOwo+PiAr Cj4+ICsJZ3AgPSBhcmdzWzBdOwo+PiArCXNnbWlpID0gYXJnc1sxXTsKPj4gKwo+PiArCS8qIEZv cmNlZCByZXNldCAqLwo+PiArCXJlZ21hcF93cml0ZShyZWdtYXAsIGdwLCAwKTsKPj4gKwlyZWdt YXBfd3JpdGUocmVnbWFwLCBzZ21paSwgMCk7Cj4+ICsJdXNsZWVwX3JhbmdlKDUsIDIwKTsKPj4g Kwo+PiArCWlmIChicC0+cGh5X2ludGVyZmFjZSA9PSBQSFlfSU5URVJGQUNFX01PREVfU0dNSUkp IHsKPj4gKwkJcmVnbWFwX3dyaXRlKHJlZ21hcCwgZ3AsIEVZRVE1X09MQl9HUF9TR01JSV9NT0RF KTsKPj4gKwo+PiArCQlyZWcgPSBFWUVRNV9PTEJfU0dNSUlfUFdSX0VOIHwgRVlFUTVfT0xCX1NH TUlJX1JTVF9ESVMgfAo+PiArCQkgICAgICBFWUVRNV9PTEJfU0dNSUlfUExMX0VOOwo+PiArCQly ZWdtYXBfd3JpdGUocmVnbWFwLCBzZ21paSwgcmVnKTsKPj4gKwo+PiArCQlyZXQgPSByZWdtYXBf cmVhZF9wb2xsX3RpbWVvdXQocmVnbWFwLCBzZ21paSwgcmVnLAo+PiArCQkJCQkgICAgICAgcmVn ICYgRVlFUTVfT0xCX1NHTUlJX1BMTF9BQ0ssCj4+ICsJCQkJCSAgICAgICAxLCAxMDApOwo+PiAr CQlpZiAocmV0KQo+PiArCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCByZXQsICJQTEwgdGlt ZW91dCIpOwo+PiArCj4+ICsJCXJlZ21hcF9yZWFkKHJlZ21hcCwgc2dtaWksICZyZWcpOwo+PiAr CQlyZWcgfD0gRVlFUTVfT0xCX1NHTUlJX1BXUl9TVEFURSB8IEVZRVE1X09MQl9TR01JSV9TSUdf REVUX1NXOwo+PiArCQlyZWdtYXBfd3JpdGUocmVnbWFwLCBzZ21paSwgcmVnKTsKPgo+IFlvdSBj YW4gdXNlIHJlZ21hcF91cGRhdGVfYml0cygpIGhlcmUuCj4KPj4gKwl9Cj4+ICsKPj4gKwlyZWdt YXBfcmVhZChyZWdtYXAsIGdwLCAmcmVnKTsKPj4gKwlyZWcgJj0gfkVZRVE1X09MQl9HUF9SR01J SV9EUlY7Cj4+ICsJaWYgKHBoeV9pbnRlcmZhY2VfbW9kZV9pc19yZ21paShicC0+cGh5X2ludGVy ZmFjZSkpCj4+ICsJCXJlZyB8PSBGSUVMRF9QUkVQKEVZRVE1X09MQl9HUF9SR01JSV9EUlYsIDB4 OSk7Cj4+ICsJcmVnIHw9IEVZRVE1X09MQl9HUF9UWF9TV1JTVF9ESVMgfCBFWUVRNV9PTEJfR1Bf VFhfTV9DTEtFOwo+PiArCXJlZyB8PSBFWUVRNV9PTEJfR1BfU1lTX1NXUlNUX0RJUyB8IEVZRVE1 X09MQl9HUF9TWVNfTV9DTEtFOwo+PiArCXJlZ21hcF93cml0ZShyZWdtYXAsIGdwLCByZWcpOwo+ Cj4gVG8gbWUgaXQgbG9va3MgbGlrZSB0aGlzIGNvZGUgY291bGQgYmUgYWJzdHJhY3RlZCBhcyBh IHBoeSBkcml2ZXIuIEUuZy4sCj4gY2hlY2sgdGhlIGluaXRfcmVzZXRfb3B0aW9uYWwoKSBhbmQg aXRzIHVzYWdlIG9uICJjZG5zLHp5bnFtcC1nZW0iIChwaHkKPiBkcml2ZXIgaGVyZTogZHJpdmVy cy9waHkveGlsaW54L3BoeS16eW5xbXAuYykuCgpJIHRob3VnaHQgYWJvdXQgdGhhdCBxdWVzdGlv bi4gT3B0aW9ucyB0byBpbXBsZW1lbnQgdGhhdCBzZXF1ZW5jZSBhcmU6CgogLSAoMSkgSW1wbGVt ZW50IGEgc2VwYXJhdGUgUEhZIGRyaXZlciwgd2hhdCB5b3UgYXJlIHByb3Bvc2luZy4gSSBqdXN0 CiAgIG1hZGUgYSBwcm90b3R5cGUgYnJhbmNoIHRvIHNlZSB3aGF0IGl0J2QgbG9vayBsaWtlLiBO b3RoaW5nIHRvbwogICBzdXJwcmlzaW5nOyBtb3N0bHkgdGhlIGFib3ZlIHNlcXVlbmNlIGlzIGNv cHktcGFzdGVkIGluc2lkZQogICBwaHlfaW5pdHxwb3dlcl9vbigpLiBJIHNlZSB0d28gaXNzdWVz OgoKICAgIC0gRmlyc3QsIGEgcHJhY3RpY2FsIG9uZS4gVGhpcyBhZGRzIGEgbG90IG9mIGJvaWxl cnBsYXRlIGZvciBubwogICAgICBvYnZpb3VzIGJlbmVmaXQgY29tcGFyZWQgdG8gYSByYXcgcmVn aXN0ZXJzIHJlYWQvd3JpdGUgc2VxdWVuY2UKICAgICAgaW5zaWRlIG1hY2JfY29uZmlnLT5pbml0 KCkuCgogICAgICBUaGUgbWFpbiByZWFzb24gZm9yIHRoYXQgYm9pbGVycGxhdGUgaXMgdG8gYWxs b3cgcmV1c2Ugb2YgYSBQSFkKICAgICAgYWNyb3NzIE1BQ3M7IGhlcmUgd2UgYWxyZWFkeSBrbm93 IHRoYXQgY2Fubm90IGJlIHVzZWZ1bCBiZWNhdXNlCiAgICAgIHRoZSBFeWVRNSBoYXMgdHdvIEdF TXMgYW5kIG5vdGhpbmcgZWxzZS4gVGhvc2UgcmVnaXN0ZXJzIGFyZQogICAgICBFeWVRNS1zcGVj aWZpYy4KCiAgICAtIFNlY29uZCwgYSBzZW1hbnRpYyBvbmUuIFRoZSByZWdpc3RlcnMgd2UgYXJl IHRvdWNoaW5nIGFyZSAqbm90KgogICAgICB0aGUgUEhZJ3MgcmVnaXN0ZXJzLiBUaGV5IGFyZSBj b25maWd1cmluZyB0aGUgUEhZJ3MgaW50ZWdyYXRpb246CiAgICAgIGl0cyBpbnB1dCBQTEwsIHJl c2V0cywgZXRjLgoKIC0gKDIpIFNlY29uZCwgdGFraW5nIGludG8gYWNjb3VudCB0aGF0IHdoYXQg d2UgYXJlIGNvbmZpZ3VyaW5nIGlzbid0CiAgIHRoZSBQSFkgaXRzZWxmIGJ1dCBpdHMgcmVzb3Vy Y2VzLCB3ZSBjb3VsZCB0cnkgbW9kZWxpbmcgZWFjaAogICBpbmRpdmlkdWFsIHJlZ2lzdGVyK2Zp ZWxkIGFzIGEgcmVzZXQgLyBjbG9jayAvIHBpbiBjb250cm9sICh0aGVyZSBpcwogICBzb21lIGRy aXZlIHN0cmVuZ3RoIGluIGhlcmUsICpJIHRoaW5rKikuIElzc3VlOiB0aGlzIHdvdWxkIGdldAog ICBtZXNzeSwgZmFzdC4KICAgIC0gQSBzaW5nbGUgcmVnaXN0ZXIgd291bGQgZXhwb3NlIG1hbnkg cmVzb3VyY2VzLgogICAgLSBUaGUgc2VxdWVuY2UgaW4gbWFjYl9jb25maWctPmluaXQoKSB3b3Vs ZCBuZWVkIHRvIGJlIHRoZSBleGFjdAogICAgICBzYW1lIG9yZGVyLiBJRSB3ZSBjYW4ndCBhYnN0 cmFjdCBtdWNoLgoKICAgU29tZXRoaW5nIGxpa2UgdGhpcyBwc2V1ZG9jb2RlICh3aGljaCBpcyBh IGJhZCBpZGVhLCB3ZSdkIGFsbCBhZ3JlZQogICBoZXJlKToKCiAgICAgIHJlc2V0X2RlYXNzZXJ0 KGJwLT5lcTVfc2dtaWlfcmVzZXQpOwogICAgICByZXNldF9kZWFzc2VydChicC0+ZXE1X3NnbWlp X3Jlc2V0X3B3cik7CiAgICAgIHJlc2V0X2RlYXNzZXJ0KGJwLT5lcTVfcGh5X3Jlc2V0X3R4KTsK ICAgICAgcmVzZXRfZGVhc3NlcnQoYnAtPmVxNV9waHlfcmVzZXRfc3lzKTsKCiAgICAgIGlmIChi cC0+cGh5X2ludGVyZmFjZSA9PSBQSFlfSU5URVJGQUNFX01PREVfU0dNSUkpIHsKICAgICAgICAg cGluY3RybF9zZWxlY3Rfc3RhdGUoYnAtPmVxNV9waHlfaW5wdXRfcGluY3RybCwgYnAtPmVxNV9w aW5zX3NnbWlpKTsKCiAgICAgICAgIHJlc2V0X2RlYXNzZXJ0KGJwLT5lcTVfc2dtaWlfcmVzZXQp OwogICAgICAgICBjbGtfcHJlcGFyZV9lbmFibGUoYnAtPmVxNV9zZ21paV9waHlfaW5wdXRfcGxs KTsKCiAgICAgICAgIHJlc2V0X2RlYXNzZXJ0KGJwLT5lcTVfc2dtaWlfcmVzZXRfcHdyKTsKICAg ICAgfSBlbHNlIHsKICAgICAgICAgcGluY3RybF9zZWxlY3Rfc3RhdGUoYnAtPmVxNV9waW5jdHJs LCBicC0+ZXE1X3BpbnNfcmdtaWkpOwogICAgICB9CgogICAgICByZXNldF9kZWFzc2VydChicC0+ ZXE1X3BoeV9yZXNldF90eCk7CiAgICAgIHJlc2V0X2RlYXNzZXJ0KGJwLT5lcTVfcGh5X3Jlc2V0 X3N5cyk7CiAgICAgIGNsa19wcmVwYXJlX2VuYWJsZShicC0+ZXE1X3BoeV9tY2xrX3R4KTsKICAg ICAgY2xrX3ByZXBhcmVfZW5hYmxlKGJwLT5lcTVfcGh5X21jbGtfc3lzKTsKCiAtICgzKSBLZWVw IHRoZSBzZXF1ZW5jZSBpbiBtYWNiX2NvbmZpZy0+aW5pdCgpLiBQbGFpbiBhbmQgc2ltcGxlLgog ICAgLSBJc3N1ZTogaXQgaXMgc29tZXdoYXQgdW5yZWxhdGVkIHBsYXRmb3JtLXNwZWNpZmljIGNv ZGUgdGhhdCdzCiAgICAgIHByZXNlbnQgaW5zaWRlIG1hY2JfbWFpbi5jLgoKVGhlIHR3byBzZXJp b3VzIG9wdGlvbnMgYXJlICgxKSBhbmQgKDMpLgooMSkgaXMgd2hhdCB5b3UgcHJvcG9zZWQgYW5k ICgzKSBpcyB3aGF0J3MgaW4gdGhlIHNlcmllcy4KCj4+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9m X2RldmljZV9pZCBtYWNiX2R0X2lkc1tdID0gewo+PiAgCXsgLmNvbXBhdGlibGUgPSAiY2Rucyxh dDkxc2FtOTI2MC1tYWNiIiwgLmRhdGEgPSAmYXQ5MXNhbTkyNjBfY29uZmlnIH0sCj4+ICAJeyAu Y29tcGF0aWJsZSA9ICJjZG5zLG1hY2IiIH0sCj4+IEBAIC01MTUyLDYgKzUyNDYsNyBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtYWNiX2R0X2lkc1tdID0gewo+PiAgCXsgLmNv bXBhdGlibGUgPSAiY2Rucyx6eW5xbXAtZ2VtIiwgLmRhdGEgPSAmenlucW1wX2NvbmZpZ30sIC8q IGRlcHJlY2F0ZWQgKi8KPj4gIAl7IC5jb21wYXRpYmxlID0gImNkbnMsenlucS1nZW0iLCAuZGF0 YSA9ICZ6eW5xX2NvbmZpZyB9LCAvKiBkZXByZWNhdGVkICovCj4+ICAJeyAuY29tcGF0aWJsZSA9 ICJzaWZpdmUsZnU1NDAtYzAwMC1nZW0iLCAuZGF0YSA9ICZmdTU0MF9jMDAwX2NvbmZpZyB9LAo+ PiArCXsgLmNvbXBhdGlibGUgPSAibW9iaWxleWUsZXllcTUtZ2VtIiwgLmRhdGEgPSAmZXllcTVf Y29uZmlnIH0sCj4KPiBNYXliZSBtb3ZlIGl0IGFmdGVyIG1pY3JvY2hpcCB0byBoYXZlIGl0IGEg Yml0IHNvcnRlZC4KCkFyZ2ggdGhvc2Ugc2VtaSBzb3J0ZWQgbGlzdHMuIEkgc2F3ICJjZG5zIiB0 aGVuICJhdG1lbCIgdGhlbiAiY2RucyIgc28gSQppZ25vcmVkIHNvcnRpbmcuCgpUaGFua3MgZm9y IHRoZSByZXZpZXchCgotLQpUaMOpbyBMZWJydW4sIEJvb3RsaW4KRW1iZWRkZWQgTGludXggYW5k IEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0 CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=