Re: [bitbake-devel] [PATCH v3 1/7] fetch2/wget: consider downloadfilename when checking for upstream

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Wed Mar 26, 2025 at 1:25 PM CET, Ross Burton via lists.openembedded.org wrote:
> latest_versionstring() currently looks at just the end of the URI when
> guessing what the filename to look for is, but this doesn't work if the
> URL filename is not simple.
>
> For example, miniupnpd has a SRC_URI of:
>
>   http://miniupnp.tuxfamily.org/files/download.php?file=${BP}.tar.gz;downloadfilename=${BP}.tar.gz
>
> The filename component of this is "download.php", which causes the
> heuristics in latest_versionstring() to exit early.
>
> Instead, if the downloadfilename is set then use that, as it's often the
> actual filename that we're after.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---

Hi Ross,

I've been trying to apply this series on my branch, but I get some error
on the autobuilder:

FAIL: test_wget_latest_versionstring (bb.tests.fetch.FetchLatestVersionTest.test_wget_latest_versionstring) (pn='miniupnpd')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-fedora/build/bitbake/lib/bb/tests/fetch.py", line 1578, in test_wget_latest_versionstring
    self.assertTrue(verstring, msg="Could not find upstream version for %s" % data.pn)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '' is not true : Could not find upstream version for miniupnpd

https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/1193


-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com