All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Martin Jansa" <martin.jansa@gmail.com>
Cc: <bitbake-devel@lists.openembedded.org>,
	<docs@lists.yoctoproject.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [docs] [PATCH 1/2] runqueue: decrease the verbosity of pressure messages
Date: Tue, 15 Apr 2025 13:52:05 +0200	[thread overview]
Message-ID: <D976VXV65RT6.1ZHT2MCAP4QL1@bootlin.com> (raw)
In-Reply-To: <CA+chaQeXK2pbaNWaYvDVzMhu=eZLpFLB9zeeaGDA7oLDJnaG3A@mail.gmail.com>

Hi Martin,

On Fri Apr 11, 2025 at 9:09 PM CEST, Martin Jansa wrote:
> On Fri, Apr 11, 2025 at 4:46 PM Antonin Godard via
> lists.yoctoproject.org
> <antonin.godard=bootlin.com@lists.yoctoproject.org> wrote:
>>
>> By default all the pressure changes are printed on the console and
>> generate a lot of spam to users using the BB_PRESSURE_* variables.
>> Decrease the default verbosity to bb.debug (level 1, so can be seen with
>> -D).
>
> Isn't "a lot of these messages" a proof that the BB_PRESSURE_*
> variables aren't set correctly?
>
> I find them quite useful and using -D by default in my builds would
> bring even "more spam". But in worse case I'll just revert this for my
> builds.

I see how these messages can be useful.

To my understanding, having a low value for BB_PRESSURE_* variables will
generate a lot of these messages. To me, it does not necessarily mean that the
value isn't properly set, it just means that you want to limit the pressure a
lot.

Maybe the default behavior of printing everything is good for adjustments, I
just think it'd be convenient for user to have a way to disable those once they
are happy with their pressure configuration.

I thought first of a BB_PRESSURE_VERBOSE or BB_PRESSURE_QUIET variable. It
would just allow enabling/disabling these messages. But on second thought, I'm
not sure an extra variable is necessary when we could just move these messages
to debug messages. Other variables that limit the load do not generate such
"spam" (take BB_LOADFACTOR_MAX for example).

What do you think?

Antonin

--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2025-04-15 11:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 14:46 [PATCH 0/2] Improvements around BB_PRESSURE_* variables Antonin Godard
2025-04-11 14:46 ` [PATCH 1/2] runqueue: decrease the verbosity of pressure messages Antonin Godard
2025-04-11 19:09   ` [docs] " Martin Jansa
2025-04-15 11:52     ` Antonin Godard [this message]
2025-04-15 12:07       ` Martin Jansa
2025-04-11 14:46 ` [PATCH 2/2] doc: bitbake-user-manual-ref-variables: improve BB_PRESSURE_* doc Antonin Godard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D976VXV65RT6.1ZHT2MCAP4QL1@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=docs@lists.yoctoproject.org \
    --cc=martin.jansa@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.