From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E68631714B3 for ; Mon, 28 Apr 2025 06:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745820734; cv=none; b=jsJAKW+XBSeTQ/SvBYC+SDZAgZRcQ52SMkBVkfDzsrCxoTqxeiSYWPWGheYaNnI6cYqM/lPAZTJay9pldmqS/19TKXoESVuuq3PbUJgV7wn/nQCR5nYLenAaWI1+FV0DkfBqXQzbtGSCNWTnrHhdFKtleuq9MZwvtidNl6aWaZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745820734; c=relaxed/simple; bh=8CwCv76zw/+0m+lyzeDMN6Vk6xWMZOBGPjQq2NP1sOI=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=jTXtgLCHwdUX7M0cD6LPPragmnzyNdqbNHsrgWh5rp0DBpHFAUVgXRwEMrLeluJDTvCw7OwalHJzkaigtrMGGLNG+g+IRBijLnj/oUQSKYWU9NXrwfMsZHsfYNyszY7wPT1jQYYp7U4ZmEjDYGwqtFhFPweRREPZq83OLARYIQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=sQzl7JoK; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="sQzl7JoK" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745820727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wpJe+SyHKAKA7Xe8eF1jSDRDURs46JvcnTlKUNm/bwk=; b=sQzl7JoK0cLUXuqugQG62IMSNmMORsx20yCnA5ShacBmNbg8kcTOwI0sn6YoaMoEDqnONY w8b/KEhhP5FhknFVetEmTUajcQR+VLUK7gtMpK98N+bQsTKPpNHbv94ZXKeJi3NuM37VMz jYeGjUJ0gnxSu2AcvWMsxaSGyZDcHC8= Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\)) Subject: Re: [PATCH v3] MIPS: Fix MAX_REG_OFFSET X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum In-Reply-To: Date: Mon, 28 Apr 2025 08:11:54 +0200 Cc: Oleg Nesterov , Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20250427113423.67040-2-thorsten.blum@linux.dev> To: "Maciej W. Rozycki" X-Migadu-Flow: FLOW_OUT On 28. Apr 2025, at 03:35, Maciej W. Rozycki wrote: > On Sun, 27 Apr 2025, Thorsten Blum wrote: >> Fix MAX_REG_OFFSET to point to the last register in 'pt_regs' and not to >> the marker itself, which could allow regs_get_register() to return an >> invalid offset. >> >> Fixes: 40e084a506eb ("MIPS: Add uprobes support.") >> Signed-off-by: Thorsten Blum >> --- >> Compile-tested only. >> >> Changes in v2: >> - Fix MAX_REG_OFFSET as suggested by Maciej (thanks!) > > You're welcome; please add a `Suggested-by' tag accordingly. Suggested-by: Maciej W. Rozycki