All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <philip.lorenz@bmw.de>, <bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH 3/8] fetch2: Check for git-lfs existence before using it
Date: Thu, 24 Apr 2025 09:10:15 +0200	[thread overview]
Message-ID: <D9EOJ22QSMAC.3LNDP3MSMSGCG@bootlin.com> (raw)
In-Reply-To: <20250423151901.1300944-4-philip.lorenz@bmw.de>

On Wed Apr 23, 2025 at 5:18 PM CEST, Philip Lorenz via lists.openembedded.org wrote:
> So far, existence of `git-lfs` was only checked during unpacking. As the
> binary is also used in earlier steps also check for its existence there.
>
> Additionally, factor out the LFS existence check into a dedicated
> function and call it wherever git-lfs is used for the first time.
>
> Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
> ---

Hi Philip,

Thanks for your patch.

I was not able to test this series on the autobuilder so far, as I
believe git-lfs is not installed in there. Now maybe this has to be a
new requirement on the host and maybe this is fine. Just two points:
- Is that really a new requirement and is it needed?
- We probably need to update a bit of documentation about that.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2025-04-24  7:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 15:18 [PATCH 0/8] Fix gitsm LFS support Philip Lorenz
2025-04-23 15:18 ` [PATCH 1/8] fetch2: Clean up no longer used name parameter Philip Lorenz
2025-04-23 15:18 ` [PATCH 2/8] tests/fetch: Move commonly used imports to top Philip Lorenz
2025-04-23 15:18 ` [PATCH 3/8] fetch2: Check for git-lfs existence before using it Philip Lorenz
2025-04-24  7:10   ` Mathieu Dubois-Briand [this message]
2025-04-24  7:48     ` [bitbake-devel] " Philip Lorenz
2025-04-24 11:21       ` Alexander Kanavin
2025-04-24 14:29         ` Richard Purdie
2025-04-23 15:18 ` [PATCH 4/8] fetch2: Simplify git LFS detection Philip Lorenz
2025-04-23 15:18 ` [PATCH 5/8] fetch2: Use git-lfs fetch to download objects Philip Lorenz
2025-04-23 15:18 ` [PATCH 6/8] fetch2: Fix incorrect lfs parametrization for submodules Philip Lorenz
2025-04-23 15:19 ` [PATCH 7/8] fetch2: Fix LFS object checkout in submodules Philip Lorenz
2025-04-23 15:19 ` [PATCH 8/8] tests/fetch: Test gitsm with LFS Philip Lorenz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9EOJ22QSMAC.3LNDP3MSMSGCG@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=philip.lorenz@bmw.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.