All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <gavrosc@yahoo.com>, <docs@lists.yoctoproject.org>
Subject: Re: [docs] [PATCH] ref-manual/variables.rst: document the INITRAMFS_MAXSIZE variable
Date: Thu, 24 Apr 2025 10:04:20 +0200	[thread overview]
Message-ID: <D9EPOGRMN3YJ.2KZRPDOFHCRRS@bootlin.com> (raw)
In-Reply-To: <28281.1745436284133202831@lists.yoctoproject.org>

Hi Christos,

On Wed Apr 23, 2025 at 9:24 PM CEST, Christos Gavros via lists.yoctoproject.org wrote:
> hi Antonin and Quentin
>
> i had a further look on that.
>
> When initramfs is included in build (INITRAMFS_IMAGE = "core-image-minimal-initramfs" in local.conf)
> then the 'IMAGE_ROOTFS' is pointing to build/tmp/work/qemux86_64-poky-linux/core-image-minimal-initramfs/1.0/rootfs.
> This directory is approximately 115000kb.
> If INITRAMFS_MAXSIZE = "1100000" then the error is generated.
> If INITRAMFS_MAXSIZE = "1600000" then the build is ok.
> So i think that the INITRAMFS_MAXSIZE refers to the size of the directory and not the final image type.

How were your IMAGE_OVERHEAD_FACTOR and IMAGE_ROOTFS_ALIGNMENT variables set
during your test? I'm pretty sure they affect the final condition when I looked
at the code a couple of weeks ago.

Could you include how these two variables affect the final condition with
regards to INITRAMFS_MAXSIZE?

> The condition " if image_fstypes == initramfs_fstypes != ''  and initramfs_maxsize: ", exists
> because in the recipe "core-image-minimal-initramfs" there is the assignment IMAGE_FSTYPES = "${INITRAMFS_FSTYPES}".
> So the INITRAMFS_MAXSIZE is evaluated only when one of the initramfs recipes is included.
>
> Shall i submit a v2 ?

I think Quentin had valid comments on your patch:
week -> weak
the size is in kilobytes, not bytes

I'll let you take a second look at their comments.

Thanks,
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2025-04-24  8:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250328205213.93625-1-gavrosc.ref@yahoo.com>
2025-03-28 20:52 ` [PATCH] ref-manual/variables.rst: document the INITRAMFS_MAXSIZE variable Christos Gavros
2025-03-31  8:51   ` [docs] " Quentin Schulz
2025-03-31  9:24     ` Christos Gavros
2025-04-01 19:43       ` Christos Gavros
2025-04-02  9:15         ` [docs] " Quentin Schulz
2025-04-02 12:24   ` Antonin Godard
2025-04-02 14:19     ` Christos Gavros
2025-04-23 19:24       ` Christos Gavros
2025-04-24  8:04         ` Antonin Godard [this message]
2025-04-24 15:18           ` Christos Gavros
2025-04-25  7:34             ` [docs] " Antonin Godard
2025-04-25  8:35               ` Christos Gavros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9EPOGRMN3YJ.2KZRPDOFHCRRS@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=gavrosc@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.