All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Vallejo <agarciav@amd.com>
To: Roger Pau Monne <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Frediano Ziglio <frediano.ziglio@cloud.com>,
	Xen-devel <xen-devel-bounces@lists.xenproject.org>
Subject: Re: [PATCH v2] x86/intel: workaround several MONITOR/MWAIT errata
Date: Fri, 25 Apr 2025 13:36:42 +0100	[thread overview]
Message-ID: <D9FQ3JVWGOSR.1F6NIIEDCUP16@amd.com> (raw)
In-Reply-To: <20250423113215.80755-1-roger.pau@citrix.com>

On Wed Apr 23, 2025 at 12:32 PM BST, Roger Pau Monne wrote:
> There are several errata on Intel regarding the usage of the MONITOR/MWAIT
> instructions, all having in common that stores to the monitored region
> might not wake up the CPU.
>
> Fix them by forcing the sending of an IPI for the affected models.
>
> The Ice Lake issue has been reproduced internally on XenServer hardware,
> and the fix does seem to prevent it.  The symptom was APs getting stuck in
> the idle loop immediately after bring up, which in turn prevented the BSP
> from making progress.

Ugh... so this is what it was... Awesome having this madness fixed.

Do you happen to know if Linux has a similar fix in place?

> This would happen before the watchdog was initialized, and hence the
> whole system would get stuck.

That's nasty. It was the misassumption that the watchdog was already
running that had me going in circles thinking it was a lockup rather
than a livelock. Oh, well.

I believe the kudos for finally being able to reproduce this goes to
Frediano?

Cheers,
Alejandro


  parent reply	other threads:[~2025-04-25 12:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 11:32 [PATCH v2] x86/intel: workaround several MONITOR/MWAIT errata Roger Pau Monne
2025-04-23 13:05 ` Jan Beulich
2025-04-23 13:13 ` Andrew Cooper
2025-04-23 14:08   ` Roger Pau Monné
2025-04-25 12:36 ` Alejandro Vallejo [this message]
2025-04-25 12:44   ` Andrew Cooper
2025-04-25 12:55   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9FQ3JVWGOSR.1F6NIIEDCUP16@amd.com \
    --to=agarciav@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=frediano.ziglio@cloud.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel-bounces@lists.xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.