All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@ventanamicro.com>
To: "Anup Patel" <anup@brainfault.org>
Cc: <kvm-riscv@lists.infradead.org>, <kvm@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	"Atish Patra" <atishp@atishpatra.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Mayuresh Chitale" <mchitale@ventanamicro.com>
Subject: Re: [PATCH 2/5] KVM: RISC-V: refactor sbi reset request
Date: Wed, 07 May 2025 19:28:35 +0200	[thread overview]
Message-ID: <D9Q3TKPXTPMO.39LSPFEO587XO@ventanamicro.com> (raw)
In-Reply-To: <CAAhSdy0v7Cw+aGF8DDWh1gjTBXA23=H01KRK8R2LTQHLRHo5Kw@mail.gmail.com>

2025-05-07T17:31:33+05:30, Anup Patel <anup@brainfault.org>:
> On Thu, Apr 3, 2025 at 5:02 PM Radim Krčmář <rkrcmar@ventanamicro.com> wrote:
>> diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h
>> @@ -55,6 +55,8 @@ void kvm_riscv_vcpu_sbi_forward(struct kvm_vcpu *vcpu, struct kvm_run *run);
>>  void kvm_riscv_vcpu_sbi_system_reset(struct kvm_vcpu *vcpu,
>>                                      struct kvm_run *run,
>>                                      u32 type, u64 flags);
>> +void kvm_riscv_vcpu_sbi_request_reset(struct kvm_vcpu *vcpu,
>> +                                      unsigned long pc, unsigned long a1);
>
> Use tabs for alignment instead of spaces.

Oops, I totally forgot that linux uses tabs even for alignment.

> Otherwise, it looks good to me.
> I have taken care of the above comment at the time
> of merging this patch.

Thanks, I'll post v2 without the three patches.

-- 
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv

WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@ventanamicro.com>
To: "Anup Patel" <anup@brainfault.org>
Cc: <kvm-riscv@lists.infradead.org>, <kvm@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	"Atish Patra" <atishp@atishpatra.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Mayuresh Chitale" <mchitale@ventanamicro.com>
Subject: Re: [PATCH 2/5] KVM: RISC-V: refactor sbi reset request
Date: Wed, 07 May 2025 19:28:35 +0200	[thread overview]
Message-ID: <D9Q3TKPXTPMO.39LSPFEO587XO@ventanamicro.com> (raw)
In-Reply-To: <CAAhSdy0v7Cw+aGF8DDWh1gjTBXA23=H01KRK8R2LTQHLRHo5Kw@mail.gmail.com>

2025-05-07T17:31:33+05:30, Anup Patel <anup@brainfault.org>:
> On Thu, Apr 3, 2025 at 5:02 PM Radim Krčmář <rkrcmar@ventanamicro.com> wrote:
>> diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h
>> @@ -55,6 +55,8 @@ void kvm_riscv_vcpu_sbi_forward(struct kvm_vcpu *vcpu, struct kvm_run *run);
>>  void kvm_riscv_vcpu_sbi_system_reset(struct kvm_vcpu *vcpu,
>>                                      struct kvm_run *run,
>>                                      u32 type, u64 flags);
>> +void kvm_riscv_vcpu_sbi_request_reset(struct kvm_vcpu *vcpu,
>> +                                      unsigned long pc, unsigned long a1);
>
> Use tabs for alignment instead of spaces.

Oops, I totally forgot that linux uses tabs even for alignment.

> Otherwise, it looks good to me.
> I have taken care of the above comment at the time
> of merging this patch.

Thanks, I'll post v2 without the three patches.

WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@ventanamicro.com>
To: "Anup Patel" <anup@brainfault.org>
Cc: <kvm-riscv@lists.infradead.org>, <kvm@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	"Atish Patra" <atishp@atishpatra.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Mayuresh Chitale" <mchitale@ventanamicro.com>
Subject: Re: [PATCH 2/5] KVM: RISC-V: refactor sbi reset request
Date: Wed, 07 May 2025 19:28:35 +0200	[thread overview]
Message-ID: <D9Q3TKPXTPMO.39LSPFEO587XO@ventanamicro.com> (raw)
In-Reply-To: <CAAhSdy0v7Cw+aGF8DDWh1gjTBXA23=H01KRK8R2LTQHLRHo5Kw@mail.gmail.com>

2025-05-07T17:31:33+05:30, Anup Patel <anup@brainfault.org>:
> On Thu, Apr 3, 2025 at 5:02 PM Radim Krčmář <rkrcmar@ventanamicro.com> wrote:
>> diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h
>> @@ -55,6 +55,8 @@ void kvm_riscv_vcpu_sbi_forward(struct kvm_vcpu *vcpu, struct kvm_run *run);
>>  void kvm_riscv_vcpu_sbi_system_reset(struct kvm_vcpu *vcpu,
>>                                      struct kvm_run *run,
>>                                      u32 type, u64 flags);
>> +void kvm_riscv_vcpu_sbi_request_reset(struct kvm_vcpu *vcpu,
>> +                                      unsigned long pc, unsigned long a1);
>
> Use tabs for alignment instead of spaces.

Oops, I totally forgot that linux uses tabs even for alignment.

> Otherwise, it looks good to me.
> I have taken care of the above comment at the time
> of merging this patch.

Thanks, I'll post v2 without the three patches.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-05-07 17:53 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 11:25 [PATCH 0/5] KVM: RISC-V: VCPU reset fixes Radim Krčmář
2025-04-03 11:25 ` Radim Krčmář
2025-04-03 11:25 ` Radim Krčmář
2025-04-03 11:25 ` [PATCH 1/5] KVM: RISC-V: refactor vector state reset Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-25 12:56   ` Andrew Jones
2025-04-25 12:56     ` Andrew Jones
2025-04-25 12:56     ` Andrew Jones
2025-05-07 11:43   ` Anup Patel
2025-05-07 11:43     ` Anup Patel
2025-05-07 11:43     ` Anup Patel
2025-04-03 11:25 ` [PATCH 2/5] KVM: RISC-V: refactor sbi reset request Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-25 12:58   ` Andrew Jones
2025-04-25 12:58     ` Andrew Jones
2025-04-25 12:58     ` Andrew Jones
2025-05-07 12:01   ` Anup Patel
2025-05-07 12:01     ` Anup Patel
2025-05-07 12:01     ` Anup Patel
2025-05-07 17:28     ` Radim Krčmář [this message]
2025-05-07 17:28       ` Radim Krčmář
2025-05-07 17:28       ` Radim Krčmář
2025-05-08  5:02       ` Anup Patel
2025-05-08  5:02         ` Anup Patel
2025-05-08  5:02         ` Anup Patel
2025-04-03 11:25 ` [PATCH 3/5] KVM: RISC-V: remove unnecessary SBI reset state Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-25 13:05   ` Andrew Jones
2025-04-25 13:05     ` Andrew Jones
2025-04-25 13:05     ` Andrew Jones
2025-04-28 12:16   ` Anup Patel
2025-04-28 12:16     ` Anup Patel
2025-04-28 12:16     ` Anup Patel
2025-04-28 18:00     ` Radim Krčmář
2025-04-28 18:00       ` Radim Krčmář
2025-04-28 18:00       ` Radim Krčmář
2025-04-29  5:50       ` Anup Patel
2025-04-29  5:50         ` Anup Patel
2025-04-29  5:50         ` Anup Patel
2025-05-08  6:18   ` Anup Patel
2025-05-08  6:18     ` Anup Patel
2025-05-08  6:18     ` Anup Patel
2025-05-08 10:02     ` Radim Krčmář
2025-05-08 10:02       ` Radim Krčmář
2025-05-08 10:02       ` Radim Krčmář
2025-05-08 13:11       ` Anup Patel
2025-05-08 13:11         ` Anup Patel
2025-05-08 13:11         ` Anup Patel
2025-04-03 11:25 ` [PATCH 4/5] KVM: RISC-V: reset VCPU state when becoming runnable Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-25 13:26   ` Andrew Jones
2025-04-25 13:26     ` Andrew Jones
2025-04-25 13:26     ` Andrew Jones
2025-04-25 16:04     ` Radim Krčmář
2025-04-25 16:04       ` Radim Krčmář
2025-04-25 16:04       ` Radim Krčmář
2025-04-28 12:22   ` Anup Patel
2025-04-28 12:22     ` Anup Patel
2025-04-28 12:22     ` Anup Patel
2025-04-28 17:45     ` Radim Krčmář
2025-04-28 17:45       ` Radim Krčmář
2025-04-28 17:45       ` Radim Krčmář
2025-04-29  5:55       ` Anup Patel
2025-04-29  5:55         ` Anup Patel
2025-04-29  5:55         ` Anup Patel
2025-04-29 10:25         ` Radim Krčmář
2025-04-29 10:25           ` Radim Krčmář
2025-04-29 10:25           ` Radim Krčmář
2025-04-29 15:01           ` Anup Patel
2025-04-29 15:01             ` Anup Patel
2025-04-29 15:01             ` Anup Patel
2025-04-29 16:21             ` Radim Krčmář
2025-04-29 16:21               ` Radim Krčmář
2025-04-29 16:21               ` Radim Krčmář
2025-04-30  4:22               ` Anup Patel
2025-04-30  4:22                 ` Anup Patel
2025-04-30  4:22                 ` Anup Patel
2025-04-30  5:26                 ` Anup Patel
2025-04-30  5:26                   ` Anup Patel
2025-04-30  5:26                   ` Anup Patel
2025-04-30  8:29                   ` Radim Krčmář
2025-04-30  8:29                     ` Radim Krčmář
2025-04-30  8:29                     ` Radim Krčmář
2025-04-30 10:17                     ` Anup Patel
2025-04-30 10:17                       ` Anup Patel
2025-04-30 10:17                       ` Anup Patel
2025-04-30 11:45                       ` Radim Krčmář
2025-04-30 11:45                         ` Radim Krčmář
2025-04-30 11:45                         ` Radim Krčmář
2025-04-30 13:02                         ` Anup Patel
2025-04-30 13:02                           ` Anup Patel
2025-04-30 13:02                           ` Anup Patel
2025-04-30 14:38                           ` Radim Krčmář
2025-04-30 14:38                             ` Radim Krčmář
2025-04-30 14:38                             ` Radim Krčmář
2025-04-03 11:25 ` [PATCH 5/5] KVM: RISC-V: reset smstateen CSRs Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-03 11:25   ` Radim Krčmář
2025-04-25 12:38   ` Anup Patel
2025-04-25 12:38     ` Anup Patel
2025-04-25 12:38     ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9Q3TKPXTPMO.39LSPFEO587XO@ventanamicro.com \
    --to=rkrcmar@ventanamicro.com \
    --cc=ajones@ventanamicro.com \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@atishpatra.org \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mchitale@ventanamicro.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.