All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexis Lothoré" <alexis.lothore@bootlin.com>
To: "Tony Ambardar" <tony.ambardar@gmail.com>
Cc: "Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Alan Maguire" <alan.maguire@oracle.com>, <bpf@vger.kernel.org>,
	<dwarves@vger.kernel.org>
Subject: Re: Pahole/BTF issue with __int128
Date: Thu, 08 May 2025 00:20:30 +0200	[thread overview]
Message-ID: <D9QA12O1IQU9.3AVBN6BI611LL@bootlin.com> (raw)
In-Reply-To: <aBvE++cyskZTfAo5@kodidev-ubuntu>

Hi Tony,
thanks a lot for the prompt answer !

On Wed May 7, 2025 at 10:39 PM CEST, Tony Ambardar wrote:
> On Wed, May 07, 2025 at 10:02:51PM +0200, Alexis Lothoré wrote:
>> Hello,

[...]

> Hi Alexis,
>
>> Am I missing some constraint or limitation that would prevent the case 2
>> function from being described with BTF info ? If not, any advice about how
>> to debug this further ?
>> 
>
> I suspect this might be related to an issue I ran into where pahole may
> mis-encode types larger than register-size [1]. Out of curiosity, could
> you try rebuilding and using a pahole with my latest patch [2]?
>
> 1: https://lore.kernel.org/dwarves/20250410083359.198724-1-tony.ambardar@gmail.com/
> 2: https://lore.kernel.org/dwarves/20250502070318.1561924-1-tony.ambardar@gmail.com/

I gave a try to your patch on top of pahole 1.30, and indeed it seems that
my issue is fixed with your solution. I now have some BTF info for my
bpf_testmod_test_struct_arg_11 func:

  [...]
  [370] FUNC_PROTO '(anon)' ret_type_id=6 vlen=6
          'a' type_id=10
          'b' type_id=10
          'c' type_id=10
          'd' type_id=10
          'e' type_id=5
          'f' type_id=10
  [371] FUNC 'bpf_testmod_test_struct_arg_11' type_id=370 linkage=static
  [...]

I also did some quick tests around Alan's request in your series, I'll
report to your series' thread.

Thanks for the help !

Alexis


>
> Cheers,
> Tony
>
>> Thanks,
>> 
>> Alexis
>> 
>> -- 
>> Alexis Lothoré, Bootlin
>> Embedded Linux and Kernel engineering
>> https://bootlin.com




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2025-05-07 22:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 20:02 Pahole/BTF issue with __int128 Alexis Lothoré
2025-05-07 20:39 ` Tony Ambardar
2025-05-07 22:20   ` Alexis Lothoré [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9QA12O1IQU9.3AVBN6BI611LL@bootlin.com \
    --to=alexis.lothore@bootlin.com \
    --cc=acme@kernel.org \
    --cc=alan.maguire@oracle.com \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=tony.ambardar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.