From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 528FBC3ABBC for ; Mon, 12 May 2025 10:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:Subject: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F6Lz+xoTQFUikaEiJZopRyW0YsPg+Gkh6jBB+YHBcTo=; b=Gl62/u6R6oiRRu boG9WSYR6J2LILRGoVNQH1CVRYxoIArloUjyDBGkzdidjA3tMnnMrUGh4bzF7n3+q7RKhAgtYTiYd O6bmsrpG+94DvJ9/IHSWugzddU/v/ob5ElEagGf5S84rrBzd6/vUpTrRLVEltoxqdJ7K4wPnIlntJ 6QojQlPZSwJVTI8AdqrTY76MUQhMz5sY4jiLyiN/K9bn9bMiKxu673syX/h7pXKm3dnBswBoqSaXy ZZuU/iC74BJrxm5XzM35gnriL/VORbhZObasxv2TO2xzp3fv+tTJS9SqWzFtM51teFvoVSsz4UpOQ 3tAupItexvRBL8pEZS/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEQS4-000000096dR-0AhR; Mon, 12 May 2025 10:32:04 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEQLr-000000095nN-1ZJY for kvm-riscv@lists.infradead.org; Mon, 12 May 2025 10:25:40 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43cf7c2c351so3943595e9.0 for ; Mon, 12 May 2025 03:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1747045537; x=1747650337; darn=lists.infradead.org; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fVYDNzGl1HhtRbOLlZqbNyW/2ZNd9jQ043iVsCWK1J0=; b=RtWXylDSbxdW/Driq+HkbLAO/Hk343L5l/42RTbjJXGKkim5X0vC3mBqDsT5VO+Kxr DAJpr2tuZ2JW6GA4VATRfEEmPrDzljd/mDlBzffrg1/UbF3uyR6jyWi8PCVL9uIrenQU gPDl8AAkFL+nI/HdipmX3yHo5BRFRLAgtpMgJLxuCA1e5lAOgl//lN6lm++0S6XNef7O glbYqf8Zjkdw1cPzCrqtd2LRfcFKPyNbjWXW6WxUSwdIIgGL1L2rO+hyWQj6YrfdKFvF fmgIqCUUz2kzNJo3tQW5EZq62GLJHfYTHpjEZBonHlnhqn9De9x/76sH3YSdevN+/O7+ sg4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747045537; x=1747650337; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fVYDNzGl1HhtRbOLlZqbNyW/2ZNd9jQ043iVsCWK1J0=; b=YfycowYMUhaum6e9n9gma/84IT0KwaKhXk0v27uWJBV51wPeK6IQQ3tlBm4atxS9Yh dkunxtnqDMH2beDFrh1+/pM/vd3PP2vyqFKDWHDeEQ2txK3V9zqoeovrYXIrx1NM5j8l VynoJ7/zvxEjngw2S6R0Jzuj278RS/jRch1eYsWEhSnwmLyW6TaTiRHxmWvExWWsdUSq /Aly49p7nTS/7Xx3MNHWEnSfLrMvTQqaG7DljQYAjlRSxJ6JVhBxx6n44Y9xKDrX3szq y34EmAv7iEWyiHAgkLrSNaP3ya0f0x+xMvJFHaFQxry/dTzH5Xnlcn2Abzn7lKwyChIU /JDQ== X-Forwarded-Encrypted: i=1; AJvYcCXpbxOQ2Et29GaYszu+yl7YjK74XKFGp22zv/+oMYI6FwoeWwiLxXcQuT4wkZkhV1AXenqcPEyCgR0=@lists.infradead.org X-Gm-Message-State: AOJu0YwCIiHApUqHp7A0GL1adlHeEXl7O5PG1PlUkirfteE7E1R4aZFY PQpov4EUdSOuI38rjIMRZHPaOYShS5awJ2Ujb4FFAXdX72HMEMY++9FvlGdxx4U= X-Gm-Gg: ASbGncufIf0brlKrXt5QWQeNeKbsbmmyPIsGcgOKTl+lTD++qiwtatyTzPqJ1NUulnZ COUKnaky4Y2cbUPAhoU03YgxYtyhiqKRRm/Lh39r2+PZ4ni5K22IuPo/Bs0DffVcfuzVmggKjo1 F/lftauKlrFTuwKvlptwBSBQymQBPkGYmDZ3L61nUxuQGU1xHWZX81S6wL090i6vg0X+ul3qY2A 6V2t4YyVos34hOo9iV67AEKIIPtihisbB4rQFjDKFjggUS55r44xfm/OjzSnrFVmuMcWyjhoGC5 ApHsrXxvJWeJ5+azpcEFcxLdOC7vbe3fc4a8I2ScKyc2uqtjugmwt2OWanY= X-Google-Smtp-Source: AGHT+IGcTuM+dMRNAzDc5kg0U48s/ErTHPCpW1AeG6d0g+VQ2rWI9+vdhUQrqpzvxyWDNYPzIqhOmg== X-Received: by 2002:a05:600c:4ec7:b0:439:9fde:da76 with SMTP id 5b1f17b1804b1-442d6c39b14mr38970815e9.0.1747045537283; Mon, 12 May 2025 03:25:37 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:6b5b:8def:fde9:86fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d76b7fd6sm74327145e9.0.2025.05.12.03.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 03:25:36 -0700 (PDT) Mime-Version: 1.0 Date: Mon, 12 May 2025 12:25:36 +0200 Message-Id: From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= Subject: Re: [PATCH 4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily Cc: , , , , "linux-riscv" To: "Atish Patra" , "Anup Patel" , "Atish Patra" , "Paul Walmsley" , "Palmer Dabbelt" , "Alexandre Ghiti" References: <20250505-kvm_lazy_enable_stateen-v1-0-3bfc4008373c@rivosinc.com> <20250505-kvm_lazy_enable_stateen-v1-4-3bfc4008373c@rivosinc.com> <1da6648a-251b-456b-9ddd-a7ffa95a5125@linux.dev> In-Reply-To: <1da6648a-251b-456b-9ddd-a7ffa95a5125@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250512_032539_420891_27EED65E X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org MjAyNS0wNS0wOVQxNTozODo1NS0wNzowMCwgQXRpc2ggUGF0cmEgPGF0aXNoLnBhdHJhQGxpbnV4 LmRldj46Cj4gT24gNS84LzI1IDY6MzIgQU0sIFJhZGltIEtyxI1tw6HFmSB3cm90ZToKPj4gMjAy NS0wNS0wNVQxNDozOToyOS0wNzowMCwgQXRpc2ggUGF0cmEgPGF0aXNocEByaXZvc2luYy5jb20+ Ogo+Pj4gU0VOVkNGRyBhbmQgU1NUQVRFRU4gQ1NScyBhcmUgY29udHJvbGxlZCBieSBIU0VOVkNG Ryg2MikgYW5kCj4+PiBTU1RBVEVFTjAoNjMpIGJpdHMgaW4gaHN0YXRlZW4uIEVuYWJsZSB0aGVt IGxhemlseSBhdCBydW50aW1lCj4+PiBpbnN0ZWFkIG9mIGJvb3RpbWUuCj4+Pgo+Pj4gU2lnbmVk LW9mZi1ieTogQXRpc2ggUGF0cmEgPGF0aXNocEByaXZvc2luYy5jb20+Cj4+PiAtLS0KPj4+IGRp ZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2t2bS92Y3B1X2luc24uYyBiL2FyY2gvcmlzY3Yva3ZtL3Zj cHVfaW5zbi5jCj4+PiBAQCAtMjU2LDkgKzI1NiwzNyBAQCBpbnQga3ZtX3Jpc2N2X3ZjcHVfaHN0 YXRlZW5fbGF6eV9lbmFibGUoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBpbnQgY3Ny Xwo+Pj4gICAJcmV0dXJuIEtWTV9JTlNOX0NPTlRJTlVFX1NBTUVfU0VQQzsKPj4+ICAgfQo+Pj4g ICAKPj4+ICtzdGF0aWMgaW50IGt2bV9yaXNjdl92Y3B1X2hzdGF0ZWVuX2VuYWJsZV9zZW52Y2Zn KHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKPj4+ICsJCQkJCQkgIHVuc2lnbmVkIGludCBjc3JfbnVt LAo+Pj4gKwkJCQkJCSAgdW5zaWduZWQgbG9uZyAqdmFsLAo+Pj4gKwkJCQkJCSAgdW5zaWduZWQg bG9uZyBuZXdfdmFsLAo+Pj4gKwkJCQkJCSAgdW5zaWduZWQgbG9uZyB3cl9tYXNrKQo+Pj4gK3sK Pj4+ICsJcmV0dXJuIGt2bV9yaXNjdl92Y3B1X2hzdGF0ZWVuX2xhenlfZW5hYmxlKHZjcHUsIGNz cl9udW0sIFNNU1RBVEVFTjBfSFNFTlZDRkcpOwo+Pj4gK30KPj4gQmFzaWNhbGx5IHRoZSBzYW1l IGNvbW1lbnRzIGFzIGZvciBbMS81XToKPj4KPj4gV2h5IGRvbid0IHdlIHdhbnQgdG8gc2V0IHRo ZSBFTlZDRkcgYml0ICg2MikgdW5jb25kaXRpb25hbGx5Pwo+Pgo+PiBJdCB3b3VsZCBzYXZlIHVz IHRoZSB0cmFwIG9uIGZpcnN0IGFjY2Vzcy4gIFdlIGRvbid0IGdldCBhbnl0aGluZyBmcm9tCj4+ IHRoZSB0cmFwLCBzbyBpdCBsb29rcyBsaWtlIGEgbmV0IG5lZ2F0aXZlIHRvIG1lLgo+Cj4gV2Ug d2FudCB0byBsYXp5IGVuYWJsZW1lbnQgaXMgdG8gbWFrZSBzdXJlIHRoYXQgaHlwZXJ2aXNvciBp cyBhd2FyZSBvZiAKPiB0aGUgd2hhdCBmZWF0dXJlcwo+IGd1ZXN0IGlzIHVzaW5nLiBXZSBkb24n dCB3YW50IHRvIG5lY2Vzc2FyaWx5IGVuYWJsZSB0aGUgYXJjaGl0ZWN0dXJlIAo+IHN0YXRlcyBm b3IgdGhlIGd1ZXN0IGlmIGd1ZXN0IGRvZXNuJ3QgbmVlZCBpdC4KPgo+IFdlIG5lZWQgbGF6eSBl bmFibGVtZW50IGZvciBDVFIgbGlrZSBmZWF0dXJlcyBhbnl3YXlzLiBUaGlzIHdpbGwgYWxpZ24g Cj4gYWxsIHRoZSB0aGUgZmVhdHVyZXMgY29udHJvbGxlZAo+IGJ5IHN0YXRlZW4gaW4gdGhlIHNh bWUgbWFubmVyLiBUaGUgY29zdCBpcyBqdXN0IGEgc2luZ2xlIHRyYXAgYXQgdGhlIAo+IGJvb3Qg dGltZS4KPgo+IElNTywgaXQncyBmYWlyIHRyYWRlIG9mZi4KClllYWgsIGFzIGxvbmcgYXMgd2Ug YXJlIGRvaW5nIHNvbWV0aGluZyB3aXRoIHRoZSBpbmZvcm1hdGlvbiBmcm9tIHRoZQp0cmFwLgoK LS0gCmt2bS1yaXNjdiBtYWlsaW5nIGxpc3QKa3ZtLXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rdm0tcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37792264F9A for ; Mon, 12 May 2025 10:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747045541; cv=none; b=LjInN4e8XM121DfXYZ24W3dF51GF1I6Ikb4V807JIZMlDfHUNgDDBBvAeXXNWeqc6R4JIXiFpIo/D5IbxA0aReJIt0NsM36AnXDU41IPP095nZV86eN4/74U0ecM1dvNRj1/uKwsLrTiIWAmR83EvgH9hI8w4ZKdJCeMKu0s7iQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747045541; c=relaxed/simple; bh=8Hfs24IMPIMD+rfu+wmgpuAN32C2jG/+yYit3T83DYk=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=GaHeZ8EnK7Z8s5y8a6vco+l/+xCzwsCVDgjuswV6ZlbOTPc77XQtZ5t4C5Ls3g4wk/AeeCP7dSoM4a71tsQLBQ0EDpL/1EbT5DyB8jVfCmtUUXHdnJ5Fd3Y9iStSyaWG3iq+Ydj4eLL9wStoK7iu1AtQIoBSURNeNYmzxYjnbM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=DmD+fuzo; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="DmD+fuzo" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43d4ff56136so5087775e9.3 for ; Mon, 12 May 2025 03:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1747045537; x=1747650337; darn=vger.kernel.org; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fVYDNzGl1HhtRbOLlZqbNyW/2ZNd9jQ043iVsCWK1J0=; b=DmD+fuzoYUA8DWqIkG4vt7cMfY7uOVpqN1FmAnvGz1RGHFoHRZ/sutTWGs2yzKd9On hF/a/ZZEGrKPQ5PmO51+bGDwlDVZNGcMJwI0QQCJU1cvDujkIGY9Zi2spcKGocvqf63O 4CJ4uCt4bM0dxLcQG2b6D7e2rfzqHt0PgO0T5hfeibkHivKrwy3DxgSJXAhFiZpr722I Z4TcW3qMMgsOZ9HPDbMWBKfSISVm1Fcn5YkjBlM0MA/3XN/Qd4KWcc4AojMFAcsNwMyY teKQhlqirUCn5DUXwiU4EIvJtK695e3GRiyo2FLaINFRy+g8YqVcb6xq8sOdfa95CRPn WcUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747045537; x=1747650337; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fVYDNzGl1HhtRbOLlZqbNyW/2ZNd9jQ043iVsCWK1J0=; b=oCTCnh2Tlkv905Pn5mntiNod5M0zO1bL5sU1VKUqVSqK3MO2aATJMW1yJ4ut56BaDo 3HY0A8s7uvBetvGGr4fAb13IuifVSUB8EzCxrRjY2axUMyKVAl4tUwPFvXgbMtoGsYK2 u6pIjweWPPzEw7vEKvX0+5Nd/zrcY/63gg8fCQrHqCurYM0IU0HiZumuehSJPqMmaCEn eoeSQkk9h9hmoMvMiGY1Uh11aWBmeiX2y0NHn0mFrn/iYH0ZgP9xxyu0ktaCl5BoWxLy 7/Ca1DOyiEfnUdM7ZgfvxxVe9fiktSRTW6VdwYP3kjwKgFg97eP86denq2mV13jgVY13 yArQ== X-Gm-Message-State: AOJu0YyldPr8WfDx4xDocs6+5NQ/fzU0yg3OS7Q6ya8kTE0DaFBnejOl zJJYk7awPA6HkWei9mn629ejDqw25bwuqXuj4c+EE2UJ3omLO/NO9zbksrC11+g= X-Gm-Gg: ASbGncu0DiRXchIGvqKYzinDjM7B9Ssww01BQ9zvT9kh/REmSg/CFUOvvz24DWrATrZ ZJXCl6yjjF78GE6kIQArQARQmo4pO8yb69KOj9HGTLsN33w7Ay2gESNWCPgIre2f7NO6h89b3Ae AKfzU3n8nJwzEdgAJ5UztL5S36yC/Pipr7aZTmNr/IlnRwL9eeEqD8Yh5t/cCeHIBX8M9G4MhHU SHVI1keOH5NxUMaYwlDC/7bS60w+m4VXGxB21xoAOEQsE4DyEbd9XWx2oTPDKKBJd7slwHOjWtQ k7Z+wntgPJiQLsJn8CWOdMD6Xecll7/BWFkK/3ivioAm/xgh1Zjt2Eguayk= X-Google-Smtp-Source: AGHT+IGcTuM+dMRNAzDc5kg0U48s/ErTHPCpW1AeG6d0g+VQ2rWI9+vdhUQrqpzvxyWDNYPzIqhOmg== X-Received: by 2002:a05:600c:4ec7:b0:439:9fde:da76 with SMTP id 5b1f17b1804b1-442d6c39b14mr38970815e9.0.1747045537283; Mon, 12 May 2025 03:25:37 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:6b5b:8def:fde9:86fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d76b7fd6sm74327145e9.0.2025.05.12.03.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 03:25:36 -0700 (PDT) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 12 May 2025 12:25:36 +0200 Message-Id: From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= Subject: Re: [PATCH 4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily Cc: , , , , "linux-riscv" To: "Atish Patra" , "Anup Patel" , "Atish Patra" , "Paul Walmsley" , "Palmer Dabbelt" , "Alexandre Ghiti" References: <20250505-kvm_lazy_enable_stateen-v1-0-3bfc4008373c@rivosinc.com> <20250505-kvm_lazy_enable_stateen-v1-4-3bfc4008373c@rivosinc.com> <1da6648a-251b-456b-9ddd-a7ffa95a5125@linux.dev> In-Reply-To: <1da6648a-251b-456b-9ddd-a7ffa95a5125@linux.dev> 2025-05-09T15:38:55-07:00, Atish Patra : > On 5/8/25 6:32 AM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >> 2025-05-05T14:39:29-07:00, Atish Patra : >>> SENVCFG and SSTATEEN CSRs are controlled by HSENVCFG(62) and >>> SSTATEEN0(63) bits in hstateen. Enable them lazily at runtime >>> instead of bootime. >>> >>> Signed-off-by: Atish Patra >>> --- >>> diff --git a/arch/riscv/kvm/vcpu_insn.c b/arch/riscv/kvm/vcpu_insn.c >>> @@ -256,9 +256,37 @@ int kvm_riscv_vcpu_hstateen_lazy_enable(struct kvm= _vcpu *vcpu, unsigned int csr_ >>> return KVM_INSN_CONTINUE_SAME_SEPC; >>> } >>> =20 >>> +static int kvm_riscv_vcpu_hstateen_enable_senvcfg(struct kvm_vcpu *vcp= u, >>> + unsigned int csr_num, >>> + unsigned long *val, >>> + unsigned long new_val, >>> + unsigned long wr_mask) >>> +{ >>> + return kvm_riscv_vcpu_hstateen_lazy_enable(vcpu, csr_num, SMSTATEEN0_= HSENVCFG); >>> +} >> Basically the same comments as for [1/5]: >> >> Why don't we want to set the ENVCFG bit (62) unconditionally? >> >> It would save us the trap on first access. We don't get anything from >> the trap, so it looks like a net negative to me. > > We want to lazy enablement is to make sure that hypervisor is aware of=20 > the what features > guest is using. We don't want to necessarily enable the architecture=20 > states for the guest if guest doesn't need it. > > We need lazy enablement for CTR like features anyways. This will align=20 > all the the features controlled > by stateen in the same manner. The cost is just a single trap at the=20 > boot time. > > IMO, it's fair trade off. Yeah, as long as we are doing something with the information from the trap. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D3DEC3ABBC for ; Mon, 12 May 2025 10:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:Subject: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7p82cty6Yp6XTCtxG4WprodjbuR1xtKAJFUPTzK4HJw=; b=YHDxW/t5xqZOOi HJILzWU8eb1rk7GBQ6gHS3IFcWQssh0k4d4D8PsDQHsGOBpBij6869rBBBgsd8i68ekn91xC4LU4c LSmZLP/TZPz89Scb8heFP+yo9B5Lgl0IYYYX/6QDmMEy+HuDjlQV2XjQOFZs46GLm7tqVDsEQ4L6z NwcEdrG5ZvYrKP0vedEj3o9hcpN8OpaMOYaNHzLcdcMQM6CY70/LKZN1xV6E5xZFhP5HQnUE3upcH kmkCbUJDreUDWo/r18+4Rk5BrobRneLNgUqZG2mg0LWItmFG6iGAs0NpAodLP5Lsia+zRph7BJLs4 CdElHezj5tv+rXc9L09A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEQS4-000000096da-1XIR; Mon, 12 May 2025 10:32:04 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEQLr-000000095nO-2k5c for linux-riscv@lists.infradead.org; Mon, 12 May 2025 10:25:41 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43d72b749dcso5355235e9.1 for ; Mon, 12 May 2025 03:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1747045537; x=1747650337; darn=lists.infradead.org; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fVYDNzGl1HhtRbOLlZqbNyW/2ZNd9jQ043iVsCWK1J0=; b=RtWXylDSbxdW/Driq+HkbLAO/Hk343L5l/42RTbjJXGKkim5X0vC3mBqDsT5VO+Kxr DAJpr2tuZ2JW6GA4VATRfEEmPrDzljd/mDlBzffrg1/UbF3uyR6jyWi8PCVL9uIrenQU gPDl8AAkFL+nI/HdipmX3yHo5BRFRLAgtpMgJLxuCA1e5lAOgl//lN6lm++0S6XNef7O glbYqf8Zjkdw1cPzCrqtd2LRfcFKPyNbjWXW6WxUSwdIIgGL1L2rO+hyWQj6YrfdKFvF fmgIqCUUz2kzNJo3tQW5EZq62GLJHfYTHpjEZBonHlnhqn9De9x/76sH3YSdevN+/O7+ sg4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747045537; x=1747650337; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fVYDNzGl1HhtRbOLlZqbNyW/2ZNd9jQ043iVsCWK1J0=; b=rbb3aRWqNwufcaxBRzLQuKZjyWjKwQr7F4suJmvbJRqtPjqSLnERkRcmKCP893kC9z W0gn9cPr6gK8lIIDj4MsDi6y70iAmY6eR1GzOwwd30Zos8eCUR8CMjLnhVsvko6IWj7n 6QYOJHpfRCGRq/A94Cr/J/iuejk9/hpq4UwIGLF8BlHifDBl+jIYjDum46GOk0GyQnId id72MrpQmKySYgTWBVkf3Ljv1TkU/FHjN7I3yPfbnhBfrK9RK4+54pbG3IuetPu5p2kW cNHvrokMZFGm+sGcpvZWcBlKO0TgOv0PkHfcbpyHses/wq4TofFw4P0y4wuZ46n2QUt6 uacQ== X-Forwarded-Encrypted: i=1; AJvYcCXsr8QLcr4J4HPMt92vxKeZrTm7i9EIxZLUNFFOR9cyjMB5IunfYRcBTrnyJMnbGBloGy2id7dEcSH3wg==@lists.infradead.org X-Gm-Message-State: AOJu0Yxs1kD4BxIfQ9FHZ223q6JjjFEc0nZmasoI1R+EqNyvOaa8ZP2i tj3TeKXSvVkhTtRwdzpk4MN8lE7UCVFp/k2d5kWJMQuEXSkFo5QCy8yYSeZyrCU= X-Gm-Gg: ASbGncskJ1FXZn3uCUa85heJnYbcL/g/HM7yQhEJDpS08xj3N6RVf1MpXoWRtvpDByK w4iQoeGlgNEVI6l1v1DDSrpNIy2tDoeknSxdi6NXsVNIkOdP49Hu6CrjtnzKcLDbNRVd5KAcgh2 UO+YeLMeJIVQU/hHACCEknYWWEPZdrmHI+YhbN3w4G4snMlklujq+6DgkMRU1HBpJ5awvW2/Ar1 O4/YiInZnySNn3z4CjVtrdTKoZi4BP245xIAML0dkmZX4IzfywGo4bZa9KrW1pJLNGiikpxjiFA /7dvQvQJgyL1Ts6Cvw/G+5EsYRZ/Zmj9NA3PCzURYpkW6bTYReoIfGbxTnU= X-Google-Smtp-Source: AGHT+IGcTuM+dMRNAzDc5kg0U48s/ErTHPCpW1AeG6d0g+VQ2rWI9+vdhUQrqpzvxyWDNYPzIqhOmg== X-Received: by 2002:a05:600c:4ec7:b0:439:9fde:da76 with SMTP id 5b1f17b1804b1-442d6c39b14mr38970815e9.0.1747045537283; Mon, 12 May 2025 03:25:37 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:6b5b:8def:fde9:86fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d76b7fd6sm74327145e9.0.2025.05.12.03.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 03:25:36 -0700 (PDT) Mime-Version: 1.0 Date: Mon, 12 May 2025 12:25:36 +0200 Message-Id: From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= Subject: Re: [PATCH 4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily Cc: , , , , "linux-riscv" To: "Atish Patra" , "Anup Patel" , "Atish Patra" , "Paul Walmsley" , "Palmer Dabbelt" , "Alexandre Ghiti" References: <20250505-kvm_lazy_enable_stateen-v1-0-3bfc4008373c@rivosinc.com> <20250505-kvm_lazy_enable_stateen-v1-4-3bfc4008373c@rivosinc.com> <1da6648a-251b-456b-9ddd-a7ffa95a5125@linux.dev> In-Reply-To: <1da6648a-251b-456b-9ddd-a7ffa95a5125@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250512_032539_686072_AA688498 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org MjAyNS0wNS0wOVQxNTozODo1NS0wNzowMCwgQXRpc2ggUGF0cmEgPGF0aXNoLnBhdHJhQGxpbnV4 LmRldj46Cj4gT24gNS84LzI1IDY6MzIgQU0sIFJhZGltIEtyxI1tw6HFmSB3cm90ZToKPj4gMjAy NS0wNS0wNVQxNDozOToyOS0wNzowMCwgQXRpc2ggUGF0cmEgPGF0aXNocEByaXZvc2luYy5jb20+ Ogo+Pj4gU0VOVkNGRyBhbmQgU1NUQVRFRU4gQ1NScyBhcmUgY29udHJvbGxlZCBieSBIU0VOVkNG Ryg2MikgYW5kCj4+PiBTU1RBVEVFTjAoNjMpIGJpdHMgaW4gaHN0YXRlZW4uIEVuYWJsZSB0aGVt IGxhemlseSBhdCBydW50aW1lCj4+PiBpbnN0ZWFkIG9mIGJvb3RpbWUuCj4+Pgo+Pj4gU2lnbmVk LW9mZi1ieTogQXRpc2ggUGF0cmEgPGF0aXNocEByaXZvc2luYy5jb20+Cj4+PiAtLS0KPj4+IGRp ZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2t2bS92Y3B1X2luc24uYyBiL2FyY2gvcmlzY3Yva3ZtL3Zj cHVfaW5zbi5jCj4+PiBAQCAtMjU2LDkgKzI1NiwzNyBAQCBpbnQga3ZtX3Jpc2N2X3ZjcHVfaHN0 YXRlZW5fbGF6eV9lbmFibGUoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBpbnQgY3Ny Xwo+Pj4gICAJcmV0dXJuIEtWTV9JTlNOX0NPTlRJTlVFX1NBTUVfU0VQQzsKPj4+ICAgfQo+Pj4g ICAKPj4+ICtzdGF0aWMgaW50IGt2bV9yaXNjdl92Y3B1X2hzdGF0ZWVuX2VuYWJsZV9zZW52Y2Zn KHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKPj4+ICsJCQkJCQkgIHVuc2lnbmVkIGludCBjc3JfbnVt LAo+Pj4gKwkJCQkJCSAgdW5zaWduZWQgbG9uZyAqdmFsLAo+Pj4gKwkJCQkJCSAgdW5zaWduZWQg bG9uZyBuZXdfdmFsLAo+Pj4gKwkJCQkJCSAgdW5zaWduZWQgbG9uZyB3cl9tYXNrKQo+Pj4gK3sK Pj4+ICsJcmV0dXJuIGt2bV9yaXNjdl92Y3B1X2hzdGF0ZWVuX2xhenlfZW5hYmxlKHZjcHUsIGNz cl9udW0sIFNNU1RBVEVFTjBfSFNFTlZDRkcpOwo+Pj4gK30KPj4gQmFzaWNhbGx5IHRoZSBzYW1l IGNvbW1lbnRzIGFzIGZvciBbMS81XToKPj4KPj4gV2h5IGRvbid0IHdlIHdhbnQgdG8gc2V0IHRo ZSBFTlZDRkcgYml0ICg2MikgdW5jb25kaXRpb25hbGx5Pwo+Pgo+PiBJdCB3b3VsZCBzYXZlIHVz IHRoZSB0cmFwIG9uIGZpcnN0IGFjY2Vzcy4gIFdlIGRvbid0IGdldCBhbnl0aGluZyBmcm9tCj4+ IHRoZSB0cmFwLCBzbyBpdCBsb29rcyBsaWtlIGEgbmV0IG5lZ2F0aXZlIHRvIG1lLgo+Cj4gV2Ug d2FudCB0byBsYXp5IGVuYWJsZW1lbnQgaXMgdG8gbWFrZSBzdXJlIHRoYXQgaHlwZXJ2aXNvciBp cyBhd2FyZSBvZiAKPiB0aGUgd2hhdCBmZWF0dXJlcwo+IGd1ZXN0IGlzIHVzaW5nLiBXZSBkb24n dCB3YW50IHRvIG5lY2Vzc2FyaWx5IGVuYWJsZSB0aGUgYXJjaGl0ZWN0dXJlIAo+IHN0YXRlcyBm b3IgdGhlIGd1ZXN0IGlmIGd1ZXN0IGRvZXNuJ3QgbmVlZCBpdC4KPgo+IFdlIG5lZWQgbGF6eSBl bmFibGVtZW50IGZvciBDVFIgbGlrZSBmZWF0dXJlcyBhbnl3YXlzLiBUaGlzIHdpbGwgYWxpZ24g Cj4gYWxsIHRoZSB0aGUgZmVhdHVyZXMgY29udHJvbGxlZAo+IGJ5IHN0YXRlZW4gaW4gdGhlIHNh bWUgbWFubmVyLiBUaGUgY29zdCBpcyBqdXN0IGEgc2luZ2xlIHRyYXAgYXQgdGhlIAo+IGJvb3Qg dGltZS4KPgo+IElNTywgaXQncyBmYWlyIHRyYWRlIG9mZi4KClllYWgsIGFzIGxvbmcgYXMgd2Ug YXJlIGRvaW5nIHNvbWV0aGluZyB3aXRoIHRoZSBpbmZvcm1hdGlvbiBmcm9tIHRoZQp0cmFwLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlz Y3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=