All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benno Lossin" <lossin@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] rust: platform: add irq accessors
Date: Wed, 14 May 2025 22:06:14 +0200	[thread overview]
Message-ID: <D9W5K3FPJ3SH.1AMA9VYM75Z4X@kernel.org> (raw)
In-Reply-To: <20250514-topics-tyr-request_irq-v3-2-d6fcc2591a88@collabora.com>

On Wed May 14, 2025 at 9:20 PM CEST, Daniel Almeida wrote:
> +    /// Same as [`Self::irq_by_name`] but does not print an error message if an IRQ
> +    /// cannot be obtained.
> +    pub fn optional_irq_by_name(&self, name: &CStr) -> Result<u32> {
> +        // SAFETY: `self.as_raw` returns a valid pointer to a `struct platform_device`.
> +        let res = unsafe {
> +            bindings::platform_get_irq_byname_optional(self.as_raw(), name.as_char_ptr())
> +        };
> +
> +        if res < 0 {
> +            return Err(Error::from_errno(res));
> +        }
> +
> +        Ok(res as u32)

This patch could make much use of the function for `Error` that does the
last 4 lines.

---
Cheers,
Benno

> +    }
>  }
>  
>  impl Deref for Device<device::Core> {


  reply	other threads:[~2025-05-14 20:06 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14 19:20 [PATCH v3 0/2] rust: add support for request_irq Daniel Almeida
2025-05-14 19:20 ` [PATCH v3 1/2] rust: irq: add support for request_irq() Daniel Almeida
2025-05-14 20:04   ` Benno Lossin
2025-05-14 20:58     ` Daniel Almeida
2025-05-14 21:03       ` Daniel Almeida
2025-05-15  8:46       ` Benno Lossin
2025-05-15 12:06         ` Daniel Almeida
2025-05-15 12:44           ` Benno Lossin
2025-06-02 15:20     ` Alice Ryhl
2025-06-04  7:36       ` Benno Lossin
2025-06-04  7:48         ` Alice Ryhl
2025-06-04  9:43           ` Benno Lossin
2025-05-14 21:53   ` Danilo Krummrich
2025-05-15 11:54     ` Daniel Almeida
2025-05-15 12:04       ` Danilo Krummrich
2025-05-15 12:27         ` Daniel Almeida
2025-05-15 12:45           ` Danilo Krummrich
2025-05-15 13:16             ` Daniel Almeida
2025-05-15 13:45               ` Danilo Krummrich
2025-05-15 13:52                 ` Danilo Krummrich
2025-06-02 14:40                   ` Daniel Almeida
2025-06-02 17:35                     ` Danilo Krummrich
2025-06-02 16:02                   ` Alice Ryhl
2025-05-15 13:28             ` Benno Lossin
2025-06-02 16:19     ` Alice Ryhl
2025-06-02 17:31       ` Danilo Krummrich
2025-06-03  8:28         ` Alice Ryhl
2025-06-03  8:46           ` Danilo Krummrich
2025-06-03  8:54             ` Alice Ryhl
2025-06-03  9:10               ` Danilo Krummrich
2025-06-03  9:18                 ` Alice Ryhl
2025-06-03  9:43                   ` Danilo Krummrich
2025-06-03  9:57                     ` Alice Ryhl
2025-06-03 10:08                       ` Danilo Krummrich
2025-06-03 10:16                         ` Danilo Krummrich
2025-06-04 18:32                           ` Daniel Almeida
2025-06-04 18:57                             ` Danilo Krummrich
2025-05-18 13:24   ` Alexandre Courbot
2025-05-18 14:07     ` Benno Lossin
2025-05-14 19:20 ` [PATCH v3 2/2] rust: platform: add irq accessors Daniel Almeida
2025-05-14 20:06   ` Benno Lossin [this message]
2025-05-19 10:41   ` Danilo Krummrich
2025-06-02 14:56     ` Daniel Almeida
2025-06-02 17:45       ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9W5K3FPJ3SH.1AMA9VYM75Z4X@kernel.org \
    --to=lossin@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.