From: "Benno Lossin" <lossin@kernel.org>
To: "I Hsin Cheng" <richard120310@gmail.com>, <ojeda@kernel.org>
Cc: <alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<benno.lossin@proton.me>, <a.hindborg@kernel.org>,
<aliceryhl@google.com>, <tmgross@umich.edu>,
<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<skhan@linuxfoundation.org>,
<linux-kernel-mentees@lists.linux.dev>, <jserv@ccns.ncku.edu.tw>
Subject: Re: [PATCH] rust: list: Use "List::is_empty()" to perform checking when possible
Date: Thu, 22 May 2025 11:52:56 +0200 [thread overview]
Message-ID: <DA2LIVGXSOVX.25YPFFEHM5CQB@kernel.org> (raw)
In-Reply-To: <20250310073853.427954-1-richard120310@gmail.com>
On Mon Mar 10, 2025 at 8:38 AM CET, I Hsin Cheng wrote:
> "List::is_empty()" provides a straight forward convention to check
> whether a given "List" is empty or not. There're numerous places in the
> current implementation still use "self.first.is_null()" to perform the
> equivalent check, replace them with "List::is_empty()".
>
> Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
> ---
> rust/kernel/list.rs | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Benno Lossin <lossin@kernel.org>
---
Cheers,
Benno
next prev parent reply other threads:[~2025-05-22 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 7:38 [PATCH] rust: list: Use "List::is_empty()" to perform checking when possible I Hsin Cheng
2025-05-21 15:23 ` Miguel Ojeda
2025-05-22 9:47 ` Miguel Ojeda
2025-05-22 9:52 ` Benno Lossin [this message]
2025-05-22 10:01 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA2LIVGXSOVX.25YPFFEHM5CQB@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=richard120310@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.