From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31F4BC54F2E for ; Fri, 23 May 2025 13:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:To:Cc: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ReOgdmCWjw9Efw1pAOTeQpepFZWIDJH9Akw9K18Q71I=; b=ckS3N4b2OMOjwU 6pLCUPTBbftU94UW7fE3+9NQvvf8GYd++c840VhrMQ2YXAumzJN/H9qycAqCwZ2PhlU29VcwalpJ9 517W8LKqT8yjXKMMZbokXLe/uzoXScr8H45F+vcKKurDpK7zNBNrbj2WKzCc8NUNVCtLpomHUStM1 ImbL6eFjgJ3wLjohfHvSGRu0D2D1hm8CoKwJjrRmPi7eTQmtZyN3ubpNj4BRKJn97OTIC5U7xS5z+ ORD/+IPDP4bdH0VMYHqFJXZUXu3J0md11Sy3opO2JdkvcpXxEl+nEa4Q/ULZKBxXZLRue2gqf73Hn STFpVEwWjhRJezBUFDCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uISYc-00000003yTt-3o6w; Fri, 23 May 2025 13:35:30 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uISUp-00000003xjW-31sa for kvm-riscv@lists.infradead.org; Fri, 23 May 2025 13:31:36 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3a361c8a830so1182308f8f.0 for ; Fri, 23 May 2025 06:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1748007094; x=1748611894; darn=lists.infradead.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sE7NSB29qsmfs0sI4wgf6B6ZQGe4IKQtX92E6yxep1o=; b=aWuxvYiguhPiVqddRe9ITBvF8r4rjy64XUYWh1yWPa+pKQKY99eSWcqPmH+DkM6bp6 1wD21+cLj//1lQX/BZja0p0otlO+efKw3GfhEM5qvuTykBJanixNzRhXs97+doqV9buN rvlVvggYiDbnOrY7I9Xl7saxs8CvPvJkwOsyIgv3R0XZM5MpdUEU8sBpHNUfl4Y609wK SW3PFa9NqU6h9iCspWnQi4xQ+5qyr//+A8NuLMuZT0vfXcdR6jCUGNWyoleH/u1UWF1+ iQORVQDYJkXzKJriJOHlxaDiew/xd+eFjln9kng8+9BpPvnYnFqC5cFtRP2Iw5wvN76o 9FFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748007094; x=1748611894; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sE7NSB29qsmfs0sI4wgf6B6ZQGe4IKQtX92E6yxep1o=; b=aeGNu1yP0zWQWds7KEo/gf00NrL6FsAo3kL3vFJOcgAsBpeXcqEBaYDSlHPg9lnYUG M4GAcW5RpB+SuibznmwGiCrAsXf6zUFMHgSzR+xxY62J9vGZ9tlexwH1b216Nnea175I NR/AGf+jVEkPQuvAZRE6at10OkJAfbUo6qlz8vlAG6uxwAEfHUfYAcmeYhEk6ApXrMhk uVNlv1jE1gBj7x+k0NKs6+spMJXlenPCRKQdQyR28ESllGkRP+l31+KiRGIkuV270XU4 vnin/dr90Zh102qo8frMlF1fM1ofL9Ik2iEelXv3xw+Yvq+kmstckjMbGkUHEdBEsz6S nGcw== X-Forwarded-Encrypted: i=1; AJvYcCXi2rCzL+jKQvhUe8oOnoAqG9LKVtrtBsmpdbvV492vFghBLzqbsDaJpK1BalFuXwp+kgOHnteL/es=@lists.infradead.org X-Gm-Message-State: AOJu0Yy8tb0ae2D+hHauQBZR/OHwrg91MZaFpGAjmKYAtOUfKNmRTicX b/xkaqWTo4H2vxk02BU/aPCCUCnfNulwcomaMmOFQUvzaeEtmiGlKQsEdOzlpHz4xjE= X-Gm-Gg: ASbGncthZ4bkuZMaJkWdUj/eEoxq6YXS8oY+/Ph1Ay/xz95qYKxhX8ICI9yqlaQ/n13 3e7GdlTh+Q5OPrf90XsbSc5IJLHmU0CFqDmum8URt7PWwyUDbVzSvmG3cAm5/jNu16ZElbdTv6O pwtMwuKPlM8CK58E0CaJIYhUcvF7rAc66Xbt7gWhn0Fz4CS6MU2GUR9hZzwSYxHqRi/+Psnerd4 vMLd84nphuZH5sUJRbhXrwaXC/qUslsjxATdbkY4hoEGim9GZJFLuO2XToDpEZf5T/8sX/1TyIG iTqZA46TNRqWdZ7mKGjsjQ4sIXK505mFD9jETF2nWDilKBvtZy6Bu0dQJH8= X-Google-Smtp-Source: AGHT+IH4B5YjATsLpzFQConVuBPC8YzXe6dS/7DO0gd92eFJugpX4BslSSwZcD/zqo2WMw5EUo7NzA== X-Received: by 2002:a05:6000:400f:b0:39c:1401:6ede with SMTP id ffacd0b85a97d-3a4c2b3a659mr992493f8f.3.1748007094151; Fri, 23 May 2025 06:31:34 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:be84:d9ad:e5e6:f60b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca8d005sm27248141f8f.90.2025.05.23.06.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 06:31:33 -0700 (PDT) Mime-Version: 1.0 Date: Fri, 23 May 2025 15:31:32 +0200 Message-Id: Subject: Re: [PATCH v3 9/9] RISC-V: KVM: Upgrade the supported SBI version to 3.0 Cc: , , , "Palmer Dabbelt" , , , "linux-riscv" To: "Atish Patra" , "Anup Patel" , "Will Deacon" , "Mark Rutland" , "Paul Walmsley" , "Palmer Dabbelt" , "Mayuresh Chitale" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> In-Reply-To: <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250523_063135_752550_DEE8D8A8 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org 2025-05-22T12:03:43-07:00, Atish Patra : > Upgrade the SBI version to v3.0 so that corresponding features > can be enabled in the guest. > > Signed-off-by: Atish Patra > --- > diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h > -#define KVM_SBI_VERSION_MAJOR 2 > +#define KVM_SBI_VERSION_MAJOR 3 I think it's time to add versioning to KVM SBI implementation. Userspace should be able to select the desired SBI version and KVM would tell the guest that newer features are not supported. We could somewhat get away with the userspace_sbi patch I posted, because userspace would at least be in control of the SBI version, but it would still be incorrect without a KVM enforcement, because a misbehaving guest could use features that should not be supported. -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 085DA29291E for ; Fri, 23 May 2025 13:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748007097; cv=none; b=sFYNbxOgf2RS/G63dNwch0M5jvTOB7+QGx5wfXq7qBVbqRN8c8e/2avYNOeoxwurTkZVMwPDyL74CTLi3GbNsZ3UH78GyMI3f1a7JWZjkjCEkz2FcNylVkGlHU1fTMrYqVsRxhUHcFYc3mAj88zFUI61epCzDja/zGgxQEtO/jI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748007097; c=relaxed/simple; bh=sE7NSB29qsmfs0sI4wgf6B6ZQGe4IKQtX92E6yxep1o=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=PC4ND8w08i7XO1GBm4DHWydUHXsoSkFiiBx44uEJbUH/D8iJmRwDmeaHySArYy6FrS0rvkWq7Vyr97+ue2wvJGxL9ec5Pet4tpesHvVYp50G46XH/IbxYGElkua7buO44gGsPhSRvQh8lk2iu36E4OMgBGWiqUmGpMdT/6adiGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=ZK7h21AF; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="ZK7h21AF" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a368259589so1005436f8f.3 for ; Fri, 23 May 2025 06:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1748007094; x=1748611894; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sE7NSB29qsmfs0sI4wgf6B6ZQGe4IKQtX92E6yxep1o=; b=ZK7h21AFzO78aJkYSkcthA2284pP35VOKEzL669JZMfZVh40cPSxwUqJhG5ck1/pYK QAOcm25tG82u/QQJn6TVErx1VF5wGzJELP3jhgbBK3BpqwavTWdATz9HZK+vsnbhfD5X NJkooyefkoA626z+ANYuH7WRO3uWWUNIjZVrCbvrvO57IMd25yzB8oElvUCqaeWqrE0Z sanPDBaP781coJeu2sQqWBHvP+qtl3cgfjnxWWU7mvHu6CaShC0571ZbtYdp74Clu8BN 7/ZaJnjjJOFTxMMzy9v13Uv3YdQI9syuTOyh1+nUqbiBjhJsLBruTMHGkS3ewVSPQLwu QN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748007094; x=1748611894; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sE7NSB29qsmfs0sI4wgf6B6ZQGe4IKQtX92E6yxep1o=; b=GaCpJ7/iyvJy8Mwp3BU+MSEaYsXJUiflnm74IwMBkG4J/2vhBW1H3n8az03uHwIGvV 350Jf6bIS3s5dZ5MfEoKWSr8J0pr+PvO+Twqrbxj5elQhFAXAAv/80wY3h9w3kLXRgiP XZ8W8rxBP7SUozGCJdWpgcftgBhD7rVsDs8qoXhmGNqyHmpglRC5mQLd4Y34bc3Ws84+ sjakZC63AVJSN235LIS4ooJ1oNp8QPmRfBh4McFE91MuxTmdpBx0A4zs75ZNgi8ya28r 1gb6Y1lnWCexsZ8uFH3uI+T2X9N7rYVp2ySj3q9XiOfvEpUd5X8D7dgOSoKD41kBd7SU +ayQ== X-Forwarded-Encrypted: i=1; AJvYcCX77jVy0nLgAfX7l3Vb92CV6PmsIpBMv0h8Vv+O4FP8ngW3GbzTrY42Wxdete+lpC0RsG8=@vger.kernel.org X-Gm-Message-State: AOJu0YwCG+KAaBb9CzP93MGA9SB9y6uszh5KZxyJHQiwQxRp55qHQL1V W6Zr6NqN627nze3Xg+azv9cR/7s2J1kzAEh7HjyH6wfDY/+R0EZvNfBcRc8dzcOeMnI= X-Gm-Gg: ASbGncutTH/y+utm4eZlPUGg40V+EA6/9ta2kI64PKTKW5EEnSMikuzGSPmKL6rdwck lurbyAsOEhDNJ2hmb0O/gaG1ETT2d/++QsjDxi9LTQQRtkgB3SyYOvRCDaVTtSGAo6bH+dlc/Kl GmBhhTBkzwoydAfohx8ZLxYzcjc74okSC1WpkBV+3tIGUz9zn3ghe1Xhzh+JREqR2arAam95t7o jS2wcFegbsjnQ/Is8BVA2eBtumJ/PeGjOHGdOTs/B5PpvCSrHObcneQf8y9fvFKcFIIbz1HzpeJ ljWIotW5SWzYaljShe5qJAZWIMYTpLjLPqZL0FxY3ZWzTfgsLeTpmsHTiTg= X-Google-Smtp-Source: AGHT+IH4B5YjATsLpzFQConVuBPC8YzXe6dS/7DO0gd92eFJugpX4BslSSwZcD/zqo2WMw5EUo7NzA== X-Received: by 2002:a05:6000:400f:b0:39c:1401:6ede with SMTP id ffacd0b85a97d-3a4c2b3a659mr992493f8f.3.1748007094151; Fri, 23 May 2025 06:31:34 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:be84:d9ad:e5e6:f60b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca8d005sm27248141f8f.90.2025.05.23.06.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 06:31:33 -0700 (PDT) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 23 May 2025 15:31:32 +0200 Message-Id: Subject: Re: [PATCH v3 9/9] RISC-V: KVM: Upgrade the supported SBI version to 3.0 Cc: , , , "Palmer Dabbelt" , , , "linux-riscv" To: "Atish Patra" , "Anup Patel" , "Will Deacon" , "Mark Rutland" , "Paul Walmsley" , "Palmer Dabbelt" , "Mayuresh Chitale" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> In-Reply-To: <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> 2025-05-22T12:03:43-07:00, Atish Patra : > Upgrade the SBI version to v3.0 so that corresponding features > can be enabled in the guest. > > Signed-off-by: Atish Patra > --- > diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/a= sm/kvm_vcpu_sbi.h > -#define KVM_SBI_VERSION_MAJOR 2 > +#define KVM_SBI_VERSION_MAJOR 3 I think it's time to add versioning to KVM SBI implementation. Userspace should be able to select the desired SBI version and KVM would tell the guest that newer features are not supported. We could somewhat get away with the userspace_sbi patch I posted, because userspace would at least be in control of the SBI version, but it would still be incorrect without a KVM enforcement, because a misbehaving guest could use features that should not be supported. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D6BFC54F2E for ; Fri, 23 May 2025 13:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:To:Cc: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b/7b6qSBkZSk7vmye1VQwD3xyy036LNhoH/AqN28cuQ=; b=tgKOaqTwCtBfGH zUj4hKvFrjL5FpSeHkO+ILEF92U429POwRADiqlSI7iwKJ5nBBMCSJFS1DF4+k2v739xKt6rxNebj fPW3sG4Vk0xQdgiie4c8MY1SqJHNFo8f5WC3g7O42lLTkOEC3N22tY5pU5TQZViLb/JZjaOeBIyG0 8sdif46s1t7Khmvl/PhUZK7hhwkoqBJgdN6HkQ0oPgs6nGKeRf0IWWex6KQzAvZPqq/GxKZ2PvGsj MNXePxKKo4Z5G5qG7N8pITA504Yf597sxKoNBBspMCILaFTKWv214ogMW4dZTNFe9dZJ1mcgs/9Ep rpkZG9lug6PisUTENp2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uISYd-00000003yUJ-11Cq; Fri, 23 May 2025 13:35:31 +0000 Received: from mail-wm1-f49.google.com ([209.85.128.49]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uISUq-00000003xjc-15bG for linux-riscv@lists.infradead.org; Fri, 23 May 2025 13:31:37 +0000 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-442cd12d28cso2616895e9.3 for ; Fri, 23 May 2025 06:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1748007094; x=1748611894; darn=lists.infradead.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sE7NSB29qsmfs0sI4wgf6B6ZQGe4IKQtX92E6yxep1o=; b=aWuxvYiguhPiVqddRe9ITBvF8r4rjy64XUYWh1yWPa+pKQKY99eSWcqPmH+DkM6bp6 1wD21+cLj//1lQX/BZja0p0otlO+efKw3GfhEM5qvuTykBJanixNzRhXs97+doqV9buN rvlVvggYiDbnOrY7I9Xl7saxs8CvPvJkwOsyIgv3R0XZM5MpdUEU8sBpHNUfl4Y609wK SW3PFa9NqU6h9iCspWnQi4xQ+5qyr//+A8NuLMuZT0vfXcdR6jCUGNWyoleH/u1UWF1+ iQORVQDYJkXzKJriJOHlxaDiew/xd+eFjln9kng8+9BpPvnYnFqC5cFtRP2Iw5wvN76o 9FFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748007094; x=1748611894; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sE7NSB29qsmfs0sI4wgf6B6ZQGe4IKQtX92E6yxep1o=; b=Zz1IKpQpNJKJ2tlw4VDA3uEiSMb4eprB+YcL4avghvqTde0hS3c76AOQcir2IFaaol ODK/U+qD/7OxeXP5dF43ELjFWBbrEGrVd7ELGw+pgEMEuhVtd6kcigYXBqX7+1yJGA5T 5Safzl1crV4pRXMsIDJ8Wz0Q2UHsY57hFf7x9eKDXA5csDVMb0u5hK4aAD3yU15Wczsc B3wVk16zp0Ck6HA7tw8C0Vzg1f0Clm04Y2cRXe4jVZEZfU8scl26S7PXWdGCGH8NQ5g+ hIPMcye6Of85NeaFshHyUXk6BwLH8gp1kJtxjSwe/1xFbGUf7IlKL0EfDHFaMaWL9zmm uWiw== X-Gm-Message-State: AOJu0Yy0d6DX+ns+BgJEXCqHusmtspHxZD7uiIt2eeCCrWARAOzEZdBl UyPQVDUv9/wn92iA1MT1CoWQLGE5eE0e+75FkmygPuXdPwno/E2YdEyx9ZrqvWZHkjU= X-Gm-Gg: ASbGncuc0AikGCHlfki++/MoaM7eAXEikpk0f3S3H1svP+GzaXNWV77x1T+WxZZ6gUC Mi7dDpzMhsRRbgdnK2aunGPPMcWs7f1V9fI6nlGLgdclUWQWsCreL1N57cG9z+tZgUmw+ZOm9FD 6Cf5gHkZmzBwHO1iuOmk+nbMbIf/r3mU9vK7MkgaPtm1mJC1BynJC46oAlXySIG8Djn6RyX1Ynt dMFhlW8qsjgTQYy4cga99n7UlFSSUGOTW+9+I7kKdChhIt4pv7DPMzDyP6bluQ92AHg5obibl05 EbYDb72ej+0LkVNn97oiyjnpMK15J55ASvgrQS2mzKpedhX54gZwV2rF0Q0= X-Google-Smtp-Source: AGHT+IH4B5YjATsLpzFQConVuBPC8YzXe6dS/7DO0gd92eFJugpX4BslSSwZcD/zqo2WMw5EUo7NzA== X-Received: by 2002:a05:6000:400f:b0:39c:1401:6ede with SMTP id ffacd0b85a97d-3a4c2b3a659mr992493f8f.3.1748007094151; Fri, 23 May 2025 06:31:34 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:be84:d9ad:e5e6:f60b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca8d005sm27248141f8f.90.2025.05.23.06.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 06:31:33 -0700 (PDT) Mime-Version: 1.0 Date: Fri, 23 May 2025 15:31:32 +0200 Message-Id: Subject: Re: [PATCH v3 9/9] RISC-V: KVM: Upgrade the supported SBI version to 3.0 Cc: , , , "Palmer Dabbelt" , , , "linux-riscv" To: "Atish Patra" , "Anup Patel" , "Will Deacon" , "Mark Rutland" , "Paul Walmsley" , "Palmer Dabbelt" , "Mayuresh Chitale" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> In-Reply-To: <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250523_063136_288997_EE9C2FA9 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org 2025-05-22T12:03:43-07:00, Atish Patra : > Upgrade the SBI version to v3.0 so that corresponding features > can be enabled in the guest. > > Signed-off-by: Atish Patra > --- > diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h > -#define KVM_SBI_VERSION_MAJOR 2 > +#define KVM_SBI_VERSION_MAJOR 3 I think it's time to add versioning to KVM SBI implementation. Userspace should be able to select the desired SBI version and KVM would tell the guest that newer features are not supported. We could somewhat get away with the userspace_sbi patch I posted, because userspace would at least be in control of the SBI version, but it would still be incorrect without a KVM enforcement, because a misbehaving guest could use features that should not be supported. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv