From: "Benno Lossin" <lossin@kernel.org>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Fiona Behrens" <me@kloenk.dev>,
"Xiangfei Ding" <dingxiangfei2009@gmail.com>
Cc: <stable@kernel.org>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: list: fix path of `assert_pinned!`
Date: Sun, 25 May 2025 19:39:04 +0200 [thread overview]
Message-ID: <DA5FBED7E1NX.W675V3MKQSMD@kernel.org> (raw)
In-Reply-To: <20250525173450.853413-1-lossin@kernel.org>
On Sun May 25, 2025 at 7:34 PM CEST, Benno Lossin wrote:
> Commit dbd5058ba60c ("rust: make pin-init its own crate") moved all
> items from pin-init into the pin-init crate, including the
> `assert_pinned!` macro.
>
> Thus fix the path.
>
> This occurrence was missed in that commit, since it has no current
> users, although binder does.
Aw damn, I edited the message, but forgot to regenerate the .patch
file... here is the edited version:
Commit dbd5058ba60c ("rust: make pin-init its own crate") moved all
items from pin-init into the pin-init crate, including the
`assert_pinned!` macro.
Thus fix the path of the sole user of the `assert_pinned!` macro.
This occurrence was missed in the commit above, since it is in a macro
has no current users (although binder is a future user).
---
Cheers,
Benno
> Cc: stable@kernel.org # I haven't found the commit in stable yet, but just to be sure.
> Fixes: dbd5058ba60c ("rust: make pin-init its own crate")
> Signed-off-by: Benno Lossin <lossin@kernel.org>
> ---
> rust/kernel/list/arc.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/list/arc.rs b/rust/kernel/list/arc.rs
> index 13c50df37b89..a88a2dc65aa7 100644
> --- a/rust/kernel/list/arc.rs
> +++ b/rust/kernel/list/arc.rs
> @@ -96,7 +96,7 @@ unsafe fn on_drop_list_arc(&self) {}
> } $($rest:tt)*) => {
> impl$(<$($generics)*>)? $crate::list::ListArcSafe<$num> for $t {
> unsafe fn on_create_list_arc_from_unique(self: ::core::pin::Pin<&mut Self>) {
> - $crate::assert_pinned!($t, $field, $fty, inline);
> + ::pin_init::assert_pinned!($t, $field, $fty, inline);
>
> // SAFETY: This field is structurally pinned as per the above assertion.
> let field = unsafe {
>
> base-commit: f26449565019315650c9fe87743b10103910ca6b
next prev parent reply other threads:[~2025-05-25 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 17:34 [PATCH] rust: list: fix path of `assert_pinned!` Benno Lossin
2025-05-25 17:39 ` Benno Lossin [this message]
2025-05-25 18:51 ` Miguel Ojeda
2025-05-25 18:53 ` Miguel Ojeda
2025-05-25 19:48 ` Benno Lossin
2025-05-26 18:46 ` Miguel Ojeda
2025-05-26 19:01 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA5FBED7E1NX.W675V3MKQSMD@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dingxiangfei2009@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.