All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Pradeep Kumar Chitrapu" <quic_pradeepc@quicinc.com>,
	<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>,
	"P Praneesh" <quic_ppranees@quicinc.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH ath-next V14 8/9] wifi: ath12k: add support for 160 MHz bandwidth
Date: Mon, 02 Jun 2025 11:02:59 +0200	[thread overview]
Message-ID: <DABXCM595HBP.3PHKPBRK8C3MD@gmail.com> (raw)
In-Reply-To: <20250521224539.355985-9-quic_pradeepc@quicinc.com>

On Thu May 22, 2025 at 12:45 AM CEST, Pradeep Kumar Chitrapu wrote:
> Add support to configure maximum NSS in 160 MHz bandwidth.
> Firmware advertises support for handling NSS ratio information
> as a part of service ready ext event using nss_ratio_enabled
> flag. Save this information in ath12k_pdev_cap to calculate
> NSS ratio.
>
> Additionally, reorder the code by moving
> ath12k_peer_assoc_h_phymode() before ath12k_peer_assoc_h_vht()
> to ensure that arg->peer_phymode correctly reflects the bandwidth
> in the max NSS calculation.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Co-developed-by: P Praneesh <quic_ppranees@quicinc.com>
> Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/core.h |  2 +
>  drivers/net/wireless/ath/ath12k/mac.c  | 89 ++++++++++++++++++++++----
>  drivers/net/wireless/ath/ath12k/mac.h  |  2 +
>  drivers/net/wireless/ath/ath12k/wmi.c  |  7 +-
>  drivers/net/wireless/ath/ath12k/wmi.h  | 28 ++++++++
>  5 files changed, 115 insertions(+), 13 deletions(-)
[...]
> @@ -2842,10 +2902,13 @@ static enum wmi_phy_mode ath12k_mac_get_phymode_vht(struct ath12k *ar,
>  						    struct ieee80211_link_sta *link_sta)
>  {
>  	if (link_sta->bandwidth == IEEE80211_STA_RX_BW_160) {
> -		if (link_sta->vht_cap.cap & IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ)
> +		if (link_sta->vht_cap.cap & (IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ |
> +		    IEEE80211_VHT_CAP_EXT_NSS_BW_MASK))
>  			return MODE_11AC_VHT160;
>  
> -		/* not sure if this is a valid case? */
> +		/* Allow STA to connect even if it does not explicitly advertise 160 MHz
> +		 * support
> +		 */
>  		return MODE_11AC_VHT160;
>  	}
>  
As this will fix the problem encountered before:
Reviewed-by: Nicolas Escande <nico.escande@gmail.com>


  reply	other threads:[~2025-06-02  9:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21 22:45 [PATCH ath-next V14 0/9] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 1/9] wifi: ath12k: push HE MU-MIMO params to hardware Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 2/9] wifi: ath12k: push EHT " Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 3/9] wifi: ath12k: move HE MCS mapper to a separate function Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 4/9] wifi: ath12k: generate rx and tx mcs maps for supported HE mcs Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 5/9] wifi: ath12k: fix TX and RX MCS rate configurations in HE mode Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 6/9] wifi: ath12k: add support for setting fixed HE rate/GI/LTF Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 7/9] wifi: ath12k: clean up 80P80 support Pradeep Kumar Chitrapu
2025-05-21 22:45 ` [PATCH ath-next V14 8/9] wifi: ath12k: add support for 160 MHz bandwidth Pradeep Kumar Chitrapu
2025-06-02  9:02   ` Nicolas Escande [this message]
2025-05-21 22:45 ` [PATCH ath-next V14 9/9] wifi: ath12k: add extended NSS bandwidth support for 160 MHz Pradeep Kumar Chitrapu
2025-06-23 15:03 ` [PATCH ath-next V14 0/9] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support Jeff Johnson
2025-06-30 21:34   ` Pradeep Kumar Chitrapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DABXCM595HBP.3PHKPBRK8C3MD@gmail.com \
    --to=nico.escande@gmail.com \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=quic_ppranees@quicinc.com \
    --cc=quic_pradeepc@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.