From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <alperyasinak1@gmail.com>, "Quentin Schulz" <quentin.schulz@cherry.de>
Cc: <docs@lists.yoctoproject.org>
Subject: Re: [docs] [PATCH] ref-manual/variables.rst: document KERNEL_EXTRA_FEATURES
Date: Wed, 04 Jun 2025 09:46:59 +0200 [thread overview]
Message-ID: <DADKZIPNS4NH.348N34F0WS0XD@bootlin.com> (raw)
In-Reply-To: <CAGpma=4nc0DcTEddK0FFb6sj2yenN91DnZrcit2poyqOQ_jYSQ@mail.gmail.com>
Hi,
On Mon Jun 2, 2025 at 5:41 PM CEST, Alper Ak via lists.yoctoproject.org wrote:
> Since the KERNEL_FEATURES variable is handled in kernel-yocto.bbclass
> and KERNEL_EXTRA_FEATURES is usually appended to it, I wanted to
> emphasize that this class should be used.
> That's why I made a connection between them and assumed that they were
> complementary. Apparently I misinterpreted it. As you said, it always
> in final/leaf recipes and not .inc files or classes.
>
>> > + such as Poky may set a default value using a soft assignment (``?=``).
>> Does it? I don't see it, only an :append is used.
>
> "bitbake-getvar KERNEL_EXTRA_FEATURES" shows that it is
> appended(:append) in poky.conf but somehow I missed it and wrote soft
I don't think we should document variable default values based on poky.conf, as
Poky is only a reference distro after all.
What bothers me is that KERNEL_EXTRA_FEATURES does not have any default value in
the kernel-yocto class. And I don't see the added value compared to
KERNEL_FEATURES, since what happens in the end is always:
KERNEL_FEATURES:append = " ${KERNEL_EXTRA_FEATURES}"
Meaning users are fine modifying the KERNEL_FEATURES variable directly, I
believe. What do you think?
Antonin
--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-06-04 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 15:49 [PATCH] ref-manual/variables.rst: document KERNEL_EXTRA_FEATURES Alper Ak
2025-06-02 11:36 ` [docs] " Quentin Schulz
2025-06-02 15:41 ` Alper Ak
2025-06-04 7:46 ` Antonin Godard [this message]
2025-06-04 9:52 ` Alper Ak
2025-06-06 8:16 ` Antonin Godard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DADKZIPNS4NH.348N34F0WS0XD@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=alperyasinak1@gmail.com \
--cc=docs@lists.yoctoproject.org \
--cc=quentin.schulz@cherry.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.