From: "Benno Lossin" <lossin@kernel.org>
To: "FUJITA Tomonori" <fujita.tomonori@gmail.com>,
<a.hindborg@kernel.org>, <alex.gaynor@gmail.com>,
<ojeda@kernel.org>
Cc: <aliceryhl@google.com>, <bjorn3_gh@protonmail.com>,
<boqun.feng@gmail.com>, <dakr@kernel.org>, <gary@garyguo.net>,
<rust-for-linux@vger.kernel.org>, <tmgross@umich.edu>,
<tamird@gmail.com>
Subject: Re: [PATCH v1] rust: time: Fix compile error in impl_has_hr_timer macro
Date: Fri, 06 Jun 2025 21:34:48 +0200 [thread overview]
Message-ID: <DAFPAJVGHFAT.DI2E2NA94KM8@kernel.org> (raw)
In-Reply-To: <20250606020505.3186533-1-fujita.tomonori@gmail.com>
On Fri Jun 6, 2025 at 4:05 AM CEST, FUJITA Tomonori wrote:
> Fix a compile error in the `impl_has_hr_timer!` macro as follows:
>
> error[E0599]: no method named cast_mut found for raw pointer *mut Foo in the current scope
>
> The `container_of!` macro already returns a mutable pointer when used
> in a `*mut T` context so the `.cast_mut()` method is not available.
>
> Fixes: 74d6a606c2b3 ("rust: retain pointer mut-ness in `container_of!`")
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Reviewed-by: Benno Lossin <lossin@kernel.org>
---
Cheers,
Benno
> ---
> rust/kernel/time/hrtimer.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
next prev parent reply other threads:[~2025-06-06 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 2:05 [PATCH v1] rust: time: Fix compile error in impl_has_hr_timer macro FUJITA Tomonori
2025-06-06 15:34 ` Miguel Ojeda
2025-06-06 21:36 ` FUJITA Tomonori
2025-06-07 10:19 ` Miguel Ojeda
2025-06-08 21:26 ` Miguel Ojeda
2025-06-10 7:36 ` Andreas Hindborg
2025-06-10 9:49 ` Miguel Ojeda
2025-06-10 10:43 ` Andreas Hindborg
2025-06-06 19:34 ` Benno Lossin [this message]
2025-06-10 19:30 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAFPAJVGHFAT.DI2E2NA94KM8@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.