Re: [PATCH v3 05/14] x86: Replace arch-specific boot_module with common one

[Alejandro Vallejo <agarciav@amd.com>]

On Sat Jun 14, 2025 at 2:54 AM CEST, Stefano Stabellini wrote:
> On Fri, 13 Jun 2025, Alejandro Vallejo wrote:
>> diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
>> index a038e58c11..8d2734f2b5 100644
>> --- a/xen/arch/x86/hvm/dom0_build.c
>> +++ b/xen/arch/x86/hvm/dom0_build.c
>> @@ -648,9 +648,9 @@ static int __init pvh_load_kernel(
>>  {
>>      struct domain *d = bd->d;
>>      struct boot_module *image = bd->kernel;
>> -    struct boot_module *initrd = bd->module;
>> +    struct boot_module *initrd = bd->initrd;
>
> It looks like struct boot_domain is still calling its member "module" at
> this point

Bah, yes. Way too many lines in the diff.

What's _really_ fun is that the pipeline passed. Including the job to build
each commit.

  https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1868636712

I'll have to look into what the hell happened.

Cheers,
Alejandro