From: Alejandro Vallejo <agarciav@amd.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 01/12] CODING_STYLE: Custom type names must be snake-cased by word.
Date: Mon, 23 Jun 2025 13:22:59 +0200 [thread overview]
Message-ID: <DATVH97BCJV2.1LSZEP4HUG997@amd.com> (raw)
In-Reply-To: <a91755cb-0c98-488f-a551-adc0827c9628@suse.com>
On Mon Jun 23, 2025 at 9:31 AM CEST, Jan Beulich wrote:
> On 20.06.2025 20:28, Alejandro Vallejo wrote:
>> There's the unwritten convention in x86 of splitting type names using
>> underscores. Add such convention to the CODINNG_STYLE to make it
>> common and less unwritten.
>
> Just curious: How does x86 come into play here? Xen inherited this un-
> written rule from Linux, afaict.
>
> Jan
x86 follows the rule far more strictly than other Xen ports. Even in Linux it's
not uncommon to see some words stashed together because they represent a single
concept. e.g: "bootmode", "bootram", "bootmod", "bootaddr", etc. Some of them
inherited by Xen itself, like "softirq".
But I digress. I mentioned x86 because it's the most traceable use of the rule
as written in CODING_STYLE in this patch. When or why you decided to do so is
another matter entirely which I very definitely do not know.
If you feel the commit message should be something else, I'm happy for it to be
such something else.
Cheers,
Alejandro
next prev parent reply other threads:[~2025-06-23 11:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 18:28 [PATCH v4 00/12] Allow x86 to unflatten DTs Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 01/12] CODING_STYLE: Custom type names must be snake-cased by word Alejandro Vallejo
2025-06-21 1:06 ` Stefano Stabellini
2025-06-23 7:31 ` Jan Beulich
2025-06-23 11:22 ` Alejandro Vallejo [this message]
2025-06-20 18:28 ` [PATCH v4 02/12] xen: Rename bootmodule{,s} to boot_module{,s} Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 03/12] x86: Replace arch-specific boot_module with common one Alejandro Vallejo
2025-06-21 1:12 ` Stefano Stabellini
2025-06-20 18:28 ` [PATCH v4 04/12] xen: Refactor kernel_info to have a header like boot_domain Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 05/12] x86: Replace arch-specific boot_domain with the common one Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 06/12] xen/dt: Move bootfdt functions to xen/bootfdt.h Alejandro Vallejo
2025-06-21 1:20 ` Stefano Stabellini
2025-06-20 18:28 ` [PATCH v4 07/12] xen/dt: Move bootinfo functions to a new bootinfo.h Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 08/12] xen/dt: Rename bootfdt.c -> bootinfo-fdt.c Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 09/12] xen/dt: Extract helper to map nodes to module kinds Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 10/12] xen: Rename CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_DEVICE_TREE_DISCOVERY Alejandro Vallejo
2025-06-21 1:25 ` Stefano Stabellini
2025-06-23 7:39 ` Jan Beulich
2025-06-23 7:41 ` Jan Beulich
2025-06-23 13:11 ` Alejandro Vallejo
2025-06-23 13:44 ` Jan Beulich
2025-06-23 14:19 ` Alejandro Vallejo
2025-06-23 14:26 ` Jan Beulich
2025-06-23 15:10 ` Alejandro Vallejo
2025-06-20 18:28 ` [PATCH v4 11/12] xen/dt: ifdef out DEV_DT-related bits from device_tree.{c,h} Alejandro Vallejo
2025-06-21 1:27 ` Stefano Stabellini
2025-06-23 7:44 ` Jan Beulich
2025-06-23 13:18 ` Alejandro Vallejo
2025-06-23 13:45 ` Jan Beulich
2025-06-20 18:28 ` [PATCH v4 12/12] xen/dt: Remove DOM0LESS_BOOT's requirement on HAS_DEVICE_TREE_DISCOVERY Alejandro Vallejo
2025-06-21 1:45 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DATVH97BCJV2.1LSZEP4HUG997@amd.com \
--to=agarciav@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.