Re: [PATCH v2] Add support for XM25LU64C

From: "Michael Walle" <mwalle@kernel.org>
To: "Ssunk" <ssunkkan@gmail.com>, <pratyush@kernel.org>
Cc: <hhlee@google.com>, <linux-mtd@lists.infradead.org>,
	<miquel.raynal@bootlin.com>, <richard@nod.at>,
	<roccochen@google.com>, <tudor.ambarus@linaro.org>,
	<vigneshr@ti.com>
Subject: Re: [PATCH v2] Add support for XM25LU64C
Date: Mon, 30 Jun 2025 13:59:23 +0200	[thread overview]
Message-ID: <DAZUMXW900R8.196NNPD9CWDCJ@kernel.org> (raw)
In-Reply-To: <20250630105503.4673-1-ssunkkan@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1663 bytes --]

On Mon Jun 30, 2025 at 12:55 PM CEST, Ssunk wrote:
> The device is produced by Wuhan Xinxin Semiconductor Manufacturing Corp. (XMC)
> and found on some routers from Chinese manufactures.
> We need to add this chip to google's AVL

What is google AVL?

> The flash ID was incorrectly set to 0x16 0x41 0x17.
> Update to 0x20 0x41 0x17 as per the datasheet.

This is not something what you put into the commit message.

> The data sheet can be found here:
> https://www.xmcwh.com/uploads/954/XM25LU64C%20_%20Ver1.5.pdf

I get a 404 here.

> Signed-off-by: Kankan Sun <ssunkkan@gmail.com>
> ---
> Changes in v2: 
>  - Fix flash ID from 0x16 0x41 0x17 to 0x20 0x41 0x17 (datasheet confirmed).
>  drivers/mtd/spi-nor/xmc.c | 5 +++++
>  1 file changed, 5 insertions(+)

NAK.

This flash probably supports SFDP. Pratyush and Tudor have
already asked that and there was no answer as far as I can tell.

That is also probably why the flash was working with your v1
although the ID was wrong. Or you don't even test your patches which
would be even worse.

-michael

>
> diff --git a/drivers/mtd/spi-nor/xmc.c b/drivers/mtd/spi-nor/xmc.c
> index d5a06054b0dd..bc7b1a2afa9b 100644
> --- a/drivers/mtd/spi-nor/xmc.c
> +++ b/drivers/mtd/spi-nor/xmc.c
> @@ -19,6 +19,11 @@ static const struct flash_info xmc_nor_parts[] = {
>  		.name = "XM25QH128A",
>  		.size = SZ_16M,
>  		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
> +	}, {
> +		.id = SNOR_ID(0x20, 0x41, 0x17),
> +		.name = "XM25LU64C",
> +		.size = SZ_8M,
> +		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>  	},
>  };
>  

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/