Re: [PATCH v5 02/10] xen: Refactor kernel_info to have a header like boot_domain

[Alejandro Vallejo <alejandro.garciavallejo@amd.com>]

On Thu Jul 3, 2025 at 8:01 AM CEST, Jan Beulich wrote:
> On 02.07.2025 18:04, Alejandro Vallejo wrote:
>> On Wed Jul 2, 2025 at 2:56 PM CEST, Jan Beulich wrote:
>>> On 01.07.2025 12:56, Alejandro Vallejo wrote:
>>>> --- a/xen/include/xen/fdt-kernel.h
>>>> +++ b/xen/include/xen/fdt-kernel.h
>>>> @@ -16,7 +16,7 @@
>>>>  #endif
>>>>  
>>>>  struct kernel_info {
>>>> -    struct domain *d;
>>>> +    struct boot_domain hdr;
>>>>  
>>>>      void *fdt; /* flat device tree */
>>>>      paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */
>>>> @@ -34,8 +34,7 @@ struct kernel_info {
>>>>      paddr_t gnttab_size;
>>>>  
>>>>      /* boot blob load addresses */
>>>> -    const struct boot_module *kernel, *initrd, *dtb;
>>>
>>> Where did this "const" go?
>> 
>> x86 mutates the boot module to set the released flag, the headroom, etc.
>
> Might be nice to mention such an aspect in the description.
>
> Jan

Sure.

Cheers,
Alejandro