From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 587CEC83F0D for ; Tue, 8 Jul 2025 16:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Subject:Cc:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hNKNmRm8BHgY68ixe0cW33FC78NWI3s3JD5EkfbcAnM=; b=htg+ECsvzoqoVe+BmeWol1fk4O x0PZ25Yh7nBTh00X/enTCyVAlQSQte5XjevtdmJMwzUhB2WK/zLJSGYomcO8SZOnmf/dIUV5fdy1T 3m377vyom8twoQtjjGKwj3dHGkSm/spUt/7GvdXyWENPqfOhiLigibwnvw+dVtxLwbHoeVHNtwMeD +XyfjREQ2gscpTtOqOaf14J7q1S8HpcOEjkUnP61becSYr/K94ayqDEQl6tYWZjOg+NWoknBEFT2Q ZK6MsK3oT1uxcCNhB24LxNxMTO64aPid2hEBhrJkZAjbLEFHlixzNnS6blOch7sZ08vai/FZikXY/ rgvv5ZrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZBb8-000000061kj-1EiS; Tue, 08 Jul 2025 16:55:14 +0000 Received: from out-176.mta1.migadu.com ([95.215.58.176]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZB1v-00000005wwe-0hpg for linux-arm-kernel@lists.infradead.org; Tue, 08 Jul 2025 16:18:53 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1751991527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hNKNmRm8BHgY68ixe0cW33FC78NWI3s3JD5EkfbcAnM=; b=CnRmQdi4cSroZwkPcPitp9tu0AJiJLrfSeiLIvjM3gtktzHGFh2LKoJ2uPGHOMitoci+NT izjdJAdO8XsYRo+Oq3GiwuSVTdz5QiGEmlHTT3NbvtPSkdcCjkuTGvS8G4NgHykAvjC1k6 r7WqYnBroHENGNyVpHFRxYEw8NPuICTdVRmslC96Z555632VQriE1S1WiemxOiFi4LBu3Y bZnthcTUCuBsuQ3Sc4j+y9g6Z01ujzgZfOwjViV+/K+cmgmkqSox4U0fak4Pvsxg4yNssq gHJZP7fkEfND4RoZyHliHAhRUEkXCTAVep365DtENGVRDPoKzKyBY9u5GtwXlA== Content-Type: multipart/signed; boundary=b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Tue, 08 Jul 2025 18:18:32 +0200 Message-Id: Cc: "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , "Dragan Simic" , "Quentin Schulz" , "Johan Jonker" , , , , Subject: Re: [PATCH v3 03/10] dt-bindings: display: rockchip,dw-mipi-dsi: Drop address/size cells X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Rob Herring" References: <20250629123840.34948-1-didi.debian@cknow.org> <20250629123840.34948-4-didi.debian@cknow.org> <20250708154728.GA401802-robh@kernel.org> In-Reply-To: <20250708154728.GA401802-robh@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250708_091851_856780_7D7CFC81 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Tue Jul 8, 2025 at 5:47 PM CEST, Rob Herring wrote: > On Sun, Jun 29, 2025 at 02:34:44PM +0200, Diederik de Haas wrote: >> When the dw-mipi-dsi binding was initially added in commit >> a20d86e7f964 ("Documentation: dt-bindings: Add bindings for rk3288 DW MI= PI DSI driver") >> the #address-cells and #size-cells were added as required properties. >>=20 >> When the binding was converted to yaml format in commit >> 0dac2102cf6b ("dt-bindings: display: rockchip: convert dw_mipi_dsi_rockc= hip.txt to yaml") >> those properties were demoted to optional and removed from the binding >> example. >>=20 >> As for the compatibles: >> - rockchip,px30-mipi-dsi removed in this patch set >> - rockchip,rk3128-mipi-dsi never used >> - rockchip,rk3288-mipi-dsi added (invalid); later removed [1] >> - rockchip,rk3399-mipi-dsi removed in this patch set >> - rockchip,rk3568-mipi-dsi never used >> - rockchip,rv1126-mipi-dsi proposed (invalid); never accepted [2] >>=20 >> [1] 282e2e078ba5 ("ARM: dts: rockchip: Remove #address/#size-cells from = rk3288 mipi_dsi") >> [2] https://lore.kernel.org/all/20230731110012.2913742-12-jagan@edgeble.= ai/ >>=20 >> The #address-cells and #size-cells are useful (and required) in the >> ports node and for panel(s), but those properties are declared in their >> schemas already. Now that there are no remaining users, remove these >> properties from the Rockchip specific extensions of the Synopsys >> DesignWare MIPI DSI host controller. > > The change is fine, but your reasoning is flawed. These properties are=20 > used if you define DSI devices on the "DSI bus" where the address of the= =20 > child devices are the DSI virtual channel. Often though that's just 0=20 > and not really used, so you don't need it.=20 Thanks for the explanation :-) > The change is fine because these properties are defined in=20 > dsi-controller.yaml, so specifying them here is redundant. Indeed. Will fix in the next version. Cheers, Diederik >>=20 >> Signed-off-by: Diederik de Haas >> --- >> .../bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml | 6 ------ >> 1 file changed, 6 deletions(-) >>=20 >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip= ,dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/rockchip/rock= chip,dw-mipi-dsi.yaml >> index ccd71c5324af..0881e82deb11 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mip= i-dsi.yaml >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mip= i-dsi.yaml >> @@ -58,12 +58,6 @@ properties: >> power-domains: >> maxItems: 1 >> =20 >> - "#address-cells": >> - const: 1 >> - >> - "#size-cells": >> - const: 0 >> - >> required: >> - compatible >> - clocks >> --=20 >> 2.50.0 >>=20 --b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaG1E3QAKCRDXblvOeH7b bhZ2AQCo4r/8Ze3rjjdZXsSJV6ODrloMV5iLNIJ6E0pWHTCstQD/VCyJ7pDn22ZQ c22OxrVzh6OdIoJLPwCuPP9zimQoGgc= =Bkvu -----END PGP SIGNATURE----- --b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84217C83F0A for ; Tue, 8 Jul 2025 16:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:References:To:From:Subject:Cc:Message-Id:Date:Mime-Version: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1QzPZgQ7+hojRbzsPAFBvc8V0H7PvsfoFuRGi4fyJ0A=; b=aHj0qrO5ycjpNzyYOBraOfA8R7 6UIT+QD1TJq9EGOLBV6lXCwAfEgrOL2VZUth8Dl4CneTNmxghOOgFE2h1xTaiHkIrpkWUTM3zxZ1i J6L8hTy1PdVvUKzxYFO1L8odYvBsAtMkHEOoW+UJ+hIcF7TPZP+YiaFGYpLHdS9iOyUP3ku0lMFCO ckzeD8Evn4fk32aCAHU7bREVZyUklprKqq27VtJGLRgPsKWvCYKmvCL/AW4AabG3fPeYmCgrtDBW2 emd1fG3M4STdcIgjboNQmyoKr6t8qe/+G5f+PgeOdUUINxM2h61a9ggFwUF22kNKYKptOLx4FJ5IP YQiMbxlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZBb8-000000061l4-459f; Tue, 08 Jul 2025 16:55:14 +0000 Received: from out-177.mta1.migadu.com ([95.215.58.177]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZB23-00000005wxf-09pN for linux-rockchip@lists.infradead.org; Tue, 08 Jul 2025 16:19:00 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1751991527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hNKNmRm8BHgY68ixe0cW33FC78NWI3s3JD5EkfbcAnM=; b=CnRmQdi4cSroZwkPcPitp9tu0AJiJLrfSeiLIvjM3gtktzHGFh2LKoJ2uPGHOMitoci+NT izjdJAdO8XsYRo+Oq3GiwuSVTdz5QiGEmlHTT3NbvtPSkdcCjkuTGvS8G4NgHykAvjC1k6 r7WqYnBroHENGNyVpHFRxYEw8NPuICTdVRmslC96Z555632VQriE1S1WiemxOiFi4LBu3Y bZnthcTUCuBsuQ3Sc4j+y9g6Z01ujzgZfOwjViV+/K+cmgmkqSox4U0fak4Pvsxg4yNssq gHJZP7fkEfND4RoZyHliHAhRUEkXCTAVep365DtENGVRDPoKzKyBY9u5GtwXlA== Date: Tue, 08 Jul 2025 18:18:32 +0200 Message-Id: Cc: "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , "Dragan Simic" , "Quentin Schulz" , "Johan Jonker" , , , , Subject: Re: [PATCH v3 03/10] dt-bindings: display: rockchip,dw-mipi-dsi: Drop address/size cells X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Rob Herring" References: <20250629123840.34948-1-didi.debian@cknow.org> <20250629123840.34948-4-didi.debian@cknow.org> <20250708154728.GA401802-robh@kernel.org> In-Reply-To: <20250708154728.GA401802-robh@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250708_091859_218375_9A5521BA X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0456282128696091278==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============0456282128696091278== Content-Type: multipart/signed; boundary=b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0; micalg=pgp-sha512; protocol="application/pgp-signature" --b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Tue Jul 8, 2025 at 5:47 PM CEST, Rob Herring wrote: > On Sun, Jun 29, 2025 at 02:34:44PM +0200, Diederik de Haas wrote: >> When the dw-mipi-dsi binding was initially added in commit >> a20d86e7f964 ("Documentation: dt-bindings: Add bindings for rk3288 DW MI= PI DSI driver") >> the #address-cells and #size-cells were added as required properties. >>=20 >> When the binding was converted to yaml format in commit >> 0dac2102cf6b ("dt-bindings: display: rockchip: convert dw_mipi_dsi_rockc= hip.txt to yaml") >> those properties were demoted to optional and removed from the binding >> example. >>=20 >> As for the compatibles: >> - rockchip,px30-mipi-dsi removed in this patch set >> - rockchip,rk3128-mipi-dsi never used >> - rockchip,rk3288-mipi-dsi added (invalid); later removed [1] >> - rockchip,rk3399-mipi-dsi removed in this patch set >> - rockchip,rk3568-mipi-dsi never used >> - rockchip,rv1126-mipi-dsi proposed (invalid); never accepted [2] >>=20 >> [1] 282e2e078ba5 ("ARM: dts: rockchip: Remove #address/#size-cells from = rk3288 mipi_dsi") >> [2] https://lore.kernel.org/all/20230731110012.2913742-12-jagan@edgeble.= ai/ >>=20 >> The #address-cells and #size-cells are useful (and required) in the >> ports node and for panel(s), but those properties are declared in their >> schemas already. Now that there are no remaining users, remove these >> properties from the Rockchip specific extensions of the Synopsys >> DesignWare MIPI DSI host controller. > > The change is fine, but your reasoning is flawed. These properties are=20 > used if you define DSI devices on the "DSI bus" where the address of the= =20 > child devices are the DSI virtual channel. Often though that's just 0=20 > and not really used, so you don't need it.=20 Thanks for the explanation :-) > The change is fine because these properties are defined in=20 > dsi-controller.yaml, so specifying them here is redundant. Indeed. Will fix in the next version. Cheers, Diederik >>=20 >> Signed-off-by: Diederik de Haas >> --- >> .../bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml | 6 ------ >> 1 file changed, 6 deletions(-) >>=20 >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip= ,dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/rockchip/rock= chip,dw-mipi-dsi.yaml >> index ccd71c5324af..0881e82deb11 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mip= i-dsi.yaml >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mip= i-dsi.yaml >> @@ -58,12 +58,6 @@ properties: >> power-domains: >> maxItems: 1 >> =20 >> - "#address-cells": >> - const: 1 >> - >> - "#size-cells": >> - const: 0 >> - >> required: >> - compatible >> - clocks >> --=20 >> 2.50.0 >>=20 --b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaG1E3QAKCRDXblvOeH7b bhZ2AQCo4r/8Ze3rjjdZXsSJV6ODrloMV5iLNIJ6E0pWHTCstQD/VCyJ7pDn22ZQ c22OxrVzh6OdIoJLPwCuPP9zimQoGgc= =Bkvu -----END PGP SIGNATURE----- --b3514f8fd3e86b6532e5c7ea08104d2f83e4033e68a03e67e98b1ae5f2a0-- --===============0456282128696091278== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============0456282128696091278==--