From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A8BD22338; Thu, 10 Jul 2025 21:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752182372; cv=none; b=AVXFfqkpNQwg2OxO3MFW8P/wUsXKJJrmQgEeq0lYr3TXa0r0FIb6KzSbfo3a5Mj0A9g1Z3xtmeGSidFqGJj8bzCKR10gevjNwnbBFRBF3HHD45cQNj3VJImw5sXsmtybXABKZ0R5MHiGUWynbmum2kJd14MwvkUcKfeeQnfHaY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752182372; c=relaxed/simple; bh=0zK4b9WCKbhDn6z7GD5R0mIS3pwTZmyc1BLcnwDAQs4=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=WAHwIreK++6CLdMao0z0J11KwLWFkGtVAQBmGwa65Kiu1aO9ZrLXjtDmpfMxUa7pvqZLGsrQ/tfzogIof6ERYq3SYdPmg17Id0Dq5G1max3Gd9Qbh3sbVI6O8vLnQQcgptEvNibPJ8emEUEBJDqfARJXB36p/BQgvK5bWTwMN7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vPkUlA0N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vPkUlA0N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8929FC4CEE3; Thu, 10 Jul 2025 21:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752182371; bh=0zK4b9WCKbhDn6z7GD5R0mIS3pwTZmyc1BLcnwDAQs4=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=vPkUlA0NUJLGY/Q4PvaaFqidAOKuSwxT+5jVUD9cwF/qy/NHVyyVRYgDzjtWs51TE TgfvcQUsC55IDISpn13HnEy7SQybmToEkjdwJDu6iiQhJ16+k+cc+5JqQ/vj4m4ToW iwjYVqttFqRRFrilkHJAj3kMi4f91IftPYkBz3+9Sg2wTit/UprIqtsoNOOs13Rc1K voWpDI6wCmV+valiZDVLyo+3C9G/cVISn5p7R4pRMdHs2LFlrbAcGt+TnTUCjNihET +Hiva66FTC+buuJJFdmDf+A+Dk/vyqoKWkVhxvpzUQq68t25OH58dtSdlTeCaWfIX0 /c+ZvJbVzx/cg== Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 10 Jul 2025 23:19:24 +0200 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v10 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Cc: "Michal Wilczynski" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Guo Ren" , "Fu Wei" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Marek Szyprowski" , "Benno Lossin" , "Michael Turquette" , "Drew Fustini" , , , , , , "Krzysztof Kozlowski" To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= References: <20250707-rust-next-pwm-working-fan-for-sending-v10-0-d0c5cf342004@samsung.com> <4hmb3di5x2iei43nmrykrj5wzlltrf3vrnqvexiablonbscn57@4bbsz5c76t63> In-Reply-To: On Thu Jul 10, 2025 at 10:57 PM CEST, Uwe Kleine-K=C3=B6nig wrote: > On Thu, Jul 10, 2025 at 06:06:26PM +0200, Danilo Krummrich wrote: >> On Thu Jul 10, 2025 at 5:25 PM CEST, Uwe Kleine-K=C3=B6nig wrote: >> > Hello Michal, >> > >> > On Thu, Jul 10, 2025 at 03:48:08PM +0200, Michal Wilczynski wrote: >> >> On 7/10/25 15:10, Uwe Kleine-K=C3=B6nig wrote: >> >> > On Thu, Jul 10, 2025 at 10:42:07AM +0200, Michal Wilczynski wrote: >> >> >> On 7/7/25 11:48, Michal Wilczynski wrote: >> >> >>> The series is structured as follows: >> >> >>> - Expose static function pwmchip_release. >> >> >=20 >> >> > Is this really necessary? I didn't try to understand the requiremen= ts >> >> > yet, but I wonder about that. If you get the pwmchip from >> >> > __pwmchip_add() the right thing to do to release it is to call >> >> > pwmchip_remove(). Feels like a layer violation. >> >>=20 >> >> It's required to prevent a memory leak in a specific, critical failur= e >> >> scenario. The sequence of events is as follows: >> >>=20 >> >> pwm::Chip::new() succeeds, allocating both the C struct pwm_chip = and >> >> the Rust drvdata. >> >>=20 >> >> pwm::Registration::register() (which calls pwmchip_add()) fails f= or >> >> some reason. >> > >>=20 >> (Just trying to help clear up the confusion.) > > Very appreciated! > >> > If you called pwmchip_alloc() but not yet pwmchip_add(), the right >> > function to call for cleanup is pwmchip_put(). >>=20 >> That is exactly what is happening when ARef is dropped. If the ref= erence >> count drops to zero, pwmchip_release() is called, which frees the chip. = However, >> this would leave the driver's private data allocation behind, which is o= wned by >> the Chip instance. > > I don't understand that. The chip and the driver private data both are > located in the same allocation. How is this a problem of the driver > private data only then? The kfree() in pwmchip_release() is good enough > for both?! Not in the current abstractions, there are two allocations, one for the Chi= p and one for the driver's private data, or in other words the abstraction uses pwmchip_set_drvdata() and pwmchip_get_drvdata(). Having a brief look at pwmchip_alloc(), it seems to me that PWM supports th= e subclassing pattern with pwmchip_priv(). We should probably take advantage of that. Assuming we do that, the Rust abstraction still needs a release() callback because we still need to call drop_in_place() in order to get the destructor of the driver's private data type called. We actually missed this in DRM and I fixed it up recently [1]. @Michal: With the subclassing pattern the Chip structure would look like th= is: #[repr(C)] #[pin_data] pub struct Chip { inner: Opaque, #[pin] data: T, } And in the release() callback would look like this: extern "C" fn release(ptr: *mut bindings::pwm_chip) { // CAST: Casting `ptr` to `Chip` is valid, since [...]. let this =3D ptr.cast>(); // SAFETY: // - When `release` runs it is guaranteed that there is no further = access to `this`. // - `this` is valid for dropping. unsafe { core::ptr::drop_in_place(this) }; } This is exactly what we're doing in DRM as well, I would have recommended t= his to begin with, but I didn't recognize that PWM supports subclassing. :) I recommend having a look at [2]. [1] https://lore.kernel.org/all/20250629153747.72536-1-dakr@kernel.org/ [2] https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-fixes/ru= st/kernel/drm/device.rs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB033C83F25 for ; Fri, 11 Jul 2025 01:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:Subject: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X8/Qj5JGQvGJiPW3Me83NCywlat9xIXfFf22nvsegZo=; b=kfBFvYChoOPz3y JlrktfCG1ucyXy7PzK3b5SYfYFabYM1hIDgE3Y8S923KUUSZ2bDU3mCNd1J+pjrEMks2dyeY86aKT TvEOjWHMVSNmWfZySfxEZmuepSg5gH3FpHKUMJ/YjzZ9GAFg0yapM13aK4ACEgn6jPqykB9g6AAIt Yk49YYmfRF59HRcojI+64sg4dEgvjIm7mscdQKXeBuKZ75fR2qe5nKZ7fORQ5H+ix0M93GWXh7FKY YE71JSnW2ZlY3CGLGmKFA/2JD1QKTWN0IGjGfOdlYZa3w40l9HmvPzfwYMQnkhR4bewQEJTd7RbAa 35rnUYvhi+dKM3hVx6Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ua2Q6-0000000DPzs-3qsF; Fri, 11 Jul 2025 01:19:22 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZyg0-0000000D3GS-3DEu for linux-riscv@lists.infradead.org; Thu, 10 Jul 2025 21:19:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0ED2D460DF; Thu, 10 Jul 2025 21:19:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8929FC4CEE3; Thu, 10 Jul 2025 21:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752182371; bh=0zK4b9WCKbhDn6z7GD5R0mIS3pwTZmyc1BLcnwDAQs4=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=vPkUlA0NUJLGY/Q4PvaaFqidAOKuSwxT+5jVUD9cwF/qy/NHVyyVRYgDzjtWs51TE TgfvcQUsC55IDISpn13HnEy7SQybmToEkjdwJDu6iiQhJ16+k+cc+5JqQ/vj4m4ToW iwjYVqttFqRRFrilkHJAj3kMi4f91IftPYkBz3+9Sg2wTit/UprIqtsoNOOs13Rc1K voWpDI6wCmV+valiZDVLyo+3C9G/cVISn5p7R4pRMdHs2LFlrbAcGt+TnTUCjNihET +Hiva66FTC+buuJJFdmDf+A+Dk/vyqoKWkVhxvpzUQq68t25OH58dtSdlTeCaWfIX0 /c+ZvJbVzx/cg== Mime-Version: 1.0 Date: Thu, 10 Jul 2025 23:19:24 +0200 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v10 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Cc: "Michal Wilczynski" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Guo Ren" , "Fu Wei" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Marek Szyprowski" , "Benno Lossin" , "Michael Turquette" , "Drew Fustini" , , , , , , "Krzysztof Kozlowski" To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= References: <20250707-rust-next-pwm-working-fan-for-sending-v10-0-d0c5cf342004@samsung.com> <4hmb3di5x2iei43nmrykrj5wzlltrf3vrnqvexiablonbscn57@4bbsz5c76t63> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250710_141932_848168_6D2BFBF1 X-CRM114-Status: GOOD ( 22.69 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1IEp1bCAxMCwgMjAyNSBhdCAxMDo1NyBQTSBDRVNULCBVd2UgS2xlaW5lLUvDtm5pZyB3 cm90ZToKPiBPbiBUaHUsIEp1bCAxMCwgMjAyNSBhdCAwNjowNjoyNlBNICswMjAwLCBEYW5pbG8g S3J1bW1yaWNoIHdyb3RlOgo+PiBPbiBUaHUgSnVsIDEwLCAyMDI1IGF0IDU6MjUgUE0gQ0VTVCwg VXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4+ID4gSGVsbG8gTWljaGFsLAo+PiA+Cj4+ID4gT24g VGh1LCBKdWwgMTAsIDIwMjUgYXQgMDM6NDg6MDhQTSArMDIwMCwgTWljaGFsIFdpbGN6eW5za2kg d3JvdGU6Cj4+ID4+IE9uIDcvMTAvMjUgMTU6MTAsIFV3ZSBLbGVpbmUtS8O2bmlnIHdyb3RlOgo+ PiA+PiA+IE9uIFRodSwgSnVsIDEwLCAyMDI1IGF0IDEwOjQyOjA3QU0gKzAyMDAsIE1pY2hhbCBX aWxjenluc2tpIHdyb3RlOgo+PiA+PiA+PiBPbiA3LzcvMjUgMTE6NDgsIE1pY2hhbCBXaWxjenlu c2tpIHdyb3RlOgo+PiA+PiA+Pj4gVGhlIHNlcmllcyBpcyBzdHJ1Y3R1cmVkIGFzIGZvbGxvd3M6 Cj4+ID4+ID4+PiAgLSBFeHBvc2Ugc3RhdGljIGZ1bmN0aW9uIHB3bWNoaXBfcmVsZWFzZS4KPj4g Pj4gPiAKPj4gPj4gPiBJcyB0aGlzIHJlYWxseSBuZWNlc3Nhcnk/IEkgZGlkbid0IHRyeSB0byB1 bmRlcnN0YW5kIHRoZSByZXF1aXJlbWVudHMKPj4gPj4gPiB5ZXQsIGJ1dCBJIHdvbmRlciBhYm91 dCB0aGF0LiBJZiB5b3UgZ2V0IHRoZSBwd21jaGlwIGZyb20KPj4gPj4gPiBfX3B3bWNoaXBfYWRk KCkgdGhlIHJpZ2h0IHRoaW5nIHRvIGRvIHRvIHJlbGVhc2UgaXQgaXMgdG8gY2FsbAo+PiA+PiA+ IHB3bWNoaXBfcmVtb3ZlKCkuIEZlZWxzIGxpa2UgYSBsYXllciB2aW9sYXRpb24uCj4+ID4+IAo+ PiA+PiBJdCdzIHJlcXVpcmVkIHRvIHByZXZlbnQgYSBtZW1vcnkgbGVhayBpbiBhIHNwZWNpZmlj LCBjcml0aWNhbCBmYWlsdXJlCj4+ID4+IHNjZW5hcmlvLiBUaGUgc2VxdWVuY2Ugb2YgZXZlbnRz IGlzIGFzIGZvbGxvd3M6Cj4+ID4+IAo+PiA+PiAgICAgcHdtOjpDaGlwOjpuZXcoKSBzdWNjZWVk cywgYWxsb2NhdGluZyBib3RoIHRoZSBDIHN0cnVjdCBwd21fY2hpcCBhbmQKPj4gPj4gICAgIHRo ZSBSdXN0IGRydmRhdGEuCj4+ID4+IAo+PiA+PiAgICAgcHdtOjpSZWdpc3RyYXRpb246OnJlZ2lz dGVyKCkgKHdoaWNoIGNhbGxzIHB3bWNoaXBfYWRkKCkpIGZhaWxzIGZvcgo+PiA+PiAgICAgc29t ZSByZWFzb24uCj4+ID4KPj4gCj4+IChKdXN0IHRyeWluZyB0byBoZWxwIGNsZWFyIHVwIHRoZSBj b25mdXNpb24uKQo+Cj4gVmVyeSBhcHByZWNpYXRlZCEKPgo+PiA+IElmIHlvdSBjYWxsZWQgcHdt Y2hpcF9hbGxvYygpIGJ1dCBub3QgeWV0IHB3bWNoaXBfYWRkKCksIHRoZSByaWdodAo+PiA+IGZ1 bmN0aW9uIHRvIGNhbGwgZm9yIGNsZWFudXAgaXMgcHdtY2hpcF9wdXQoKS4KPj4gCj4+IFRoYXQg aXMgZXhhY3RseSB3aGF0IGlzIGhhcHBlbmluZyB3aGVuIEFSZWY8Q2hpcD4gaXMgZHJvcHBlZC4g SWYgdGhlIHJlZmVyZW5jZQo+PiBjb3VudCBkcm9wcyB0byB6ZXJvLCBwd21jaGlwX3JlbGVhc2Uo KSBpcyBjYWxsZWQsIHdoaWNoIGZyZWVzIHRoZSBjaGlwLiBIb3dldmVyLAo+PiB0aGlzIHdvdWxk IGxlYXZlIHRoZSBkcml2ZXIncyBwcml2YXRlIGRhdGEgYWxsb2NhdGlvbiBiZWhpbmQsIHdoaWNo IGlzIG93bmVkIGJ5Cj4+IHRoZSBDaGlwIGluc3RhbmNlLgo+Cj4gSSBkb24ndCB1bmRlcnN0YW5k IHRoYXQuIFRoZSBjaGlwIGFuZCB0aGUgZHJpdmVyIHByaXZhdGUgZGF0YSBib3RoIGFyZQo+IGxv Y2F0ZWQgaW4gdGhlIHNhbWUgYWxsb2NhdGlvbi4gSG93IGlzIHRoaXMgYSBwcm9ibGVtIG9mIHRo ZSBkcml2ZXIKPiBwcml2YXRlIGRhdGEgb25seSB0aGVuPyBUaGUga2ZyZWUoKSBpbiBwd21jaGlw X3JlbGVhc2UoKSBpcyBnb29kIGVub3VnaAo+IGZvciBib3RoPyEKCk5vdCBpbiB0aGUgY3VycmVu dCBhYnN0cmFjdGlvbnMsIHRoZXJlIGFyZSB0d28gYWxsb2NhdGlvbnMsIG9uZSBmb3IgdGhlIENo aXAgYW5kCm9uZSBmb3IgdGhlIGRyaXZlcidzIHByaXZhdGUgZGF0YSwgb3IgaW4gb3RoZXIgd29y ZHMgdGhlIGFic3RyYWN0aW9uIHVzZXMKcHdtY2hpcF9zZXRfZHJ2ZGF0YSgpIGFuZCBwd21jaGlw X2dldF9kcnZkYXRhKCkuCgpIYXZpbmcgYSBicmllZiBsb29rIGF0IHB3bWNoaXBfYWxsb2MoKSwg aXQgc2VlbXMgdG8gbWUgdGhhdCBQV00gc3VwcG9ydHMgdGhlCnN1YmNsYXNzaW5nIHBhdHRlcm4g d2l0aCBwd21jaGlwX3ByaXYoKS4KCldlIHNob3VsZCBwcm9iYWJseSB0YWtlIGFkdmFudGFnZSBv ZiB0aGF0LiBBc3N1bWluZyB3ZSBkbyB0aGF0LCB0aGUgUnVzdAphYnN0cmFjdGlvbiBzdGlsbCBu ZWVkcyBhIHJlbGVhc2UoKSBjYWxsYmFjayBiZWNhdXNlIHdlIHN0aWxsIG5lZWQgdG8gY2FsbApk cm9wX2luX3BsYWNlKCkgaW4gb3JkZXIgdG8gZ2V0IHRoZSBkZXN0cnVjdG9yIG9mIHRoZSBkcml2 ZXIncyBwcml2YXRlIGRhdGEKdHlwZSBjYWxsZWQuIFdlIGFjdHVhbGx5IG1pc3NlZCB0aGlzIGlu IERSTSBhbmQgSSBmaXhlZCBpdCB1cCByZWNlbnRseSBbMV0uCgpATWljaGFsOiBXaXRoIHRoZSBz dWJjbGFzc2luZyBwYXR0ZXJuIHRoZSBDaGlwIHN0cnVjdHVyZSB3b3VsZCBsb29rIGxpa2UgdGhp czoKCgkjW3JlcHIoQyldCgkjW3Bpbl9kYXRhXQoJcHViIHN0cnVjdCBDaGlwPFQ+IHsKCSAgIGlu bmVyOiBPcGFxdWU8YmluZGluZ3M6OnB3bV9jaGlwPiwKCSAgICNbcGluXQoJICAgZGF0YTogVCwK CX0KCkFuZCBpbiB0aGUgcmVsZWFzZSgpIGNhbGxiYWNrIHdvdWxkIGxvb2sgbGlrZSB0aGlzOgoK ICAgIGV4dGVybiAiQyIgZm4gcmVsZWFzZShwdHI6ICptdXQgYmluZGluZ3M6OnB3bV9jaGlwKSB7 CiAgICAgICAgLy8gQ0FTVDogQ2FzdGluZyBgcHRyYCB0byBgQ2hpcDxUPmAgaXMgdmFsaWQsIHNp bmNlIFsuLi5dLgogICAgICAgIGxldCB0aGlzID0gcHRyLmNhc3Q8Q2hpcDxUPj4oKTsKCiAgICAg ICAgLy8gU0FGRVRZOgogICAgICAgIC8vIC0gV2hlbiBgcmVsZWFzZWAgcnVucyBpdCBpcyBndWFy YW50ZWVkIHRoYXQgdGhlcmUgaXMgbm8gZnVydGhlciBhY2Nlc3MgdG8gYHRoaXNgLgogICAgICAg IC8vIC0gYHRoaXNgIGlzIHZhbGlkIGZvciBkcm9wcGluZy4KICAgICAgICB1bnNhZmUgeyBjb3Jl OjpwdHI6OmRyb3BfaW5fcGxhY2UodGhpcykgfTsKICAgIH0KClRoaXMgaXMgZXhhY3RseSB3aGF0 IHdlJ3JlIGRvaW5nIGluIERSTSBhcyB3ZWxsLCBJIHdvdWxkIGhhdmUgcmVjb21tZW5kZWQgdGhp cwp0byBiZWdpbiB3aXRoLCBidXQgSSBkaWRuJ3QgcmVjb2duaXplIHRoYXQgUFdNIHN1cHBvcnRz IHN1YmNsYXNzaW5nLiA6KQoKSSByZWNvbW1lbmQgaGF2aW5nIGEgbG9vayBhdCBbMl0uCgpbMV0g aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjUwNjI5MTUzNzQ3LjcyNTM2LTEtZGFrckBr ZXJuZWwub3JnLwpbMl0gaHR0cHM6Ly9naXRsYWIuZnJlZWRlc2t0b3Aub3JnL2RybS9taXNjL2tl cm5lbC8tL2Jsb2IvZHJtLW1pc2MtZml4ZXMvcnVzdC9rZXJuZWwvZHJtL2RldmljZS5ycwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3Yg bWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=