All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Quaternions" <krakow20@gmail.com>
Cc: <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] gpu: nova-core: fix bounds check In PmuLookupTableEntry::new, data is sliced from 2..6, but the bounds check data.len() < 5 does not satisfy those bounds.
Date: Fri, 11 Jul 2025 21:04:48 +0900	[thread overview]
Message-ID: <DB97N2MN47L3.1F7450280ONEB@nvidia.com> (raw)
In-Reply-To: <20250711113327.39201-1-krakow20@gmail.com>

Thanks for the fix!

On Fri Jul 11, 2025 at 8:33 PM JST, Quaternions wrote:
> Signed-off-by: Rhys Lloyd <krakow20@gmail.com>

You will want to split the subject to something more minimal (e.g. "gpu:
nova-core: fix bounds check In PmuLookupTableEntry::new"), and use the
rest of the sentence as the patch description (as a rule of thumb, 70
chars for the subject, and kernel patches must all have a description).

Also your "From:" field must also match your "Signed-off-by".

./scripts/checkpatch.pl will complain about these points (and check
other things as well), so please make sure to run it before submission:

    WARNING: Missing commit description - Add an appropriate one
    WARNING: From:/Signed-off-by: email name mismatch: 'From: Quaternions <krakow20@gmail.com>' != 'Signed-off-by: Rhys Lloyd <krakow20@gmail.com>'

  parent reply	other threads:[~2025-07-11 12:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 11:33 [PATCH] gpu: nova-core: fix bounds check In PmuLookupTableEntry::new, data is sliced from 2..6, but the bounds check data.len() < 5 does not satisfy those bounds Quaternions
2025-07-11 11:33 ` [PATCH] gpu: nova-core: define named constants for magic numbers Quaternions
2025-07-11 12:18   ` Alexandre Courbot
2025-07-14 15:26     ` Joel Fernandes
2025-07-11 11:54 ` [PATCH] gpu: nova-core: fix bounds check In PmuLookupTableEntry::new, data is sliced from 2..6, but the bounds check data.len() < 5 does not satisfy those bounds Greg KH
2025-07-11 12:04 ` Alexandre Courbot [this message]
2025-07-11 12:20   ` Alexandre Courbot
2025-07-11 14:32     ` Rhys Lloyd
2025-07-11 14:55       ` Miguel Ojeda
2025-07-11 12:12 ` Miguel Ojeda
  -- strict thread matches above, loose matches on Subject: below --
2025-07-11  9:30 Quaternions
2025-07-11 18:03 ` Danilo Krummrich
2025-07-12  1:30   ` Rhys Lloyd
2025-07-12 13:11     ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB97N2MN47L3.1F7450280ONEB@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=krakow20@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.