From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: <intel-gfx@lists.freedesktop.org>, <andi.shyti@linux.intel.com>,
<krzysztof.karas@intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Replaced hardcoded value 4095 with PAGE_SIZE - 1
Date: Wed, 16 Jul 2025 14:01:45 +0000 [thread overview]
Message-ID: <DBDJ9CJS6I9M.1FZ1MVKPCPVTP@intel.com> (raw)
In-Reply-To: <j3q3mnt54wmdhoksxsx2ybv2z63j6femagt4kjmbyailbcpr3m@433enaxizil2>
Hi Andi
On Wed Jul 16, 2025 at 1:52 PM UTC, Andi Shyti wrote:
> On Wed, Jul 16, 2025 at 09:37:27AM +0000, Sebastian Brzezinka wrote:
>> The value 4095 is most likely intended to represent PAGE_SIZE - 1.
>
> "most likely"? We need to be sure :-)
4095 is an oddly specific number, and in this context, it looks to me
like PAGE - 1. I wrote 'most likely' because I want someone to confirm.
--
Best regards,
Sebastian
next prev parent reply other threads:[~2025-07-16 14:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 9:36 [PATCH 0/3] drm/i915: i915_gem_execbuffer.c minor improved Sebastian Brzezinka
2025-07-16 9:37 ` [PATCH 1/3] drm/i915: Refactor eb_relocate_vma for clarity Sebastian Brzezinka
2025-07-16 13:18 ` Krzysztof Karas
2025-07-16 13:49 ` Andi Shyti
2025-07-16 14:39 ` Sebastian Brzezinka
2025-07-16 17:28 ` Andi Shyti
2025-07-17 7:58 ` Sebastian Brzezinka
2025-07-17 9:38 ` Andi Shyti
2025-07-16 9:37 ` [PATCH 2/3] drm/i915: Add braces around the else block in clflush_write32() Sebastian Brzezinka
2025-07-16 13:47 ` Krzysztof Karas
2025-07-16 14:07 ` Sebastian Brzezinka
2025-07-16 13:51 ` Andi Shyti
2025-07-16 14:48 ` Sebastian Brzezinka
2025-07-16 9:37 ` [PATCH 3/3] drm/i915: Replaced hardcoded value 4095 with PAGE_SIZE - 1 Sebastian Brzezinka
2025-07-16 13:52 ` Andi Shyti
2025-07-16 14:01 ` Sebastian Brzezinka [this message]
2025-07-16 12:49 ` ✓ i915.CI.BAT: success for drm/i915: i915_gem_execbuffer.c minor improved Patchwork
2025-07-17 4:11 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBDJ9CJS6I9M.1FZ1MVKPCPVTP@intel.com \
--to=sebastian.brzezinka@intel.com \
--cc=andi.shyti@kernel.org \
--cc=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.