From: "Danilo Krummrich" <dakr@kernel.org>
To: "Beata Michalska" <beata.michalska@arm.com>
Cc: <ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<aliceryhl@google.com>, <daniel.almeida@collabora.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <tmgross@umich.edu>,
<alyssa@rosenzweig.io>, <lyude@redhat.com>,
<rust-for-linux@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments
Date: Mon, 21 Jul 2025 17:33:50 +0200 [thread overview]
Message-ID: <DBHUCKLO3YG6.3MFXYIE4XZMN1@kernel.org> (raw)
In-Reply-To: <20250626162313.2755584-1-beata.michalska@arm.com>
On Thu Jun 26, 2025 at 6:23 PM CEST, Beata Michalska wrote:
> With the Opaque<T>, the expectations are that Rust should not
> make any assumptions on the layout or invariants of the wrapped
> C types. That runs rather counter to ioctl arguments, which must
> adhere to certain data-layout constraints. By using Opaque<T>,
> ioctl handlers are forced to use unsafe code where none is actually
> needed. This adds needless complexity and maintenance overhead,
> brining no safety benefits.
> Drop the use of Opaque for ioctl arguments as that is not the best
> fit here.
>
> Signed-off-by: Beata Michalska <beata.michalska@arm.com>
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
The patch does not apply on top of drm-misc-next and does not have a base
revision.
Can you please let me know which commit this patch applies on top of or resend?
- Danilo
next prev parent reply other threads:[~2025-07-21 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 16:23 [PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments Beata Michalska
2025-07-21 14:55 ` Alice Ryhl
2025-07-21 15:06 ` Danilo Krummrich
2025-07-21 15:22 ` Daniel Almeida
2025-07-21 15:33 ` Danilo Krummrich [this message]
2025-07-21 15:41 ` Daniel Almeida
2025-07-21 15:42 ` Daniel Almeida
2025-07-21 15:58 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBHUCKLO3YG6.3MFXYIE4XZMN1@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=alyssa@rosenzweig.io \
--cc=beata.michalska@arm.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.