From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Christian" <christiansantoslima21@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] rust: transmute: Add methods for FromBytes trait
Date: Sat, 26 Jul 2025 11:57:21 +0900 [thread overview]
Message-ID: <DBLNE36GEIZK.25GHWE9UTLUBX@nvidia.com> (raw)
In-Reply-To: <CABm2a9dh9wGPdh+HofM5uZts_O7kFMyKwtGRdxbEw7wsxHvAUQ@mail.gmail.com>
Hi Christian,
On Sat Jul 26, 2025 at 3:37 AM JST, Christian wrote:
> Hi, Alexandre.
>
>> To clarify, I am not complaining about the `Self: AsBytes` requirement,
>> I am just pointing out that you will need to update the sample so it
>> keeps building. :)
>
> I see, I was just justifying the decision, sorry if it sounded a bit
> aggressive. English isn't my primary language, and mistakes happen.
> Now, about the patch. Should I submit a patch to fix the broken build?
Your English sounded perfectly fine as far as I can tell (not a native
speaker myself :)).
Yes, please send a v9 addressing the remaining issues we had on v8.
Hopefully we can gather a few Reviewed-by and merge it.
>
>> Sounds good to me as well!
>
> Should I submit this patch to nova-next?
Just sending it the same way you did so far will be fine, all the
relevant folks are watching.
next prev parent reply other threads:[~2025-07-26 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 4:28 [PATCH v8] rust: transmute: Add methods for FromBytes trait Christian S. Lima
2025-06-25 2:39 ` kernel test robot
2025-07-07 5:14 ` Alexandre Courbot
2025-07-14 22:16 ` Christian
2025-07-22 14:06 ` Alexandre Courbot
2025-07-25 18:37 ` Christian
2025-07-26 2:57 ` Alexandre Courbot [this message]
2025-07-27 1:37 ` Kane York
2025-07-28 19:39 ` Christian
2025-07-28 21:21 ` K. York
2025-08-01 12:26 ` Alexandre Courbot
2025-08-01 15:35 ` Miguel Ojeda
2025-08-01 17:47 ` Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBLNE36GEIZK.25GHWE9UTLUBX@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=christiansantoslima21@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.