Re: [PATCH v8 1/2] rust: alloc: add alignment tests for allocators

["Danilo Krummrich" <dakr@kernel.org>]

On Thu Jul 31, 2025 at 10:42 AM CEST, Hui Zhu wrote:
> diff --git a/rust/kernel/alloc/allocator.rs b/rust/kernel/alloc/allocator.rs
> index 63f271624428..a20111b40529 100644
> --- a/rust/kernel/alloc/allocator.rs
> +++ b/rust/kernel/alloc/allocator.rs
> @@ -184,3 +184,59 @@ unsafe fn realloc(
>          unsafe { ReallocFunc::KVREALLOC.call(ptr, layout, old_layout, flags, nid) }
>      }
>  }
> +
> +#[macros::kunit_tests(rust_allocator)]
> +mod tests {
> +    use super::*;
> +    use core::mem::MaybeUninit;
> +    use kernel::prelude::*;
> +

<snip>

> -#[macros::kunit_tests(rust_kvec_kunit)]
> +#[macros::kunit_tests(rust_kvec)]
>  mod tests {
>      use super::*;
>      use crate::prelude::*;

I think v7 was fine. David probably confused "rust_allocator" with "rust_kvec".
Renaming the kvec kunit tests should, as you correctly did in v7, indeed be a
separate patch.

No need to resend now, I think we can just pick v7.

In general, please send new version a little bit less frequent to leave some
time for people to comment.

Thanks,
Danilo