From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13DF626E71A; Thu, 31 Jul 2025 09:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753952468; cv=none; b=tq3UlMvvc+RToChwFYRUq4hEmQkrBKYWS9AIuN7/iDdOrFpR2vRsOUxbMhIoUlSq4IsBg1qUJKdw8d9Kj5e6Gi+NX7/1+6ZpjfCS377c3XMAWviaL12i9Oulhh5Q4Su3i4JDNdV2c1OMirUTizs+9Clj4ZB1jbpZvTbz5wFK0bk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753952468; c=relaxed/simple; bh=OzBf+6tjHlFFol6frCSMTO760o8bn44Yd0IKA9X+/nk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=s7Yns0aQz5edHBru5vBoYLCi7VwMWz5E7omuPV8FxUKTalbInE+X+fHxaWe3X8XJxBbTJBOebL179SQsZQM1xiNt/6Ph/Nd2ENupFtUaaYdk6oAwK1LXvUc1r+j/SltdGQpfryb8YlXS1foTHc4Na/jGtHkMoDi0nqn2PxQIf1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mOxFGn9h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mOxFGn9h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D60C5C4CEEF; Thu, 31 Jul 2025 09:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753952467; bh=OzBf+6tjHlFFol6frCSMTO760o8bn44Yd0IKA9X+/nk=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=mOxFGn9hqOiv/tnVRGVPcphy6xctJwyi/J2LY3mLXgfLe+hbzf98qlXSBnhkR2So+ LqaUu9qCD4VLgaX7Q9kPSN2oF6V0x4nBQa3rIJS66/l1Ws+Y/yWeCsg3zaGIHcOPU1 A4kVkp4pPozbuUKlzH/mivCm1a8Xwtl0AlADW8UDysrADnzQjVsNkWHCnWthiglCUG zA4Y991iImlKb7/W34/VYPszyl5v8O5wHbIn8EQNLujg+YkoqSW9o/zcaxlnKN+spK pFGqE5KmD0thkTBf9PDCB0VcrITCn8MReg1YukXl9tNVUP7NT/u6yvaqpMCO8+SYEL 8npo99YuNK6VA== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 31 Jul 2025 11:01:02 +0200 Message-Id: Subject: Re: [PATCH v7 0/3] Rust allocator and kvec improvements Cc: "Hui Zhu" , "Lorenzo Stoakes" , "Vlastimil Babka" , "Liam R . Howlett" , "Uladzislau Rezki" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , , , , , "Hui Zhu" To: "David Gow" From: "Danilo Krummrich" References: In-Reply-To: On Thu Jul 31, 2025 at 6:14 AM CEST, David Gow wrote: > On Thu, 31 Jul 2025 at 10:51, Hui Zhu wrote: >> >> From: Hui Zhu >> >> This series adds tests and docs for Rust kernel components: >> Patch 1 adds KUnit tests for allocator alignment guarantees. >> Patch 2 documents KVec::as_slice with a usage example. >> Patch 3 simplifies KVec test module naming convention. >> >> Both patches are co-developed with Geliang Tang. Based on [1]. >> Tested on x86_64 using KUnit. >> > > This series looks good to me from a KUnit perspective. I've also > tested it out across a bunch of architectures (UML, x86_64, arm, > arm64) with no problems. > > A few minor notes: > - You should squash patch 3 into patch 1: there's no need to introduce > the test with one name only to rename it in a later patch. The test introduced in patch 1 is not the one renamed in patch 3. :)