All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: <ojeda@kernel.org>, <alex.gaynor@gmail.com>,
	<boqun.feng@gmail.com>, <gary@garyguo.net>,
	<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
	<a.hindborg@kernel.org>, <aliceryhl@google.com>,
	<tmgross@umich.edu>, <abdiel.janulgue@gmail.com>,
	<acourbot@nvidia.com>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] rust: page: implement BorrowedPage
Date: Tue, 05 Aug 2025 15:20:41 +0200	[thread overview]
Message-ID: <DBUIWSMQV4RY.21AWM08X1DNZR@kernel.org> (raw)
In-Reply-To: <DBUIBXEOODEH.R2NYIGUDBZC7@kernel.org>

On Tue Aug 5, 2025 at 2:53 PM CEST, Danilo Krummrich wrote:
> On Tue Aug 5, 2025 at 2:30 PM CEST, Daniel Almeida wrote:
>>> +/// Representation of a non-owning reference to a [`Page`].
>>> +///
>>> +/// This type provides a borrowed version of a [`Page`] that is owned by some other entity, e.g. a
>>> +/// [`Vmalloc`] allocation such as [`VBox`].
>>> +///
>>> +/// # Example
>>> +///
>>> +/// ```
>>> +/// # use kernel::{bindings, prelude::*};
>>> +/// use kernel::page::{BorrowedPage, Page, PAGE_SIZE};
>>> +/// # use core::ptr;
>>> +/// # use core::ptr::NonNull;
>>> +///
>>> +/// trait PageOwner {
>>
>> What is this trait for? Perhaps this assumes some previous discussion that is
>> not in the patch itself?
>
> It's just example code to show how a BorrowedPage may be obtained from something
> that owns a page, i.e. a PageOwner.

Maybe let me simplify the example a bit and just use the following function for
the example instead of the generic trait approach.

	 fn borrow_first_page<'a>(vbox: &'a mut VBox<MaybeUninit<[u8; PAGE_SIZE]>>) -> BorrowedPage<'a>

  reply	other threads:[~2025-08-05 13:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 19:50 [PATCH] rust: page: implement BorrowedPage Danilo Krummrich
2025-08-04 20:02 ` Benno Lossin
2025-08-04 20:08   ` Danilo Krummrich
2025-08-05 12:15 ` Alexandre Courbot
2025-08-05 12:18 ` Alice Ryhl
2025-08-05 12:30 ` Daniel Almeida
2025-08-05 12:53   ` Danilo Krummrich
2025-08-05 13:20     ` Danilo Krummrich [this message]
2025-08-05 13:29     ` Daniel Almeida
2025-08-05 17:07       ` Andreas Hindborg
2025-08-05 17:18         ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBUIWSMQV4RY.21AWM08X1DNZR@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.