Re: [PATCH v2 3/6] rust: alloc: vmalloc: implement Vmalloc::to_page()

["Alexandre Courbot" <acourbot@nvidia.com>]

On Thu Aug 7, 2025 at 5:50 AM JST, Danilo Krummrich wrote:
> Implement an abstraction of vmalloc_to_page() for subsequent use in the
> PageOwner implementation of VBox and VVec.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

One minor nit about the example below.

> ---
>  rust/kernel/alloc/allocator.rs | 49 ++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>
> diff --git a/rust/kernel/alloc/allocator.rs b/rust/kernel/alloc/allocator.rs
> index aa2dfa9dca4c..2315f5063011 100644
> --- a/rust/kernel/alloc/allocator.rs
> +++ b/rust/kernel/alloc/allocator.rs
> @@ -15,6 +15,7 @@
>  
>  use crate::alloc::{AllocError, Allocator};
>  use crate::bindings;
> +use crate::page;
>  use crate::pr_warn;
>  
>  /// The contiguous kernel allocator.
> @@ -140,6 +141,54 @@ unsafe fn realloc(
>      }
>  }
>  
> +impl Vmalloc {
> +    /// Convert a pointer to a [`Vmalloc`] allocation to a [`page::BorrowedPage`].
> +    ///
> +    /// # Examples
> +    ///
> +    /// ```
> +    /// # use core::ptr::{NonNull, from_mut};

Maybe make these imports visible, as otherwise the reader might wonder
where `from_mut` comes from (I did :)).